From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC34EB64DA for ; Mon, 10 Jul 2023 14:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 197986B0072; Mon, 10 Jul 2023 10:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1484B6B0074; Mon, 10 Jul 2023 10:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00F7F6B0075; Mon, 10 Jul 2023 10:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E54926B0072 for ; Mon, 10 Jul 2023 10:44:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AB589160151 for ; Mon, 10 Jul 2023 14:44:59 +0000 (UTC) X-FDA: 80995974318.14.5AE7570 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id D1E7520002 for ; Mon, 10 Jul 2023 14:44:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZOh9PSn4; spf=none (imf13.hostedemail.com: domain of mkoutny@suse.com has no SPF policy when checking 195.135.220.28) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689000297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2dSDCIryhoqYz8ZS1bBqRNqc86fubisnGZKJq77QBlA=; b=U1pFHt77vSI/8HpIVKRJo4BgZyiWOhRZzGWMeawlaavJ2a+rJl4Zy72p3wP429RF60APi6 vvlU01ZaD++PT/4+hXivyF9AQQ5uUuxosRQrVL0uVWpdcU516N35U8zMgnpHdFt/a1iH/E DIaTgwDdXWcFcYaVczKLioNVE1gG76Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689000297; a=rsa-sha256; cv=none; b=6cM/r9vUwYA7SEJTVrnDj4itXFRvuC5LhDllUj/+QlKmf5zBsk343V3yRv0HHRU1m0iK1v L68aT5PybZhKMH5SluVyLZynmig8krMgeEBt84e9f14j3vX9TzmgXgJZ2vFQrc4NOOHrww 9Fhg76VtognNFCN398Q06EZYnfyiv0Q= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZOh9PSn4; spf=none (imf13.hostedemail.com: domain of mkoutny@suse.com has no SPF policy when checking 195.135.220.28) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 38B7721AE8; Mon, 10 Jul 2023 14:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1689000295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2dSDCIryhoqYz8ZS1bBqRNqc86fubisnGZKJq77QBlA=; b=ZOh9PSn4qAb49Y/vRW4RvILvHVqDNm8r7BSRKjNFgqVMKsAHnK+MLjUCMjalAB1ujYKCXP VH9Y13+ev6/vDr7W357nCLvnoVwnsFHEaGMUZGMQZXiDaIpzdjn2cZa1YiBoRWsDx1qnAW cfgvONSAD46IH0pcuEFK25CaUCcA8C8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0743A13A05; Mon, 10 Jul 2023 14:44:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mijkAGcZrGSrSgAAMHmgww (envelope-from ); Mon, 10 Jul 2023 14:44:55 +0000 Date: Mon, 10 Jul 2023 16:44:53 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Ivan Babrou Cc: cgroups@vger.kernel.org, Linux MM , kernel-team , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-kernel Subject: Re: Expensive memory.stat + cpu.stat reads Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b77s5ccberk4hrjr" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D1E7520002 X-Rspam-User: X-Stat-Signature: tkz34hhac754wumxxxwjt83t6e18faou X-Rspamd-Server: rspam03 X-HE-Tag: 1689000296-858297 X-HE-Meta: U2FsdGVkX18K1IqkmHw/ytbvd+oPEk3yMGJrQ3RFcHbq+OFBmQvjtoHntnwoWOqqNGNzeE3ezNPlV2d74lzwbrTW3DNqFiMYgsBzWrPM7JHGGiiRFKfhHOJ/pqgV5d+uHgcyM6wi4XPl+6IR4L8xdC8+gidLWBEpJtEZM34w0y3eYW+OanBMLUY9f+EcYqcXJisAJkAY2B4ywqAIeN7F5kG3CHGp+d0TDeL2QlE+f6X5/owe4LSpnVUhXzqB7084+7IVE2fwCjIXESce7F6xBkNDuYLDkuLP2q/B455krYjMld2MIyWPRihzJ2Cy6p0qYtohdJX1KSkr6HoT2h+SVodPQbaQKFYqB3/d0Kuvjhm6I0ghz7d8gFe0/mOlMpht9KA1UUiM1makyhXWAUWVkT2FiSOvLhI7CTxztdcAGbHhu/WLfywhnNlLbtnTRX/S2a24OtCvt2XwRuAezZl/ZLRXZ3ogazfDctGXmFpyjpRKtHGHOnuSl+nDgBJDkx3mebOjFGPvAlWbYlXUW3W86Y/Bs+eOGdURhd83iHt3Ai1R9lyzOojNQWY2+rNVOmw9vdc3x0XkqJkk3/lA4rTt4UOopOTXN2NwK+iV4AUIZv8Nb5rUTm0625VtrrK6QnnKyaq08IdZgAwQ3k3NkTgWjL/HfE6MoZt6rKWogWEAUhH/rAMiKvEHPfuapmlPqPBDFKHKYgoNI9M0uZTBNVn3P+Rh3dOFmXTY8czIQxUSeQ5lMAAcTk086gLMqzS3ijg0+niKr55vTvb3Eok6C13xn/H4AAF/mGE5zyK5Y4jQiJFWXtRw49OeQwXSepTmdfxWE//2Pkf1t94MyfLB55pc2TcdgYpnB9M+9xtOxAI4zaCrJdvjAmUBqtQ1FfsI+m9Ey786UUz9jNUjSBVBtJSPpP/K1/ZP5ORYkBuFx7/d7n/nTsOU6k+XrRFQe9CQTaeaaPiB7LEj5zs7Tj0RCiL HVaXJX8x erMF109P6vWoeLU8is2BszBqBn5y2UcqOy+eLbDBqBxczhFY77SKfvSmkxemgE+Rsq4XHnHoMNp+egGZ1ozQtu5uBsG5qKvYRoaBBp8V2KsThMMAZCxKNvQjtATAJ7CYydzQgJPukhV86O6TQ7kmQkkJi3JJYKZMuZSmkHiQLyf9Y4M0AVAGJUSlNOprK0omdku9kFjfTNVBWBIdJ8lUL+R7EL25s2n3nuCASyzVcWSvMA+oNz1flLU1Cb9kaT64ZydVWX3ABYU0E7vbu+PigoY1/Gy3GKkodZ2LlHsGvSVgysb+5qx7CDlmE7y/bsRFRBbuyjYcYa5Zjk+up2hHAaAlehv7fBcUYQmMXriGCcB8JAw8MWxzW/Om0Sw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --b77s5ccberk4hrjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Fri, Jun 30, 2023 at 04:22:28PM -0700, Ivan Babrou = wrote: > As you might've noticed from the output, splitting the loop into two > makes the code run 10x faster. That is curious. > We're running Linux v6.1 (the output is from v6.1.25) with no patches > that touch the cgroup or mm subsystems, so you can assume vanilla > kernel. Have you watched for this on older kernels too? > I am happy to try out patches or to do some tracing to help understand > this better. I see in your reproducer you tried swapping order of controllers flushed.=20 Have you also tried flushing same controller twice (in the inner loop)? (Despite the expectation is that it shouldn't be different from half the scenario where ran two loops.) Thanks, Michal --b77s5ccberk4hrjr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZKwZYwAKCRAGvrMr/1gc jkiaAP0cMXwbvKMrd3UFe9bkgPZXxl1WeME+caCgKNQqMZaS1AD/eGWbOeKD5V7A KBibSziS+oGtgU+Wg7XvKGBFaasJZA4= =jPdL -----END PGP SIGNATURE----- --b77s5ccberk4hrjr--