From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA25C4345F for ; Mon, 29 Apr 2024 21:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5B4C6B007B; Mon, 29 Apr 2024 17:59:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E42A6B0083; Mon, 29 Apr 2024 17:59:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ABC16B0085; Mon, 29 Apr 2024 17:59:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6BB016B007B for ; Mon, 29 Apr 2024 17:59:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B82040326 for ; Mon, 29 Apr 2024 21:59:32 +0000 (UTC) X-FDA: 82063936584.21.9358AFF Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 3549020004 for ; Mon, 29 Apr 2024 21:59:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ixxDWaYp; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714427969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2oq8GpknbuUizjxkKnYJjGUQCiIjEtDOZULkmvv0Vfs=; b=NbcbtsMYuZcRnJOSLeP3Ee+9nFpsLlqqXwuh6WgVal2UyTGqv0jyAAlsvtWI6uAE0RC2tM V1nQxLMcAOwNco0BIYvcmwya4xvmbX227vfCAcSCYIWnFRA0e2Exl5vZgw6GshEB0Kh3PZ 9QBRbsJa529DExO2RWMWCZL7jVItC2o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ixxDWaYp; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714427969; a=rsa-sha256; cv=none; b=MSl+MH19PO1O0D9Ka2TY3wNp0aFYQeLj0MYfqoAEsk4CmQkNY0CgBM55EynQLymSwlaczu 17fee1TqhCFFi3yC0lkzxDo4lJtSvk0uWDKlfSJmN3UHu3M1kf7WDeLdfWK6mBFX7MXrFo aBQ62KmI5jp0tvbympZwH1J4FsWiRoo= Date: Mon, 29 Apr 2024 14:59:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714427967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2oq8GpknbuUizjxkKnYJjGUQCiIjEtDOZULkmvv0Vfs=; b=ixxDWaYpir3Wna7zhULD0rDFlZCTLryAoW7WU11UVrwuHqwNsrvNiRagbc6zExkzSrcFzK IKfT0T/zXOd2uOg4/R6TnRAOMeZ59JeTJyWRoWhzm3thd3XZq7KC0lQUSUcOwDEs06tvF2 wQ2ttgJn8cCQ2VMbm5P1Pr4rGyoxPnE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] memcg: dynamically allocate lruvec_stats Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-3-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 3549020004 X-Rspamd-Server: rspam06 X-Stat-Signature: rnar7frh8pjtd5gsxiyeutgzhx6z131p X-HE-Tag: 1714427969-285705 X-HE-Meta: U2FsdGVkX19MlqA6Rz0FuoOsNRrfAPTWqsWGOtIla9tOhfQLQx0rGDnWq6rLCFJQkA+Zu6Yexc35c6oWeOOh9O1ONyLAo1BUCOI/HLz5RevEMjABXIaMdvR4FKh7S3uAdF65AK9x0ccARn41O9IcVU3ORu2jV3y+bSULuqV/LJaZ4DKN2STo9d3JnysOhX12g7TTNG0LPE5JuPHN5+0rs4l9V36NuETcttiKpQDNRT0Nx773KkAclZecLdZq4zuMdiv62peIfFLrzh8n6rtPVNujKYCy2udTR6Nf2ARY5AaLIkCkwRXLu4A40dHgp+YEvGPuWtafXZBAG1NIPoIi/YYOu+kOC9EQ3awtA9RaH5T8rhmGoI6k8bCop7k0EhaoK1dmWQR8D/XQXHAuKDUVUGeFpDkuvh/Uz5UGgs2kuzILfW1Rc4bT3079KbLstZJ3u56BeSdsfMIM8aEUoWkeKra/va947xTwilX4bBOJC38vJCvEpDIEWqZ7Pnn9w+rsSGGb7WaacFvMerGHJX4dAlN03SU7uVivAevISbJeUhwUrFQI8V0ny3pnWu/kpg6K+8ndbcDGey4mA4ijRHaZL6geqjj+Zo1Vb6Qemqf4XbD2VJ3+c6NFmDeWsqtS2t9YXDveAjmsgo/MvrTqRAPf/EwffVEKfUmYgUGaDkgJ/bjpYMJ53D98u0v9plNRTQFhh+Gab/EwLSl6/NwU4uYA+OUMtGf292XbgWRACzc/+Is2PqBCiLNir6ENva35Z9l+OUrgnB5c4Ck5T2a9anBVew/e18ZnuQ5JN/v42Ym1vbVF2yV/fiLmmqc1kuxiSIOCtW7gaH3C/X194FfIxL742Cxkwx9HC8OK4XdJYVLtRN1K9sxbdq1iURFbtfd+kpsHp6Q0IugN0epxwcrFwmUDfFLLDyGDoG2l4r/z4BM/CR5BgJpvlqVTjU8CbGelx7S3f9P+6/zkrZ2W3jgZ3aj 9iULR91J 160AaosQDc5bxM+vmO12tTKHvJdwPiz34k+bnVpRR5IuWRbK1I8kusPPWatMETqrUqIpbm82L8WaOY9WzzKrNmMtn4K91r6o9wTbLPpcSTh7CHvb+MgGLTRwqkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 02:02:23PM -0700, Roman Gushchin wrote: > On Mon, Apr 29, 2024 at 12:46:32PM -0700, Shakeel Butt wrote: > > On Mon, Apr 29, 2024 at 08:50:11AM -0700, Roman Gushchin wrote: > > > On Fri, Apr 26, 2024 at 05:37:28PM -0700, Shakeel Butt wrote: > > [...] > > > > > > + return x; > > > > +} > > > > + > > > > /* Subset of vm_event_item to report for memcg event stats */ > > > > static const unsigned int memcg_vm_event_stat[] = { > > > > PGPGIN, > > > > @@ -5492,18 +5546,25 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > > > > if (!pn) > > > > return 1; > > > > > > > > + pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats), GFP_KERNEL, > > > > + node); > > > > > > Why not GFP_KERNEL_ACCOUNT? > > > > > > > Previously struct lruvec_stats was part of struct mem_cgroup_per_node > > and we use GFP_KERNEL to allocate struct mem_cgroup_per_node. I kept the > > behavior same and if we want to switch to GFP_KERNEL_ACCOUNT, I think it > > should be a separate patch. > > Agree. Here is the patch: Awesome, I will pull this in my v3 post. > > -- > > From fd6854c0b272c5314bce6c9dee7d3c8f8cee3a86 Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Mon, 29 Apr 2024 13:57:26 -0700 > Subject: [PATCH] mm: memcg: account memory used for memcg vmstats and lruvec > stats > > The percpu memory used by memcg's memory statistics is already accounted. > For consistency, let's enable accounting for vmstats and lruvec stats > as well. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt > --- > mm/memcontrol.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d11536ef59ef..2fe25d49cfaa 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5661,8 +5661,8 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > if (!pn) > return 1; > > - pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats), GFP_KERNEL, > - node); > + pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats), > + GFP_KERNEL_ACCOUNT, node); > if (!pn->lruvec_stats) > goto fail; > > @@ -5733,7 +5733,8 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) > goto fail; > } > > - memcg->vmstats = kzalloc(sizeof(struct memcg_vmstats), GFP_KERNEL); > + memcg->vmstats = kzalloc(sizeof(struct memcg_vmstats), > + GFP_KERNEL_ACCOUNT); > if (!memcg->vmstats) > goto fail; > > -- > 2.43.2 >