From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D492C4167D for ; Mon, 11 Dec 2023 18:59:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C19A6B01F0; Mon, 11 Dec 2023 13:59:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 072996B01F1; Mon, 11 Dec 2023 13:59:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7C656B01F2; Mon, 11 Dec 2023 13:59:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D6A266B01F0 for ; Mon, 11 Dec 2023 13:59:27 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A223A807C6 for ; Mon, 11 Dec 2023 18:59:27 +0000 (UTC) X-FDA: 81555450774.12.2519296 Received: from postout1.mail.lrz.de (postout1.mail.lrz.de [129.187.255.137]) by imf09.hostedemail.com (Postfix) with ESMTP id ADD41140010 for ; Mon, 11 Dec 2023 18:59:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=OD+eLULt; spf=pass (imf09.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702321164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KggLwwMr4K2s7yjk+3jiz5Ko6D5Gf137eV//dqR0DIY=; b=ERBCtH4LbjswTWPqJdHiqpi3WztDQFriNJyiZ+VRg629opa7GMJZzV2u46aQ/AHMPAvDh6 f/7Mgrwfbfa7nAIKUkQJGn87QYXILEMaLMBVpJ0g+evbk2Cjx3Q3qDYfd5F1Eq+KGpWCyC GgMCehij1TVTAFiUAeSjBt9kR7z+hwc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=OD+eLULt; spf=pass (imf09.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702321164; a=rsa-sha256; cv=none; b=4iSmdRxWpvvYgfwIZYghTwJKEe4ibqnRXTuSyT4jjlE+XEbTXP2Pod9ybzPH0VUJoIG7I0 423g16jhr1cw6SLGCcDErbc6QTOKX09myK0x4m9eeDTU2DPuCa2minYzzaUDpIXUnyOl5C C0PCh7l4ghNzrab3wSt/WtV6xj/VhD4= Received: from lxmhs51.srv.lrz.de (localhost [127.0.0.1]) by postout1.mail.lrz.de (Postfix) with ESMTP id 4SprdL22mNzyTc; Mon, 11 Dec 2023 19:59:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= in-reply-to:content-transfer-encoding:content-disposition :content-type:content-type:mime-version:references:message-id :subject:subject:from:from:date:date:received:received; s= tu-postout21; t=1702321156; bh=wzxkPiBTm3s8ZGp87MxJnVY/QY6RAgQlb fQjTK03dlg=; b=OD+eLULtQirJNVgNfxfD5We9/CnESR3bql7En7h6xjEkCVHqJ /VnNO/xymw6jV9CfXtOQyeeqS22wLqXgnd0Mq+Zm9Ur9sABCAwx0YxqyuXyQvbkU xnIClFKRbPMemo/qb8gb8lN9Ll65aFOCsWRgtrIAF1/0IBT89rB6gC4T6PZbMYph AeHr1LiiRx3Hk4ieM3JCyf727JUcWNSvr6G8Rhxo2oLzKBO4qThwZjRa/kz+6vtm zhOKYbsv2NIgrXkIwyTJY7NT7e5eJ0oK7GAGnRpFMrN51gNd57G8spCj4GjZldHF sIW2SInC3qweh6Larylr9jRDyDS2GnKuyHzMw== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs51.srv.lrz.de Received: from postout1.mail.lrz.de ([127.0.0.1]) by lxmhs51.srv.lrz.de (lxmhs51.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id fmaQedN7hfuU; Mon, 11 Dec 2023 19:59:16 +0100 (CET) Received: from Monitor.dos.cit.tum.de (Monitor.dos.cit.tum.de [IPv6:2a09:80c0:38::165]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by postout1.mail.lrz.de (Postfix) with ESMTPSA id 4SprdH6P1fzySj; Mon, 11 Dec 2023 19:59:15 +0100 (CET) Date: Mon, 11 Dec 2023 19:59:10 +0100 From: Paul =?utf-8?Q?Heidekr=C3=BCger?= To: Andrey Konovalov Cc: Steven Rostedt , Peter Collingbourne , Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: References: <20230215143306.2d563215@rorschach.local.home> <20230505095805.759153de@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: ADD41140010 X-Rspam-User: X-Stat-Signature: mgdnftsp8bjxp78ziqwiw3ko8qbsse3j X-Rspamd-Server: rspam01 X-HE-Tag: 1702321163-226915 X-HE-Meta: U2FsdGVkX18F3mafYtJ9b1HYV2B7h+vRDw9GWnZUQHhz/55fNn/jAT+eiNqqgzROjuKWRWXx6FWfS/uUVzfgP1nr/G+01LnYTPKy2gx0WwyOlcY8gGHpbiQNYmMnPy24YKx1WvHyxY9399ETs2De2SJ1Hl6VBs968WwLkmeCskojWx9si9ssQ92Y8Gik0DLr8Y+9LRgzYRuPpVrKmlvI8Z6zegxv1AXmCBPCLFF7dkTiz3lkv47ltV1pdciuL43IIiQT4yBpJ2WsTsZITIppBY5ZiuA6sDIg646Hzcjn+lpl9RCySIiB+4V+KpUG+GZv6t5tM/TF4tdiYKtGVKHNRLGuQ/aR8IipbUtj1ejapBDsej30kQxw363BLGf0PHPGcdv3cTcc6ecer3OQd79dK4X90gzI6vdGQpdQ94kxfBQ+sblN90fFBTRIOBw9hZXsewTaPWz9v68AmFQ4A4bsqLNXwylCIQXECLpKmFq8sC1fDBuUhBUi0ePA9//FwrlrLNTFQj/Ls2X+jgsa5eUnAD7EgajQdHQhC8g7SKzLYtXctVHSRPoO8S0pnqdIVZlQBB9i58xdUTmF6Tkc+MXKLlN22JZPuiu4q6lXfOERfQckvt1zsS670rfve7Xchaz9Z03uNI+UNwcgnFfYYtWrQ3tBfVPs2c1W8HHmKLVsViPgHV/ly6Xmv0FSbajgGpqkAGF/vOijhx/0vo0rjxhokQBM19L+5+6kup9P19XegnfQyYUJ3WhnfkPrfWrGl58Btm8JOlPTOtbs8WYwLdg7ymjTH0G0a5gVw4KOB3xhX0Pkt8nizM/PH8ndxCFDI+c5swoJ7AN5bqfD7szFBYzCugvx7jHazkSl/IpI6pZTOcmTGLn6g8XnGn4g4ZoxEmo/tnXODes48oxaaT6tKjLTQNECVHUbRF2eodkxtlyyWwQ12oXaG0TPdmTBv2fESdmuNElJbVr1JujzKf9FBGH CYLG2bqD uh7ph2yDJJCy8ig3ECD9jeb1uEMmJo9eiCqc+S69TFJ3Vq/KfVAozRLbHRwR7hAmFGqaDHOAbNtmRMa4vC5F9NsOamm4G2rXEQJKk8VyEyH6/QeWLr1vpN+RL0wHJHtmQte39rKIfBVJA2aBj5OEmW+pNAKbzkWahp5CvViP+9jdtB/5LZFMderpx9gmfaFwEGlJ62sk+OOWpjodI/6RnZJPUfm2E682aPdPLlLVmnpEWxkjiYLCOag31PClTfrHtF2/EWNtiLb3rKDyNWyJ7HEXB51P7rnZNVumk6QT6zT/UT5WVA7QWuoTHl3fzHRghhSBz9eDl97Fsej+8sap86Ueq1ezM+bnhphKDzg7fSzDUyCOAC3KMYgtXXIobVBoKtRja X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrey! On 11.12.2023 18:50, Andrey Konovalov wrote: > On Mon, Dec 11, 2023 at 5:37 PM Paul Heidekrüger > wrote: > > > > Hi all! > > > > On 05.05.2023 09:58, Steven Rostedt wrote: > > > On Mon, 1 May 2023 15:02:37 -0700 > > > Peter Collingbourne wrote: > > > > > > > > > "ftrace" is really for just the function tracing, but CONFIG_FTRACE > > > > > > really should just be for the function tracing infrastructure, and > > > > > > perhaps not even include trace events :-/ But at the time it was > > > > > > created, it was for all the "tracers" (this was added before trace > > > > > > events). > > > > > > > > > > It would be great to see this cleaned up. I found this aspect of how > > > > > tracing works rather confusing. > > > > > > > > > > So do you think it makes sense for the KASAN tests to "select TRACING" > > > > > for now if the code depends on the trace event infrastructure? > > > > > > > > Any thoughts? It looks like someone else got tripped up by this: > > > > https://reviews.llvm.org/D144057 > > > > > > Yeah, it really does need to get cleaned up, but unfortunately it's not > > > going to be a trivial change. We need to make sure it's done in a way that > > > an old .config still keeps the same things enabled with the new config > > > settings. That takes some trickery in the dependency. > > > > > > I'll add this to my todo list, hopefully it doesn't fall into the abyss > > > portion of that list :-p > > > > > > -- Steve > > > > Just adding to Peter's concern re: CONFIG_KASAN_KUNIT_TEST's dependency on > > CONFIG_TRACEPOINTS. > > > > I'm having no luck running the KASan KUnit tests on arm64 with the following > > .kunitconfig on v6.6.0: > > > > CONFIG_KUNIT=y > > CONFIG_KUNIT_ALL_TESTS=n > > CONFIG_DEBUG_KERNEL=y > > CONFIG_KASAN=y > > CINFIG_KASAN_GENERIC=y > > CONFIG_KASAN_KUNIT_TEST=y > > > > CONFIG_TRACEPOINTS, which CONFIG_KASAN_TEST relies on since the patch this > > thread is based on, isn't defined for arm64, AFAICT. > > > > If I comment out the dependency on CONFIG_TRACEPOINTS, the tests appear to run, > > but KUnit isn't picking up the KASan output. > > > > If I revert the patch, the above .kunitconfig appears to work fine on arm64 and > > the tests pass. > > > > The above .kunitconfig works as intended on X86, no changes necessary. > > > > Am I missing something? > > Hi Paul, > > I've been successfully running KASAN tests with CONFIG_TRACEPOINTS > enabled on arm64 since this patch landed. Interesting ... > What happens when you try running the tests with .kunitconfig? Does > CONFIG_TRACEPOINTS or CONFIG_KASAN_KUNIT_TEST get disabled during > kernel building? Yes, exactly, that's what's happening. Here's the output kunit.py is giving me. I replaced CONFIG_DEBUG_KERNEL with CONFIG_TRACEPOINTS in my .kunitconfig. Otherwise, it's identical with the one I posted above. ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=arm64 O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_KASAN_KUNIT_TEST=y, CONFIG_TRACEPOINTS=y Does CONFIG_TRACEPOINTS have some dependency I'm not seeing? I couldn't find a reason why it would get disabled, but I could definitely be wrong. > Or tests just don't get executed? > > Thanks! Many thanks, Paul