From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C992C04FFE for ; Mon, 29 Apr 2024 19:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5CCC6B00A1; Mon, 29 Apr 2024 15:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0CEA6B00A3; Mon, 29 Apr 2024 15:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FB826B00A5; Mon, 29 Apr 2024 15:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83EF76B00A1 for ; Mon, 29 Apr 2024 15:46:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E2EBC0289 for ; Mon, 29 Apr 2024 19:46:42 +0000 (UTC) X-FDA: 82063601844.18.F0FE372 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 576B7160005 for ; Mon, 29 Apr 2024 19:46:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sgWt1An2; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714419999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y1WEB6RzCqCuX7Z+BbEKtZP6s+NxySx/uW1PWUvKOFE=; b=rZPy11ENlptGrBbnKCj+428Jevr0nCkVadZRiOlimZk5QIa271Whej2LFFHwH1Z0HjNwnX 2AMnj0o/8tXyqdUJZqsRFueRp0xo/YoiMyQCJ6Q4AGiVJkhGP5baJp3PyEtpkLm0wOWsZt 3QZVx2WjxbrmxYiBrVYlfwf13BBklfI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sgWt1An2; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714419999; a=rsa-sha256; cv=none; b=bbb3EYLVFmgtNMs6ZoA7DTLoCj8DKCXBTTKDfmHfGjHqElLe2vwcwxM6c1tJp37L0hsTrk qcZgPeR+ccVrtcQp+UIm+/FBD6KuPeL7COonXZoeiArDw6jcynd54w5cD1k75QEBvv3buc htLkiVC3F+/SsU9et5SvJDdn3ezT67o= Date: Mon, 29 Apr 2024 12:46:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714419996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y1WEB6RzCqCuX7Z+BbEKtZP6s+NxySx/uW1PWUvKOFE=; b=sgWt1An2hPV1lyHHvEXOIJtMsZZlCWBtR2Rb4kypKeBamwx3dIlZyBHzI1a2c+l826ZZXr Pn205wwwOjaAvRHFCqLFJU9A7zWx27uVJvOrKyVic7BvVQ6SPQrIGME921+LD9smTvsmRP i4iBTSQrlmze93ONreGziI4zAbBKGrg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] memcg: dynamically allocate lruvec_stats Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-3-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: a5w4741aia7iqg1b1exejiunbs6a9y9t X-Rspamd-Queue-Id: 576B7160005 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714419999-303048 X-HE-Meta: U2FsdGVkX18No6uScf58GwLcSsd+AS85PRjckzfXH8rL/e2dG4nTEbcxVGL291DKqBVuW8J7zuicXF5ysikco5kF2a4qupPOoo/Ozzk8v6MdTHsq6drzKdf7zBXHfsXf8n8eJ1Za22EeVE7mE115BQVOb5CGz4FivvBunL1VlHqG8QC0C/NgSgv6qdnHVQNEXZVy5kUcwj1zVocc9T0zCB7mNZlyL7iw3llUQXMj3P6nAd00hw2gUCOZQK9FMJEQYPMGPsyZDFNJKLjNWc3IpnQpJSmagqVeaYk5jLYLmACmcCX0oeYBYpWLHyAhTBqq7Vtq3JWM913G/qiV3JAzYmvxnaCNzXyau4GO8i5GD3EU6HkbYvTAiuTi+Q93wzq/awPY7x3lyxNPUmrJLLazeJudQjcIot+mc5zEp+GZn8wFFGXbzy8QV1XRKzdQ89tnnwVOIYCUiPyOghHJkZwB8ofMegi1vGZQghUNfsm6cElQsCSCZXoNXsGHZ74GgRshDH8v9RFCJVQJDAGgD16tG5D6mmqto7MYoDrv/qRw7a1DBXtdTgbbrrypfDBEHwWaRdRunp+MlKBE6nZwrzu7LBFv3JLN3l/2jx5296BFYdCp/yQkBv5TBJdNFz09HxWbgIE/9VtU/BbS2p/XnauZ1Kb3lYTPjtcw0kyqzy5trSdHx8uW/sblJVGL0AuJhnLmqTIxaaO+ivbm8kb5gvwPuEhRVIo4QU+7Wh3dbf2nIKA/IJMFfcDhoYDSEfC/WZW6reACRpz/4OOKBhhGnx653gTvrTwh+BEn48hyTFvOGoGgcNKcvy6iA8M0eBRPM+hRoVtdSCn+bogReHSZNPieFTZ3+mrQtbcT6ZV6kC6jS2jtsFxQv3916MowKnVhLXWIDBXMIqtU1uVoSaKSljVPMRVfgeVJriZp8r6UCM/hYvNrKo2bCMJT/ymd+cVEGOB815sbUMvHS+KBOSFX7Vo LfLmemWr tCmWxB2ndWIwCLWC2WUF/Mz6TNcJEbgBAPpo4P3fRWEwT3btLPVDpASUXMzb/qDdkMX9FU7JgtFYfLd/U1qkd7pz0wHiFNlZsxR+vgQP2+xj3rwTwPL5irO1cHM4UaJHkDCHR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 08:50:11AM -0700, Roman Gushchin wrote: > On Fri, Apr 26, 2024 at 05:37:28PM -0700, Shakeel Butt wrote: [...] > > +unsigned long lruvec_page_state_local(struct lruvec *lruvec, > > + enum node_stat_item idx) > > +{ > > + struct mem_cgroup_per_node *pn; > > + long x = 0; > > + > > + if (mem_cgroup_disabled()) > > + return node_page_state(lruvec_pgdat(lruvec), idx); > > + > > + pn = container_of(lruvec, struct mem_cgroup_per_node, lruvec); > > + x = READ_ONCE(pn->lruvec_stats->state_local[idx]); > > +#ifdef CONFIG_SMP > > + if (x < 0) > > + x = 0; > > +#endif > > Not directly related to your change, but do we still need it? And if yes, > do we really care about !CONFIG_SMP case enough to justify these #ifdefs? > That's a good question and I think this is still needed. Particularly on large machines with large number of CPUs, we can have a situation where the flusher is flushing the CPU 100 and in parallel some workload allocated a lot of pages on, let's say, CPU 0 and freed on CPU 200. > > + return x; > > +} > > + > > /* Subset of vm_event_item to report for memcg event stats */ > > static const unsigned int memcg_vm_event_stat[] = { > > PGPGIN, > > @@ -5492,18 +5546,25 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > > if (!pn) > > return 1; > > > > + pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats), GFP_KERNEL, > > + node); > > Why not GFP_KERNEL_ACCOUNT? > Previously struct lruvec_stats was part of struct mem_cgroup_per_node and we use GFP_KERNEL to allocate struct mem_cgroup_per_node. I kept the behavior same and if we want to switch to GFP_KERNEL_ACCOUNT, I think it should be a separate patch. Thanks for the review. Shakeel