From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9969C02183 for ; Mon, 13 Jan 2025 16:35:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7753E6B0092; Mon, 13 Jan 2025 11:35:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FE5F6B0095; Mon, 13 Jan 2025 11:35:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 529E96B009B; Mon, 13 Jan 2025 11:35:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A6B06B0092 for ; Mon, 13 Jan 2025 11:35:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D2F2412056A for ; Mon, 13 Jan 2025 16:35:28 +0000 (UTC) X-FDA: 83002979136.22.1383F2B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 134AA100016 for ; Mon, 13 Jan 2025 16:35:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=mWWyKge2; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=se7iWUJw; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736786125; a=rsa-sha256; cv=pass; b=6i7e2alnK7kftxczi17UxZNQzyk6Jdutg+GNwFKtEdxMjLoI7J1shTLdeJqQM1oiATgshB jbjuN5z/qsbGN0H7JCvB7J6gDiHW0dLbPjZRcn1ItonhyLQUUjc9hjrhtLcN1oW2tu8V2X EaJn+Ih9aT2vaFxxUCj2YKhO4XCQtRQ= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=mWWyKge2; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=se7iWUJw; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736786125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WYote8DDBbMQ7FfgrV11++ra+g/TYTV9QmRCS5yKshA=; b=AJJXudRaqw0hz7z21l219fexEA+wf2aGz2SxLE/NkOSPA+713jEYmta2iWSzMMdWHN0nXr cDchoydwTpDijdek7mJMJlw6CF7bd6h9FgWxoGncCBwB7MEh9ckyc9oMzVOmt2NarXwHai GYgdin2W2a+uRwb7NpiqSLA8eNt659k= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DGXv1I014210; Mon, 13 Jan 2025 16:35:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=WYote8DDBbMQ7FfgrV 11++ra+g/TYTV9QmRCS5yKshA=; b=mWWyKge2lEWAiOfO5Ub1Ct/MESMlumYoSn GQCvwGPhxruNLxILf4BJQXRpK9iT2TW0af815PPkMAzywOJSwSvx12apdLPjPdI1 b4eBi7BpI7xlMbCF7uXjz7DqVRtvaVVvC/ZHZbbabTupcjPLMI7b4pXelYHh3CYN YKnANxB1SBYo3/bofxQzwMI705Ju0s3FUkEN3bRX5PG/mBgNzceP7ku6zfB/2RmY sJEV04u59xcP5MQTm9OCILX9CBv6BsRTISUf4itw3SzuGbQQ7qVpENTypD/ySf+R ZH1cz4U1Brgrejvdm6QyQVitR06CdknlRpJyY62KHgK8nYnxOIlw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443gh8uvjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2025 16:35:13 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50DGTwg8020265; Mon, 13 Jan 2025 16:35:12 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 443f3dfajm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2025 16:35:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xl3rYzV/zZSBOs9g7p+wd0mN0/+er1YhIKxrBLiDu2+1g4NFnCwu2DFRJJQ2jHpuNi3V88fDrHgqDQJHa/eq7mWxFIXnrDO6LsKjknmXfZAyYOYwC8UKdz8Jys4S2SkDlVjVFCPtEm8JSE66MfoKmMiUO+YVp8xMtFouzONRIi+yqLey8mXENSe0XHmKxLGzW5lEGiks+YXVMcfSmnj/uBrypGEIDGSHc7wvPtMvrnmZ2kEker/jDT1rOPJ23drhX1gZY7yDnybEkB7hQWuQ/6Mlm09HyNE6jD1VJBHVMFlxULrwAFnMAgG8rEGeLCz0XHXsAhjSWPihNLvFBgLAIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYote8DDBbMQ7FfgrV11++ra+g/TYTV9QmRCS5yKshA=; b=XO1FJXIkb6P5o04M4bJP0wM8B7ONQ6nuaQXoUMMZeo/4wD9vcIgGjk7fPrBilV8vRrec3wJ4vhjkUFwhF30NRFYwVn6+7eMJqnvHQ3agtOpgG+AQVRzjo/mf7Hn/dpoWUW3//1Ol2e2VnOsoUjfMTvbTYYJ7t89DvzZflSyQerMs9T+GNYDXv1Wygmn7D0/xqf72gVK82MTSxKjXQdpbGVHbAd7ATcMULOjBCO+zSGlxxLM+/ltsMBXxjK4PycQ1tr0t7wMYo/1h81izqu9KoDALQVy4lf3up/+2hZS/+Eghb2iFK9o/asfcFRtTeVaxxLpgOfw9NcNxl5rXB08UQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYote8DDBbMQ7FfgrV11++ra+g/TYTV9QmRCS5yKshA=; b=se7iWUJwsX0e+gDW8Nxd71wbUKhk/kVf+IzOJ7ISVe5EK6yXnX1JvKchZL3ojjtWnkdarW1na5xHRYpDy3kZfWiwTkVaIjmphlQht6eZKSvTz/R4SWnRUD76c2WzPuSWcuhxmlgis98pKKUYjpW5t/QKItn9iBV+GmH8sjeD8FU= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by MW4PR10MB5812.namprd10.prod.outlook.com (2603:10b6:303:18e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.17; Mon, 13 Jan 2025 16:35:09 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%6]) with mapi id 15.20.8335.017; Mon, 13 Jan 2025 16:35:09 +0000 Date: Mon, 13 Jan 2025 11:35:04 -0500 From: "Liam R. Howlett" To: Lorenzo Stoakes Cc: Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 13/17] mm/debug: print vm_refcnt state when dumping the vma Message-ID: Mail-Followup-To: "Liam R. Howlett" , Lorenzo Stoakes , Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-14-surenb@google.com> <60b60b02-5dbf-4bb0-8301-0e2f511bbc7f@lucifer.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60b60b02-5dbf-4bb0-8301-0e2f511bbc7f@lucifer.local> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4P288CA0019.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::21) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|MW4PR10MB5812:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fba4768-d5ce-479d-36d3-08dd33f03ec2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iDY1agfmIZOSu1CUCXVVVak5wxRCo6lduk/1I4fJLYBUzoGhU9aPJSwTHXrB?= =?us-ascii?Q?kjY0MC10UJxbhY2f16sKHf6Te7uIk5d/YZdx0RDBVpapeD7bLSSIDuOe3AZv?= =?us-ascii?Q?kTxxLHEDZwYmpbnsefQD2FIc2tbt6SnWtUcUM1MIzmhOTtcdrKyp4QzGsZ+E?= =?us-ascii?Q?7FQNTuvvPSO+VaMxWQowWmCR7w6qX5AEVcI3Btl3m3EpXwLWvpInXQkk6ho3?= =?us-ascii?Q?DnXVHeA9vN5mpm513iPcOPgeulyNXFml7+UVnCQUZQPxQksprpg1JzjQ0wzY?= =?us-ascii?Q?D5ubf3aejc0njECumcIvQ/Jrj2Dl7fbk5omaR3eP7iTqdSFd2Srj5IEwczeE?= =?us-ascii?Q?eac9JEgtB/Tfa1t3kHaJt+x4/JVIhJqfkE6Vv8bJuvFCSXBEmR1kyJ2OxiiL?= =?us-ascii?Q?bSpx15OlsmZl9ee4PenQ/cFGEgsAoa+D6J6Aixgmf8yHrwwusSo7W8XceAX3?= =?us-ascii?Q?LAI5c/t5yjI0MgLpV/vkaJQSLJpgi/j6/7YMTDeq587gqsYGdYz3T5FBeD+y?= =?us-ascii?Q?9kkMno3SJPI3VBMFTmRxZBHcikHPKjqMjGGD3KynaJTRM0y8Uk+9G1OVOxne?= =?us-ascii?Q?hoe5UlOoXH/szPypEkge4yVLN9rl8fcqFe5fwwMULgvjixPlWeARbt1SiAqb?= =?us-ascii?Q?eU/KvuYXPtJCBRbjOrrIuowj0mIYcurOGABxx/eQgitvI6Ep0LYxv5HOtTr9?= =?us-ascii?Q?fg0gttDIq3Wo4Xg5BnCm6SThn4kOR96YYFlvzKkslTTPNEngoD0s8eGWliS3?= =?us-ascii?Q?SXRFkUOTqBAn5wzX38Maxjm4Fxg8ab8mdNt/cxBhryWsuMNmu5uLRuGeN3Uo?= =?us-ascii?Q?vU6ZmayaNFN4hbaVp0Yme6Cn36KCydWECGq4hECqfe1GM7eI6BYnQUd7eMyJ?= =?us-ascii?Q?DSTPm4ar7WvNku6GZmZWqh51jU8MqlnkTtNKYKG7dWKgOlxpGXEa5bzxCUeq?= =?us-ascii?Q?E9IwgI7g/X+bFdO3uyLn2dVjYFcWFWN4wievhhdbHDnxwKpzVct260ConLyK?= =?us-ascii?Q?oa5a9bC6EgVtcnoaNQnpU4e8I09KEm70x3wsH9m4XMI700hZ82jOYcyRE1Rw?= =?us-ascii?Q?LZHJvDvLoKAp0nUytOzS+4V0Q4xSKF+m5v4elCi3f18GfeNaufF2CS5vxCjf?= =?us-ascii?Q?8cA96yiQhhG1bONLJN7s3GbN7PT0yDIjg50qKEYPWrwNu1v+FLN7UocVhnlh?= =?us-ascii?Q?SyQdSibWGiUhS4a3xVOXuMh40DORDQjfnigQHOlN9tQydiV7VattnviGDR0k?= =?us-ascii?Q?q3Qf3qxBusPz+KMpvQeGuliIKJfFNup3PON2+gMDSI5ufh9GKW6mBXzZl8Dy?= =?us-ascii?Q?Mvdzyln+TdYJPCY7dN18qScoI33gRdE1E6tBNfFCuJ42eu/MLMNv5lKz2FHH?= =?us-ascii?Q?ErT+ugMsGcFUL5Pc/eZx8XnDQjuu?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hMzeeJcqxs0xhTOuGoPLxeu0l72rtKIDNYjpcmPJIx8eBkp8upMsTJgKOtxH?= =?us-ascii?Q?gOCVyf2z3RjkX6CrLI8ohpGkLB75Ff08ulkFtCZi9QusJLLKTE8tnfWIk6j8?= =?us-ascii?Q?ntwAcXejZeRVDCXvMpEtuE/cf1RNeZrpeJXWUFP1oH5qfPg9z9B+2XVnj7Mv?= =?us-ascii?Q?lOuyOxCtY6WKBiecvFHz5J68N48X6oFMqLem/LiID4fDsFrULfv8NxmJgayN?= =?us-ascii?Q?jbmDhSEKXumXy9zweydCk/fxMGAOPHeWaIeZtFMoCRoG8xnEMrguLiCsgKQ/?= =?us-ascii?Q?CmYAFDnBWMQZYl72yWYmyq1fGmc6RdesfGQ0HQ1Uq9HLSbGdb84jl0mj8UUP?= =?us-ascii?Q?HjZMJsxobKrgNYOBZ166wc+WWWaiU5vJD8zyKLRf1ZspqyvQ2BcPuK63V6jd?= =?us-ascii?Q?oj5LNcnlRgksb+geaef7PUzJCG88Ua6ZEqogJtI3gztkXzPy3BWJsS0YFpFd?= =?us-ascii?Q?6nIDPrPTMvmfbBAg6VN14n0vfNzGMBRlgix+qn3MpnnkV/Nsnnwq2HjqNDiO?= =?us-ascii?Q?cDmipee/vaZ4S6QizyZoISXaIflais5fzpxzgiZEdk9oecMBjhQL0JKgnomH?= =?us-ascii?Q?CYeXP+7zWjjt5LgcRBo0GFa2U6HbTyaHKadX0uv1QDOs4Fv69s5NyqO0LLKK?= =?us-ascii?Q?/6uUOi79BXmsWAiAnqYfmHk+CT7mLLKDKUSb+F/rb7/plusOvMUKze0e0w9W?= =?us-ascii?Q?ivLUQ78G/UDUOpX4gQiemawQWrbli2opywEY9Kl7k9VGKuvuOmXE7+cLnJNX?= =?us-ascii?Q?BFpxu8oYoradPdiq+lZe58gwjN4OZ9BrpGn3Qgpk6IXPz++BjQ7X5bTkWRid?= =?us-ascii?Q?KCfZCQDE74yON1F6H9dZuLyTSBNSYrxbEiUZAPF1vPpPD3pxXK7LMTYYl/qL?= =?us-ascii?Q?r/lQrVq4UolusXJLGKhpyL8rhAng8Hv4VgVH24hOccv40XimlpuqhI4dav24?= =?us-ascii?Q?tGGuvZMvg/FPshsEVAIWR6bEOKHldFL9NJb5lCNKUJweSs86IEdgs4roeYxp?= =?us-ascii?Q?deRHZunmCs5v6qDCkRXEReoAhTnATx+uVlC6ayw2BpgeIU5RQv7P+y8cHBwa?= =?us-ascii?Q?OhOtsWzh9mU/FvKt0mh1UbXtlcqRayHRwv47djaImNL+7g+r0MZDkyfxEzO9?= =?us-ascii?Q?zDQYcRQaOC7SJUCoQO0TjRCxeJujYmYMpXxAw9IL2RBzrgN1M41x+PuUogqY?= =?us-ascii?Q?zVRv7wL0gjtNqVAksIVm0/3p6bX35tK8+0QJ6JNmGduJ444r2ZPRrkJEHQaZ?= =?us-ascii?Q?0J/aWz/c70gcuWB6I1om41wHIElfDGsv3Hk6A7Os6MoGmsFGE+JfwJ++An7e?= =?us-ascii?Q?zTy4hEee8b4+CTThETOEsFFhP3E3rb5hXvLNcnYlU4OVopsGgq3oL5VDcBdF?= =?us-ascii?Q?qNsNWENpB4clGZ4IX2DbuYXKAfVZC57i7uNyQzO8pwt00v16Dkhpyeaoz7YK?= =?us-ascii?Q?RAtwEViH0Mg1GTgBPhEnJKjWXra2mZaSjJrZp7LjRMyUJ490jzPbU5moh12d?= =?us-ascii?Q?qu0tjyo1OCGSkQ0/C18/e6vFdZCsXo0KPnJ15grXx/4nfPn0MYz59E0XUuHf?= =?us-ascii?Q?RzMdPEVFWySdONJpUQeftS+Hts8Z00FSvWrlbLGb?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 89ZpjnyAmaUXXJaF2/SNnO+sJUzrBDkrNqb5UFfl7Vk8sWHONleJ2MNas+FOmDAl3o14bFVRrvjdGYT2QQPaHnMIHj8IVqYXiviCeT4QnWYxQUtScS0pFC3kOB/BAJjWOjHpNfCIzcBK2nOXYPOEcm9WcXNDuBYm7JO/nqBALnJdGHYKSiFvJcT0D/ef2v6/qSyaalkg2hTQPf0BzOYtvbc/2Cgbe72SKpcWaXqF3fNz+RbXdn73/mlLA7Xsfvf5sMJqrwYpPHc924SfKmPr6hTJw9I0XhvM1ptC2yp11wvIkIHxK/nHM+k4IN0jV/DBvI1HB+E3rKnCdPyuZ1rLVtkre2hBHhrJNQ3VLLNq8Alz7E1CtkLBTIt/LCH4NnVgRHjaaCocmBdGpBZGX0kqG8Y0NToKI1oNJaqfc2IY0DkI37aFGHwMcFVw+zkWjh4raILreSb8Xcpmh2bA/nSLavXPa/mQb6bbmJNwub613Wc2m9OSez6UJp28i2GHDRL1BFzKUxozecNrNrJcCTNBXoIIBOIG0jD8gNYEsB14eQ4eQ3eklC2CQSDI7Jz9Vvj4eHs7jBYh7eTDRYtLDtlQeAmlWsflTZbfbHHhF+StfDk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fba4768-d5ce-479d-36d3-08dd33f03ec2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 16:35:09.6330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ul9kDMuQ2FveAoWXYNVI+lY09Q33Dl+rIdy+iaiCJOLdTrnywvJyJ/DcAnI98AYpsN6j3hBzh2bCm11gSINm8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5812 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-13_06,2025-01-13_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501130135 X-Proofpoint-GUID: MY8dU7PMwbqQSjlaE-bCJ-m1nW2l1shc X-Proofpoint-ORIG-GUID: MY8dU7PMwbqQSjlaE-bCJ-m1nW2l1shc X-Stat-Signature: w3h3nhopfih8an93ydnm3wun7wezf3co X-Rspam-User: X-Rspamd-Queue-Id: 134AA100016 X-Rspamd-Server: rspam08 X-HE-Tag: 1736786124-332381 X-HE-Meta: U2FsdGVkX1+BzvNZldagRsvqX5i8PbL+5JX2NesRL2ZH6aKLwU+DN/gnWcdHz7TEZCYJh5TugTwYkUEWknAi/JUbSb1F9GScvbrDr9HZ5DMZzciywSzKVLdXr8XFR3WMc/W3ZeqSf3NaahqApmGEWJ6wAhPMPWadEvE+uEBRF4epsPAJRo8B7f6zY734xlFkaZa4gIiT/wMh8WLEJ/LZIkyJ6DW/IaVnd+7h9476ojTcl1Sq8HyDT/n16wjASo+xTn946yimOCXnz2n3AeBJ/RFiHuySIQnywUxr2Xq9N7Uz1za1lYzV49QKxlmnHaAsy9LaClpWybIwyNBe5eRpOMPvRU7KNOTvv40Z10eoqI4QC4NXVDXlnGGm40kMBDk6UIV0qpayc/saH4cA10IL4iC9IA6sltOphvaYiw68tr55Njs8WAgnNh9Qqz63uZxSSqZ1PwRRlfPdTHf8siF7hYXJ0LFM6tlPYLIk2x9RnLjaIZRRHKCPfen+Es8fY5Tq4YE1wJzfpxigNUQXbhXPiuhgi+Qyq/HLh7Ib3p6N//DOrwGd5tfmXSjnHDtGzDkZhPX3/5qLuAa6gUAuHGaL7HmBtN1ay8t3G4H8+kU4/qiQgS52mAsd8+fgGA07T5eSFdhffo1wTLbLYqpxxEnJLXTscnxVlz0A44Rcqf17ipBo1LvjSTMhcov+fep5xQO+3p89enzSYdwroCbIQB4SZ57sadmpb0rmnae+r4cx4GGOo8S5XsLjOYwhs86/fdLPRwfa2AjpcNkwhDQFJdIQOf0TpBpPD4zPjSWepf79NJ7GvlsbW0LEILoBzIZo0GuCU3YAfEpvaWlERT5UFrgvQo3u97UON98SaE4nP0c1T+G42s9y1npOCsjj8Nvz4QvoAdCDYJigTETxq/YE+GTXF2eKyMTx/ByEUeLEy99kYUdKzJZS24dH2Nu3aS0K5vDQGLGAjBUZRefzRELxe15 TFBF3B5d R4irN2L83X/7WdDp07aUjt+DsuwXM3FSq3NlQA+nanPf+Ibr9YHVl0Ubmvlmqyg/gmzvFd2VOjjMDzZbrkYE6/bZtXHUqmiQc6A1Pva/3sslhc+o+fO0OIF0F4uBLqaCsvA9N5tHOwgGWi9pyMeui1F/pUI8mZbL+CEJhTNhWkXNV00/vDu9LNSa1IvTIdXz1U7fArxTVg21jgbajK/hB7OPg9MwbkQJclFcXsbxtwLnlIRGpntoBl3wFGnrLGMwIybTjNgQUF5UhMRYfZacOjvTZEhT7nVmMPbi7mcSYkZrpRtZn5doKfJL2mgrQK8VQIV0J58ivGQmCYZHNNQjUHHDsgD3ZCSIDRGoJFes/TgyJjX4HYrHF+8AQTWV4ElLr4MhmVVptq40MMuqajyOW+3VoO8vK8zH+3NmnVWqWK78ARw//uPGHJXZA/unH/nDcHlqAGexRuCsbPWD9LlpoBl+S3kC5IGBkurV9oDq35fjwXxIMhSgcne/7TNI3BV/ZZBhDq8vDS8PKLpAWPCRH1M3wmcjEarAG3aWCyLgtrxJXEd5YXEl6xn7u/daxYHTLQMhL9LeTmZGZR266fGIe+f4Rz9MjglP47ckcFsKPdPaSes0LPF4UgMkmKDBKMItxEz+UHS5r7L380bPOVmj/a06YXixMqAFUhmWocrxfdd5rA2xsK4BRKLssfAOoUNECEPLJKhgnJrhs+5BYpCNjCFgAUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lorenzo Stoakes [250113 11:21]: > On Fri, Jan 10, 2025 at 08:26:00PM -0800, Suren Baghdasaryan wrote: > > vm_refcnt encodes a number of useful states: > > - whether vma is attached or detached > > - the number of current vma readers > > - presence of a vma writer > > Let's include it in the vma dump. > > > > Signed-off-by: Suren Baghdasaryan > > Acked-by: Vlastimil Babka > > --- > > mm/debug.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/mm/debug.c b/mm/debug.c > > index 8d2acf432385..325d7bf22038 100644 > > --- a/mm/debug.c > > +++ b/mm/debug.c > > @@ -178,6 +178,17 @@ EXPORT_SYMBOL(dump_page); > > > > void dump_vma(const struct vm_area_struct *vma) > > { > > +#ifdef CONFIG_PER_VMA_LOCK > > + pr_emerg("vma %px start %px end %px mm %px\n" > > + "prot %lx anon_vma %px vm_ops %px\n" > > + "pgoff %lx file %px private_data %px\n" > > + "flags: %#lx(%pGv) refcnt %x\n", > > + vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->vm_mm, > > + (unsigned long)pgprot_val(vma->vm_page_prot), > > + vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > + vma->vm_file, vma->vm_private_data, > > + vma->vm_flags, &vma->vm_flags, refcount_read(&vma->vm_refcnt)); > > +#else > > pr_emerg("vma %px start %px end %px mm %px\n" > > "prot %lx anon_vma %px vm_ops %px\n" > > "pgoff %lx file %px private_data %px\n" > > @@ -187,6 +198,7 @@ void dump_vma(const struct vm_area_struct *vma) > > vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > vma->vm_file, vma->vm_private_data, > > vma->vm_flags, &vma->vm_flags); > > +#endif > > } > > This is pretty horribly duplicative and not in line with how this kind of > thing is done in the rest of the file. You're just adding one entry, so why > not: > > void dump_vma(const struct vm_area_struct *vma) > { > pr_emerg("vma %px start %px end %px mm %px\n" > "prot %lx anon_vma %px vm_ops %px\n" > "pgoff %lx file %px private_data %px\n" > #ifdef CONFIG_PER_VMA_LOCK > "refcnt %x\n" > #endif > "flags: %#lx(%pGv)\n", > vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->vm_mm, > (unsigned long)pgprot_val(vma->vm_page_prot), > vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > vma->vm_file, vma->vm_private_data, > vma->vm_flags, > #ifdef CONFIG_PER_VMA_LOCK > refcount_read(&vma->vm_refcnt), > #endif > &vma->vm_flags); > } right, I had an issue with this as well. Another option would be: pr_emerg("vma %px start %px end %px mm %px\n" "prot %lx anon_vma %px vm_ops %px\n" "pgoff %lx file %px private_data %px\n", ); dump_vma_refcnt(); pr_emerg("flags:...", vma_vm_flags); Then dump_vma_refcnt() either dumps the refcnt or does nothing, depending on the config option. Either way is good with me. Lorenzo's suggestion is in line with the file and it's clear as to why the refcnt might be missing, but I don't really see this being an issue in practice. Thanks, Liam