From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCD1CD68EE for ; Tue, 10 Oct 2023 05:53:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12DD78D009F; Tue, 10 Oct 2023 01:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DDC28D006D; Tue, 10 Oct 2023 01:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC0F58D009F; Tue, 10 Oct 2023 01:53:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DCD4D8D006D for ; Tue, 10 Oct 2023 01:53:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE4EA1CA437 for ; Tue, 10 Oct 2023 05:53:37 +0000 (UTC) X-FDA: 81328484874.01.053528C Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf20.hostedemail.com (Postfix) with ESMTP id 39DB21C0003 for ; Tue, 10 Oct 2023 05:53:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DR85yq9x; spf=pass (imf20.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696917214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1W+V1vg5pMU25iuDrrMqv3k5D8NkynSZ4HWjw7cgclM=; b=iauGfWPan9gwB6e4v3mNsZ7T7tf1xTkdwPOnI578/uuzLuWulotWM91aOrc3WrQwIoBYvn tlnlxzt6i/SNmoPs991X5fjwnBy16Jkln8qyXIIvRCnoXtH7bkVs0eCeHm/qKCCWS2O3AJ YZ2eknJMT0+rEPSJYQov5nN7/j/1rOQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1696917214; a=rsa-sha256; cv=fail; b=ykFh9DrMu+EOMSz1h6P3SVmcedzl2c1RGQgCPK/37arYtcDtSREmzOVy8FiK9OgOwnDgFL krYeRRw/6YAwTX13xVZQ481VsibCyo8jBPNWTFS7fiIfc36G7a6ZljC+74YQUHLv1qr7Ir x2xHes3OCEKZnaReJjcRJSyRTAWLgJ0= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DR85yq9x; spf=pass (imf20.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696917213; x=1728453213; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=b5cWRD174cmcvkgF/QqgcL/E49AdrklTb9R1ZdhSlYk=; b=DR85yq9xuASAbinnlT4yBNZYihYMWaOoiETdJOA7hFzXknbpffrKU9eB tYixPabLWJWoRDPzGBWSs/fCt1bvDfRMmPXvJctf3tgKe1W/h0p/dXiI/ IjR3vIwEFGFvaHX8RRB2byoubbDAIzKKXmbgruyhuQVQQ5NRbf2iZN7Eh XzDvFUhufH2uvXjdxcUGau6CJe63rq0/zOg1M07NEXgsj2HAqOIRb/Put kjR5PYsty/eAvfSqpZthspapJrmzaMRxIv6X1ATXYTKLCcSbGuFAdus1p 297rmQ0loOjZ565Y0UwGW7hSGl/yT8xINTGjeNmTauP0Omz6aImxcp5uA w==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="381574776" X-IronPort-AV: E=Sophos;i="6.03,211,1694761200"; d="scan'208";a="381574776" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 22:53:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="843993154" X-IronPort-AV: E=Sophos;i="6.03,211,1694761200"; d="scan'208";a="843993154" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Oct 2023 22:53:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 9 Oct 2023 22:53:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 9 Oct 2023 22:53:30 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 9 Oct 2023 22:53:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+hwFhMkPELWR3Ekry6x2FUjpHCXD8e5RlJ8hnt8a8RwuHS/gHgtsrFbay/l3mZRzn8VwzBAlIQKjO/qcwpXXZHUN+u8HlHVBL+YVxoLoaXujGOtU2WDNOg781Pbn9yhAlXW3IHLn5lOaoMNzAhoUPdkUC6dAPezfOX636AlcN3PsalfVe7USCOvGKtVDEv/GAPDv8zBm8jfO+i3VxjC60FPSwn8ZykFAGeW5xARmjPSoySyBY8LvYj9V5s4WHS/sINFGojLg4qcgz1nvI8kKKSAdwfZHyNI5TV5XEbhoMv3Yf7zC+mlUJbr8qtCwsgJoC9uD0t9V1zzLqlTt6uG1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oRMwN8bAqRioYmh+oBorn1dh5tpz8E/r5ocxm18MzdU=; b=eyeI+Cl2AsFVa9WGQ7sIakDLLMKklwhLctfK9gM2IS8u7ZFDs3tGrYMU836RyylWgk8RttwltKaP3SDIu/vF37HwcgGNyVEJkO2nXPLOiK1hn96pjoFLY2hlvM+KxHULbxjVmvZbDdXWbj3QWicFw8py4ZsCa1NFZcqHe+MN96COMKcnJKi9rFNossfPaF3nXIB6Wl6KNyCBzYOBEQGcL3eW1WTWsnsY5nd4KLsaDU6aSGZ2y4MWfybqbxF7cYPdP0GFfavBlJhnWDLu5MbWUjHfgMh4xx0///iCQYvdUUkOZtbUEx71sbdETZOPpO4r+7+8rwm+I/VC9CvPIaCPBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) by SN7PR11MB7065.namprd11.prod.outlook.com (2603:10b6:806:298::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36; Tue, 10 Oct 2023 05:53:27 +0000 Received: from MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::fd1b:a3b7:11a6:4bc3]) by MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::fd1b:a3b7:11a6:4bc3%6]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 05:53:27 +0000 Date: Tue, 10 Oct 2023 07:53:18 +0200 From: Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= To: Shuah Khan CC: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 0/8] Add printf attribute to kselftest functions Message-ID: References: Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: FR4P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::6) To MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6231:EE_|SN7PR11MB7065:EE_ X-MS-Office365-Filtering-Correlation-Id: cda01329-381f-4068-d782-08dbc9553945 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qMiTGLMDEXh3SzzAfCLjw8QlUICZGbR0l5v6bVNreC8CixGsr1hxZ00l8cWov7gjoQx+Zu31TBLZrvkI95hkDygdhFzAMRwceIjiy/wKSxH2q3Pcu13Vi5ZV4RShvALz9OuIWi+xoxL5G6Zxf3hxENM/8WYeGodKfbHWl+ZQxpSknUdHusZo/oeWVJL8OkBoo6mMzpeA1eztYRWY8khNTS1qIEn4oXwUyPpfd2fSLFfpkdx1VuMJotXZB3UnrHt4LAU5Fcuf+F0Vvgbumu/NLl105db+C8pE4SSaHGiSwO1sUUQuQYqw+E/BhD3zZc1jokB8UvArWfhSKahCQ3TotAZrGUcSKAdUu9dmkWjnOe9jLRAvlQkk03tLP8SJKmLJhRCory78NIJTuTwT/NMM8UFk2o+hbzp2nV1Cg4+6X38vd8yCfPoO3GhXYI7vwPIQswfJEMZxW9M1xJrg9/kiFhzjnY0IfOMRAliJTmco2VeyeaE4dPvD2finEhOWjkTBBApRnB8JJgXxbXB0Gdxt8l6Y1APqihrMW3Tfjnq9Qs/wiZmC/Y49gpIb6vHnHMxA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6231.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(396003)(136003)(39860400002)(376002)(366004)(346002)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(26005)(66556008)(6916009)(66476007)(7416002)(2906002)(66946007)(33716001)(66574015)(83380400001)(86362001)(5660300002)(53546011)(6506007)(9686003)(478600001)(6486002)(6666004)(4326008)(8676002)(8936002)(316002)(41300700001)(6512007)(82960400001)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?VAY4BTHnc3z7rUb3Usm2I1PbYLpBJ8C5RKO1TsFEGFfy+CXvjNiCRzvPOI?= =?iso-8859-1?Q?4Kt8yo3m4+4Dl2p23WJ0xOLdRfgqOzW1nlezqbd//2A7XdijewuP4NrVMK?= =?iso-8859-1?Q?EbQhYX7XK55/bYPau3AOBEws05BbknCnNXamOiIykYYEMqx67JQShxFxbG?= =?iso-8859-1?Q?dWSv7rPx1HTBNSJ9O3RiXkZY968K32S3pA0evHG4MRXN+tIeUZMmdubNvR?= =?iso-8859-1?Q?l9rlQpI02VQze4uvhJu5WGTrttG9UPMLi/pN7YX58S1hRNJ3clQ7nqPxxv?= =?iso-8859-1?Q?gB3CeW+iHmekox2ziJojq7NqxjxCxMjPNXH7r0FEaIeWD4awmoj9Kb3MHK?= =?iso-8859-1?Q?iC0gVrxCWmXe5jS4Oz4rsXAaQoxaxi+BaCBKLQGb5KzhXDCwm36jU0p4Yc?= =?iso-8859-1?Q?765lChMdl16TYpPmy7s8CNedyn5YGxbMNRzIpbySuGvrdey1Yi9TwsjQ5m?= =?iso-8859-1?Q?HNSbD6APHZXllmHufN6EHid0Aeyd08o3jrzGjzL7rn8n4D1vHZh8yvWtCY?= =?iso-8859-1?Q?M5J46jecBDCZsFcrHxmCTDtNkt5kRsjqxqeJRZ9infWj0gJdSdEPpT0WXq?= =?iso-8859-1?Q?cgZijQjG+xO92spTWzI1l4Wb8+ssnRHCjHeRhTD5CxvklzyfE+8naV2grJ?= =?iso-8859-1?Q?M4+uGEMKFMEi6jDUo7a7djTesYxFPmQkNFknBVQxlf3pgHESU4UOgkCp1t?= =?iso-8859-1?Q?NdwsQkeTQiUSAFJMvhYkhsn3W4Is0WmlLLriWs2LIpG2ydQPhsMicvb0qq?= =?iso-8859-1?Q?IV+NPYIK//1Bd6f/Qou6Ad9HhL6vTN+9G5gVJBT31Sukw0yqldlFUVzH63?= =?iso-8859-1?Q?vYqd5/fkD2eHJ/O9lgCaKbPGqVR5q7OoQixuRmZT/9wMRv2zox9ailFLJ9?= =?iso-8859-1?Q?NXEu8QnCU7pA9iOY4vjeYo7BaxnNpNnfTlGzm0UXbYpBX09HZ1WTtSUAM8?= =?iso-8859-1?Q?igAQk/ZnRpmRAmQUS0f9uSGjRZgMeCuWrrSot2QTbsQrZZ0QdLThCTcddm?= =?iso-8859-1?Q?NtezLU0ETx+lV6IkqGQzA52b18tXsvwlajnmMtg4OtbQMUHXtnXqgcmLGt?= =?iso-8859-1?Q?3k4ptD4dA88U0PCxoQRnVfFPp8gXN7Onzeki9cS8B9/X8UXla/4YE7eL+3?= =?iso-8859-1?Q?zbIAXqYpKvib1KgqZWLMJUhT+OwWVHjKg01CQG0L77I+c991zwWH0+K3nK?= =?iso-8859-1?Q?E1z8VCFYgBTCFeDJ1iuFu1zKZAxJP8Qszw21iPVzIB4IxTNXkROoR+x0k1?= =?iso-8859-1?Q?MozQWBLVarNxW+jxAKWvUT8cdxKnl7NQ6QYM20px8t9Yw5rya4rkjuvktC?= =?iso-8859-1?Q?uXvmckf3pEBIc2lB4bhyoJ8ImHijK2VP6y7LKng2nPL5QNbdV4+ZHKaIC4?= =?iso-8859-1?Q?KgqCKKbZ1Dy3vojWEBF51M3WG72RSOkCDWk/P+p6Oux0R8TPjxtGLl7sv4?= =?iso-8859-1?Q?zkaRukIN6XiMIqSXidFt2O30WdbM/GzvajblRUHvSa+IK6VAFmdE+kiqAd?= =?iso-8859-1?Q?HsUp9maEtCfAbA1XoeeivZaPH/STkZ/7jyBll20vNnNf5wvqSyHdfApERi?= =?iso-8859-1?Q?1oJm0R0zev9gKDW9ATNzOfHkCgDTV64lYbCdgUQerv0U4Tq4ARf8T9TEbB?= =?iso-8859-1?Q?/ut/6DiJZTyyH92ikE96SDsCoF4Ob6Zy0DBQJTJy2I4MMpFQycFOUyRZt6?= =?iso-8859-1?Q?YVfiXTljEjxyWNnoumY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cda01329-381f-4068-d782-08dbc9553945 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 05:53:27.5409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CXuSaiYBn2gT08ypa9CYPEP0PwdJbcOw/rhyi8W86kjA0rPoB6VwAvyAC7AFYjCy5vkzuIGiUZ2fULnjbeKw0zgdZ67VsIW8KyDVaKfKJvo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7065 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 39DB21C0003 X-Rspam-User: X-Stat-Signature: tg5qtnc1zwcuxawg1b9hdd9o4661h88e X-Rspamd-Server: rspam03 X-HE-Tag: 1696917212-732571 X-HE-Meta: U2FsdGVkX19gspvYhhgzH7Zyk0ozU7YwaqzWX7Na10ZfSDzBd/z4Zdnr7GNNXF0mqFm/ntJjoaitOZn+NHGTavzXeBaZrzFaoyTP63pSjrE499PZZdfX4ptwrV9QLOiytkxkPV6BhJAROQ+uV2EmpSiaIBAAPdgcUPBnJroAJ3zFhxnNQQ8Xu7QlC+5Juh92tNswsZW7YuPw3nCnLJI1sDnAJfgyKPtiZuhbd2XP6a+8y6am+TrJxFG2ZGnmW38d2CLlF4YTQd7Zu0JCTGBBmYzKJdW9qWSVKM0FGbNb7w1MxeNpI2iKfdaJJM7xVAXiez+bVf89hgsjzIRGWdmw1AWR7ROgYnzHgsU7EcrM3b8bObNahn7GfaYSd1gvpAQIxYFV+ARyjPCMVdc9wfDV9/c5BLqFzfH3F6lNvCDxiJPeXUr0JsdE3IibjFYf7fYwWSHjoKoLmyP7Dva4tWMNzyIQyKWiRFzE24jMXUVTHkqzEw8QEEAiuid6o0Gdl4VK7ZiPjPS9/uRPxqRzA6Vac4VPeD5zmpeMj5EsGWkxB9thzFOBq8g5LafWY8LWcdMhChZ9KWFaxqk3s05Qm+bl+BnkV1uU7svVG+03InxBDRu2KCAQRqp+AkznmywwV9LvmIJepS66UGP6/7P9gBnmn0erKEsiXEzRw5h0gh8wmDnrpTCP8OKfbOjln8Z/4esiMHu+gY8ojW925t3x6PfJtewqjDDCO5w0wDVbJY+GxXh9sahZdvpo85C+o9j1IOiSXoTI9lPWwvy7s3OiwKNYY5QlpqH7QasVYAcVrFSyNniaO3s5wLrTtsImnlUcOAAHhw+urJqS33ZFSOikX1cbMsSU8SiSztw6C/mstuLcJvbs59gTQOCd6tcFO1BO5xHqwswg0vhd/y0CXoNdbkwHkc8fnaRZPqoEXG6soSYECu9GTKJc2YgNrJAGwagpSG8CZfh/N3po67wfLpOAavs sGPV0Elr pfO722BgZMf4g0705lrl96KStIpv+Yvg5O+wL77DD5ymjmbXhT/mdW35x2ecWjJMQFb+yGnMuPUIwGSQ5rp8LIjtoSWUb8uu2txg2Jpg8GvbWaUIyZNhqJSP+sojvVk3ztcxmkt4A+MxB6YrO/L2PgdaQd+Y16l0o7v+S6Lvh45mQs1TSYEZpUY0TLh/ola3JVRMDtT0a23B6tH4vN/wYUh2enm8KACOoxvoOM7tlKlZqkEtKobdHQBoBSj83TQw4n0GELC+OKfneU/v/Tke6S1xwXOpokC56ru0i+ZU1t6F0nf4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-10-09 at 11:28:30 -0600, Shuah Khan wrote: >On 10/9/23 04:28, Maciej Wieczor-Retman wrote: >> Kselftest.h declares many variadic functions that can print some >> formatted message while also executing selftest logic. These >> declarations don't have any compiler mechanism to verify if passed >> arguments are valid in comparison with format specifiers used in >> printf() calls. >> >> Attribute addition can make debugging easier, the code more consistent >> and prevent mismatched or missing variables. >> >> Add a __printf() macro that validates types of variables passed to the >> format string. The macro is similarly used in other tools in the kernel. >> >> Add __printf() attributes to function definitions inside kselftest.h that >> use printing. >> >> Adding the __printf() macro exposes some mismatches in format strings >> across different selftests. >> >> Fix the mismatched format specifiers in multiple tests. >> >> Series is based on kselftests next branch. > >How did you find these problems? I don't see any information >how these problems are found in the commit logs. > >thanks, >-- Shuah I wrote the first patch that adds the check to functions with format specifiers and I compiled all selftests. Then I just corrected any warnings that were found by the __printf attribute. Should I mention the methodology in the cover letter? -- Kind regards Maciej Wieczór-Retman