From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A5DCE79A7 for ; Mon, 25 Sep 2023 23:38:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB5796B00B4; Mon, 25 Sep 2023 19:38:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B15C36B00BA; Mon, 25 Sep 2023 19:38:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9697D6B00BB; Mon, 25 Sep 2023 19:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7DCBD6B00B4 for ; Mon, 25 Sep 2023 19:38:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 54BCC1CA978 for ; Mon, 25 Sep 2023 23:38:05 +0000 (UTC) X-FDA: 81276735330.22.D36E85D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id A676BC000B for ; Mon, 25 Sep 2023 23:38:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dVsIQtyn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695685083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/WMKQ9K2isibLJpCrbAzrEcthkLg+ntL5exlBwglufU=; b=33hVHqzlQjUxKP029Q6yIj8o3/IgLik82G0vGWmN501gv/tbNqbJnI2nxAGvi2JN/6p7rM VpPF5Bg1oNKGYlotFUVG8kmt2+xz0kTS7zLfOxbCtVMJgu8vvVL0x2FTLKmF1QValaZijw DPdbgJMOWcNJ0yQVzjmGhiAhN5DseDY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dVsIQtyn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695685083; a=rsa-sha256; cv=none; b=msfRUeIyl30brlSslxWY0BbwrelAI422aAgWG/b8HvF30imkwj6jMR5n/GV40LaWxIc290 j3cmIa3lTAanDHz/sj12W9L63QCx74joQJpPSlcO2oNLg/nXuO9UjC1yc1mTDVGHqgyiUL pwcEjGox+OQ8GWhr5kd9S408ezbPppU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C885F611B8; Mon, 25 Sep 2023 23:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51D9BC433C8; Mon, 25 Sep 2023 23:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695685082; bh=O205pMaIZFX+IR8T15rQWZacKabki5WR2NjlY+l6r5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dVsIQtynqPYGfJ74Hj5ksmkMzU1K/gDiRxQ5DLIVvR4CE2yXDwSgOFm7UssP8H8x5 +G9UNuUwrHhhCUvBTxIO7CVsFcT0hCgsw5v0FYaJQ9gNyq8wBBXYi18I6wRRTKMqsz XB+rAEDdQbMOeHdzdqXv/E+IiJglWMsBwNKhO5t0wt4jNa54f+n6HyxM+8qvDGrbpw 6OXtC7druCMKsXLTanJyAqdCmyUgpUvjVcXIyx1UuRfh2h3G8ptlj8OJTZiMvKxdbT JOagx6UCY70sA+E9GyP+V4KQj5XhABibYbcbX5kapl1XpOnxxka7n5kLXGJJwOFyMu 1GgrwW8/oXERg== Date: Tue, 26 Sep 2023 01:37:58 +0200 From: Alejandro Colomar To: Axel Rasmussen Cc: Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes Message-ID: References: <20230919190206.388896-1-axelrasmussen@google.com> <20230919190206.388896-5-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7vgy4blmhwfscbm4" Content-Disposition: inline In-Reply-To: <20230919190206.388896-5-axelrasmussen@google.com> X-Rspam-User: X-Stat-Signature: 9tmyw1xrnynhqmtd7ckrugm6pwjo36xw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A676BC000B X-HE-Tag: 1695685083-858385 X-HE-Meta: U2FsdGVkX19QacxgnQFlfP4fvye+XzHskMZHLV2WZXHBVTsByp1+rZrp2AxfbfPRV3MKAhuPCx58BsS0TNC/KDHQUbAIA9Z8B+7SOUwh3qF0ONS1fs+yzTNaN6VSbQ9f6OJ55jt8Ddbyc+P9DFto+gXAp4eMvjRTRIx2IuREepdAu0PUkAL6MhOwlNi5j9ihwJQCsGFQfP7qfu72ZfC5aPqZOQKzjyZcPy6U2iw1fpkhkIoZSVsIDqTa3GOne1mEilHmvBR/vXigyGoPIWsq8BuTCirDOzSLPode31QuViuSvqp+pfUpdPyrxsd5K/XA42lQASn5oO77dIQUc1IOGq1EB4IaHRnCoSHKS+mbFV0S3Yg0ykBPAdfJqUM2waqVXDXg/4jwSMRnIdh43J30D5oaOUZX+CM/V6fj7XiBlsUkGFuVUUpiVzVDQEOMW+vwLoOIv4AxFjTFMysExzRSarJ/gNHUeWEmDx/FiChsgGCsp8yIeNOCz8l+iFcALnxibiPH8Xz3HBhvfUmhqb5AUcpT3A4k1A2UT8tQ4pUPRteecwrVMiybTQYylEN9SZvIiX/KykqejYEX+c5DsriAFLgLQWihnQKlvwJyTtMgWMFPblar5KK19p/vVWdRiiDlXILcky65DWU1jWQEjAEtoP7t9HdVM3DR+yr38A+uKcXf0EevjB5Yu+kMQmwTUFOFa+AxbylEkmrsaVh71uzK7QDR/ORvZzoVGaUR3NPJjw0GRWM+cdvnesevd9zYHJRMAgNozQksXLsKuD+qm129hQJtJlwtwu4aKN6KjBeRFYPpaOiBD2aK8/HSVXjKQOGW9+SFbyk7Bi84W7FqrSl094ld2IVjvwiN9/6laWP3iD0Rjj2H4sPWCZAjb2BiSpVl76ChVp5gi8QYrSRJDQyeGjdJCCAr9rMrCJWH9BszAmszrK/Rtfd4skOnDBqKc1sjH7dToQ7r7sTBijsapit 7qJ9ITlS Rd8ITbR9Lsm3bt655pUlZi7Z+O06kIRU9JgR+1+ZYEbO0J+CtJ3sk+mTd5MaT+vR5aG8wEsmU4m2kKoKE9gBazlOAZig+uK/YLcLclwlo78rX/n6rgZCt0YxOaO+OQtRnaD3FcRaBYDqHE7BJ9oKdyD6d0Ckcugy5LhXJnsWNpTx8zL6lfJ6hfCqcAv5DkNpvIIHW6DwCL3gx/ZEfI+Z/UBZR3IBMAgrSzLYQWP3kA4IWMGzqrhOqWcCrq4MRijsBM2EDWSTT7TP5grSm5HQ/ksqPBOQAGO1xkNkjCjOw2AtDhL8GzTxcE5AyiBuE2um769nGOH9zYv54hGcSrN1Uk1DBMJx3kyQOWjYLN/z8L6RZTxE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --7vgy4blmhwfscbm4 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes MIME-Version: 1.0 On Tue, Sep 19, 2023 at 12:02:00PM -0700, Axel Rasmussen wrote: > - Fix missing paragraph tag. The lack of this tag yielded no blank line > in the rendere dpage, which is inconsistent with style elsewhere. >=20 > - The description of UFFDIO_WRITEPROTECT was a sentence fragment; the > last half of the sentence was left out by mistake. Add it in to fix > the issue. >=20 > - move UFFDIO_WRITEPROTECT 'since' to its own line All other ioctls > note the kernel version introduced on a separate line from the ioctl > name. Update UFFDIO_WRITEPROTECT to match the existing style. >=20 > Signed-off-by: Axel Rasmussen > --- Patch applied. Thanks, Alex > man2/ioctl_userfaultfd.2 | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index b5281ec4c..339adf8fe 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -31,6 +31,7 @@ using calls of the form: > ioctl(fd, cmd, argp); > .EE > .in > +.PP > In the above, > .I fd > is a file descriptor referring to a userfaultfd object, > @@ -351,6 +352,7 @@ operation is supported. > .B 1 << _UFFDIO_WRITEPROTECT > The > .B UFFDIO_WRITEPROTECT > +operation is supported. > .TP > .B 1 << _UFFDIO_ZEROPAGE > The > @@ -693,7 +695,8 @@ field of the > structure was not a multiple of the system page size; or > .I len > was zero; or the specified range was otherwise invalid. > -.SS UFFDIO_WRITEPROTECT (Since Linux 5.7) > +.SS UFFDIO_WRITEPROTECT > +(Since Linux 5.7.) > Write-protect or write-unprotect a userfaultfd-registered memory range > registered with mode > .BR UFFDIO_REGISTER_MODE_WP . > --=20 > 2.42.0.459.ge4e396fd5e-goog >=20 --7vgy4blmhwfscbm4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUSGdYACgkQnowa+77/ 2zK1TA/0DhG5yr7StwFzK4NjnJiDDw+3oacXTZgx6sa0kYYJDqe3o0Bb5SosjsGE ltXNDkCkF+0PaUc85M4zaqpuLtQk/1dYDcn8ySRkl4smkbNhrWd6Bl/2RZc+uUJI KHob3h7Ilt/NIoDuHQBnjleuFrQHQ1ofUZ5RSq5BRyn7JFmTu3Unls8bHWMu+YE/ X8knCMHGQbKm0Y6u9QhMB8rOgUM967n9tV+0i201XmFYkqInb6cbVr0xNCfDRl8m paC6fGbhxeyqDxpSbJi6xa3d4/PZ1PTl7XxuUC3fTCkx6t2r27UVLeWcb5r4fTV7 zV1+tg+dnFxJYyO4LTQCgDYA8jUKjWCmebkXg5MHUB/XXwFxWZk78TNNCgIf/poj weGXn8XbJamFujFPzhAlNlNC07zZPWsHgo5wusxilBFEw2TwmxLxJZjTQmOS3K4c RIbxD5ALLiOPYEfasYOZkMLxtLIiXHAwuG8Z5Wj3Lu0HaTkJy7D2fMxtATIcmQ5R SMhT6QvoT1GtJNn2zGJ3McSwFkK356ECwocQuUp+MTRnSX/OxAQ3raf/VlNhujOA MQMSo6jQdIh4/Rt2HRHgKK+ql7O2FwyTVB2Iw5jiu/NssYokU6qzUq+xZID979ib 4dGcxnIv9+ChW2xfaEA0Kd25ODId3Iiz/qYHcOldYym1txp+Eg== =x8ug -----END PGP SIGNATURE----- --7vgy4blmhwfscbm4--