From: Alejandro Colomar <alx@kernel.org>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: Peter Xu <peterx@redhat.com>,
linux-man@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes
Date: Tue, 26 Sep 2023 01:37:58 +0200 [thread overview]
Message-ID: <fn2nopit4w4gu26ysqzffzobukvlvj77adykh5ythobk6rcljb@sdfwmlzpnf2f> (raw)
In-Reply-To: <20230919190206.388896-5-axelrasmussen@google.com>
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
On Tue, Sep 19, 2023 at 12:02:00PM -0700, Axel Rasmussen wrote:
> - Fix missing paragraph tag. The lack of this tag yielded no blank line
> in the rendere dpage, which is inconsistent with style elsewhere.
>
> - The description of UFFDIO_WRITEPROTECT was a sentence fragment; the
> last half of the sentence was left out by mistake. Add it in to fix
> the issue.
>
> - move UFFDIO_WRITEPROTECT 'since' to its own line All other ioctls
> note the kernel version introduced on a separate line from the ioctl
> name. Update UFFDIO_WRITEPROTECT to match the existing style.
>
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---
Patch applied.
Thanks,
Alex
> man2/ioctl_userfaultfd.2 | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index b5281ec4c..339adf8fe 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -31,6 +31,7 @@ using calls of the form:
> ioctl(fd, cmd, argp);
> .EE
> .in
> +.PP
> In the above,
> .I fd
> is a file descriptor referring to a userfaultfd object,
> @@ -351,6 +352,7 @@ operation is supported.
> .B 1 << _UFFDIO_WRITEPROTECT
> The
> .B UFFDIO_WRITEPROTECT
> +operation is supported.
> .TP
> .B 1 << _UFFDIO_ZEROPAGE
> The
> @@ -693,7 +695,8 @@ field of the
> structure was not a multiple of the system page size; or
> .I len
> was zero; or the specified range was otherwise invalid.
> -.SS UFFDIO_WRITEPROTECT (Since Linux 5.7)
> +.SS UFFDIO_WRITEPROTECT
> +(Since Linux 5.7.)
> Write-protect or write-unprotect a userfaultfd-registered memory range
> registered with mode
> .BR UFFDIO_REGISTER_MODE_WP .
> --
> 2.42.0.459.ge4e396fd5e-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-09-25 23:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230919190206.388896-1-axelrasmussen@google.com>
2023-09-19 19:01 ` [PATCH 01/10] userfaultfd.2: briefly mention two-step feature handshake process Axel Rasmussen
2023-09-25 23:26 ` Alejandro Colomar
2023-10-09 8:38 ` Mike Rapoport
2023-09-19 19:01 ` [PATCH 02/10] userfaultfd.2: reword to account for new fault resolution ioctls Axel Rasmussen
2023-09-25 23:29 ` Alejandro Colomar
2023-10-09 8:39 ` Mike Rapoport
2023-09-19 19:01 ` [PATCH 03/10] userfaultfd.2: comment on feature detection in the example program Axel Rasmussen
2023-09-25 23:32 ` Alejandro Colomar
2023-10-09 8:40 ` Mike Rapoport
2023-09-19 19:02 ` [PATCH 05/10] ioctl_userfaultfd.2: describe two-step feature handshake Axel Rasmussen
2023-09-25 23:44 ` Alejandro Colomar
2023-10-09 8:42 ` Mike Rapoport
2023-10-09 10:58 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 06/10] ioctl_userfaultfd.2: describe missing UFFDIO_API feature flags Axel Rasmussen
2023-09-25 23:50 ` Alejandro Colomar
2023-10-09 8:45 ` Mike Rapoport
2023-10-09 10:49 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 07/10] ioctl_userfaultfd.2: correct and update UFFDIO_API ioctl error codes Axel Rasmussen
2023-09-25 23:52 ` Alejandro Colomar
2023-10-09 8:49 ` Mike Rapoport
2023-10-09 11:01 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 08/10] ioctl_userfaultfd.2: clarify the state of the uffdio_api structure on error Axel Rasmussen
2023-09-25 23:56 ` Alejandro Colomar
2023-09-26 17:58 ` Axel Rasmussen
2023-10-09 9:03 ` Mike Rapoport
2023-09-19 19:02 ` [PATCH 09/10] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Axel Rasmussen
2023-09-19 19:02 ` [PATCH 10/10] ioctl_userfaultfd.2: document new UFFDIO_POISON ioctl Axel Rasmussen
2023-10-09 9:09 ` Mike Rapoport
2023-10-10 17:13 ` Axel Rasmussen
[not found] ` <20230919190206.388896-5-axelrasmussen@google.com>
2023-09-25 23:37 ` Alejandro Colomar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fn2nopit4w4gu26ysqzffzobukvlvj77adykh5ythobk6rcljb@sdfwmlzpnf2f \
--to=alx@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox