From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3704EC5AD49 for ; Thu, 29 May 2025 18:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9AAE6B0085; Thu, 29 May 2025 14:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71406B0088; Thu, 29 May 2025 14:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB00A6B0089; Thu, 29 May 2025 14:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9B1876B0085 for ; Thu, 29 May 2025 14:14:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0BBA2BE7D3 for ; Thu, 29 May 2025 18:14:02 +0000 (UTC) X-FDA: 83496744324.01.E206AB0 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf20.hostedemail.com (Postfix) with ESMTP id 2CB101C000E for ; Thu, 29 May 2025 18:13:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sbjEQdxp; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748542440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AX+Z+FU7v3e67d6zdoj3TbbyWOI/VVebECq9cL7CD2s=; b=rsjA3vNdJP2l3vcApKLDJ7kLJdj/nNvHn0oPe6t05+vJz/BaeX4Rg00q1wJSa800m47Icn OdTSu94ILJ2rkGmA9vEBPdie3XeINghRuWT8XhFS4sDBB+SyYATi/21A/zdTRnYv05zpMJ grziAE8hFBoQMD+ZY0UQ9GDyEUstwXU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sbjEQdxp; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748542440; a=rsa-sha256; cv=none; b=q4mCoYwywX9ucniWNt2B4xKkWCzE5o6oboGmPEDmiDI4mGQN9nEAD209S1l/EU+XL5fg21 Z9GEx7sfKPxh5XIzCJqu9yUP2xRWPPreSibXSTWUkJDDcrpmEuiKAsx5acTegMqYHB90uz 64R3dSxOJjTT2tgVgsRNl1R/HjI9Sac= Date: Thu, 29 May 2025 11:13:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748542437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AX+Z+FU7v3e67d6zdoj3TbbyWOI/VVebECq9cL7CD2s=; b=sbjEQdxp2oh7NLmxDQfyE3K6ahSO5JIX4xvan1uNCVM+YUU6vqzQBNHtoX7/RYvpJhldEQ hAWVaJuERmfTZkudZNofLJj7eCfCiUbSszeKfrJ5g7KXWSaEjZySh8oaJUBGOW8FRrUFSX 7Cdcyqh2TpNbGRcihf/J11DMxdCV+sw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Kirill A. Shutemov" Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE Message-ID: References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2CB101C000E X-Stat-Signature: zy4eaykbkia3d45ojw7erw6cb4kwhknr X-Rspam-User: X-HE-Tag: 1748542439-114572 X-HE-Meta: U2FsdGVkX18FXMUhSguNLST4qwgSL60Dw8plYdZFMprnME1v2wysHFSIkdMeGheA8osuogvmP0A7qn/qJ6c6Kvupt5ydRM1DzL1KROgtKUKyG3LspFv5+fssT0y6IqrSvmQW1P9qcoaPwYhf5XGdpl3brw2KLGk46cxu5TZBl7+m2B5+xetjqV8vzSSZCnjqvUQb0zoL4QyUrfV/nUIF4hToXm6vsQh2Hd5ktmTgexNe6q/s1xgEkeBieUKNywfLwFFPEDmVZTcl0WNnmFVWtdHt6w2QUQ245CfgAKmozz+fFQAbecuP8S6xPmPrauUldJneYX47Nw04Lmv72n/5Xp6u8ZLZTtDupEGS6CwEGTJsB+x36KEno6mP5OxRVB6vhaxg1q50p0H/6at/wxVqZ/09r1RP6NYctA8J5LB6GwcjLv18EuLVJa8xXEAtIhL32cRFYbtmPooe0JPdvGPeStmtjTf8iSJ/v/ebTSxYXYccEvdf8kUQPluDsfJp9BCqfOGcgxxK5VygAJkfotSdJrzUIMCcZnw7IRktMOnUAdn/HilLjD3RKaVlkEFJ8cZW7C2sNsp6Mt0Yxf8XFkBkMP//dTkw6T57boWcRZ2DQ16aZln0S2bM0WBJld6tIUSugtd3ivlY13gpXZN77XRM/6DYQ/dg1kkHdzcSOMPmh770gMM/sK9hMR9Hc84PV8KtIu0T+a4DwNBcPoludG7ABxt6bMTuRadZwsi6+zRQG7PbR4DUQw6w6aLLxflFLjzCmzeoGWU/p6Cv3tbN5Iynf1ZSgoKZJgTllkQfQ7X8Zweie0/WhNa2p6/Mmrqw2ZbEVo6Pg7U5oTgZKnSD83CbhKK1K5RRCpNo0YR1HjI8edufzh5AGxyEygNqzibrJoZybe+RWBPgITWsscOnb+Vk/3gLmDXdrccV4Pl5ugpw6e43ZX58/a5O7tIwOWR7ja2FVNgDSdzsgRZ3pqI+MeZ WZC3bDgQ NHSt+NzAXtvS+rnvzDAGaUK80sGNVGdE0vulqav/8AwtzAMPrNOGxzoWUuUsR86wHGoMV78avTuZ6WmsiUxXGQTLIxXjwD5jdBSoiThHWSgdrGuJmqaDIB+VW40msYgN8spalaDwn/bXv9Rq82nMFIdcOMSs17dAGuj0wbMmaTok84wxNT9VZkBgEbI9TFE2Cf7pcJwFS4TKhQ6Ju4AFPrBAoiMxFsK8nZVz1BRl3j0bux025rhGGZmxRdbY+02keYaSvbZhMXspFXoL+av5y9or4aLqeg05HHMKtwzPXc30DNSyZST44JursIsjjd7+bZhKq202OAe+hNm6FX5PlIHGQvRYNN9EqFf/AeUrUnQRt5B9oPasenJLhww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 01:38:32PM +0300, Kirill A. Shutemov wrote: > Hongyu noticed that the nr_unaccepted counter kept growing even in the > absence of unaccepted memory on the machine. > > This happens due to a commit that removed NR_BOUNCE: it removed the > counter from the enum zone_stat_item, but left it in the vmstat_text > array. > > As a result, all counters below nr_bounce in /proc/vmstat are > shifted by one line, causing the numa_hit counter to be labeled as > nr_unaccepted. > > To fix this issue, remove nr_bounce from the vmstat_text array. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Hongyu Ning > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > Cc: stable@vger.kernel.org > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Jens Axboe Reviewed-by: Shakeel Butt Can we put BUILD_BUG_ON() to avoid this situation in the future?