From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C33C27C65 for ; Tue, 11 Jun 2024 19:51:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928E06B00A0; Tue, 11 Jun 2024 15:51:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D7606B00A9; Tue, 11 Jun 2024 15:51:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701EB6B00A6; Tue, 11 Jun 2024 15:51:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F8B96B009E for ; Tue, 11 Jun 2024 15:51:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D47321C230D for ; Tue, 11 Jun 2024 19:51:00 +0000 (UTC) X-FDA: 82219651080.10.902184C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id A2CC44000E for ; Tue, 11 Jun 2024 19:50:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D2u31ezr; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718135458; a=rsa-sha256; cv=none; b=MUdjDPV7xLn8Dyxag3n9yfVbbYD3TvyyQ1URcp7oO7QI7Wg83h7XyuNGrKd+bcTcuCC1aP sOsUl0HLUI+3LMorb8RC4hZG3eMWN1ej6OPj9yqQqITkm1zx/MkWXY0t5FyBa88WM94sBM seWfrknf/QXKzVMOamoBUSNDPQTTXlU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D2u31ezr; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718135458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VC/FKQpyiv8QuT0prkiboQ+mv2U8+abllOC5cV7bqrg=; b=7r6QzRTFvW3dkznVnvqhQcFUY6Lc8/w2W7ulLHZ1VRbob6jHrcZWiWJRSNQ91OZd7g3bM2 Pcs5GAl1Ep9k7+toMc0dTwNWUQnNk29xPURnBvRbZoCg6d9q6LImholNx36zmk2+0kXFq8 x7/KTIxb8k3nPpwkiAwB0DrPjPkvYZI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718135458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VC/FKQpyiv8QuT0prkiboQ+mv2U8+abllOC5cV7bqrg=; b=D2u31ezrnjgBAxp9J5QUBXEJ2kRFoMpc/7lLHczFAjU1hGqhn+zqpRUY9wcez5yHHpyIoq SUlQA6GbwwfFEPcN+DAPdH09MqZrhU2zd1/RpSoAPxMkQJxaIoMr8ub25Qnur8m2mEintn 4Q17pTcH6OBsjm0kNt861gvcPgQbZjg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-LqqaIjuUPHerab6CrCzx3Q-1; Tue, 11 Jun 2024 15:50:56 -0400 X-MC-Unique: LqqaIjuUPHerab6CrCzx3Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42153125d3eso44059415e9.2 for ; Tue, 11 Jun 2024 12:50:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718135455; x=1718740255; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VC/FKQpyiv8QuT0prkiboQ+mv2U8+abllOC5cV7bqrg=; b=i2o3ftkkwd3tfpMpNScbhQOgsZPuOJ6d2E8aVcFF2hIObhhBrrP1D3JTlcuxi0soVg 0gETHfv0JyjtxVYDwUlkfIGuUXaxeO4YQdrHXaD//mFlpm5e1GrOu6bFovKnQzajo35t o8dBQleQHXVnI5pnwSUYqCnWEUq4Cno4spkZVuJg6txNFhfFWnNHsLmv0beh3+U1HYHW A4VpOkAH5sesvdvP7b5xd+VeoNUhUWRjxyVm1hLjs2FuxrWXotSReK0NXhqqU9K4eJ/q BHPZxB4+N10yuNviMK2XERWLz28WG52LkIUb6yHfOvCofEb3EiGhGAFN9jxfdUv2C08i iTxw== X-Gm-Message-State: AOJu0YwzbIcr3RAorV3Sxxy1AWQaPgW39bQqXG4UaNGWqtmrRKTuaovM H78RmKEsmmPR+a7oKTzvVjq5BbHe7BpYhdPrh2Gdkd4I7V97NP/yDJ1BFtKFZkfxiFWxbRBbZCj 0RJhqC81rUXHClMa+QoWpxaJh5QEtkLXRSfDtvMI6xvfnwYFF X-Received: by 2002:a05:600c:1c91:b0:421:8028:a507 with SMTP id 5b1f17b1804b1-4218028a5f6mr70330355e9.18.1718135455360; Tue, 11 Jun 2024 12:50:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeIZw5rvJCb1LtW+k52Hf6likkqbQ5y9zsOlyQgFY0I2VYm+kIPKpawNjMsNjEje9W3JPASg== X-Received: by 2002:a05:600c:1c91:b0:421:8028:a507 with SMTP id 5b1f17b1804b1-4218028a5f6mr70330165e9.18.1718135454911; Tue, 11 Jun 2024 12:50:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c748:ba00:1c00:48ea:7b5a:c12b? (p200300cbc748ba001c0048ea7b5ac12b.dip0.t-ipconnect.de. [2003:cb:c748:ba00:1c00:48ea:7b5a:c12b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42274379b83sm16254225e9.28.2024.06.11.12.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 12:50:54 -0700 (PDT) Message-ID: Date: Tue, 11 Jun 2024 21:50:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() To: Tim Chen , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Andrew Morton , Mike Rapoport , Oscar Salvador , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> <80532f73e52e2c21fdc9aac7bce24aefb76d11b0.camel@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <80532f73e52e2c21fdc9aac7bce24aefb76d11b0.camel@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: n4u4wfp9okz5og993bc9177zrgyer3yf X-Rspamd-Queue-Id: A2CC44000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718135458-454308 X-HE-Meta: U2FsdGVkX19HofRFu1LKYYt/PyLVzVa/wM8l7aXswc+IcHG8vCgqEvyf+c++ituIh9xjZsiK8FA4iQHyJkhLpcVay2LvvGUdfbZuOE3a+d2kNj1nvmkw7rjMIZt/bs6/o8Zzu2re9r/+YOH55DSI6pb29RdmyQRsPmHf+PCp7sU5yuX5xGRfFirMFNVkk3w3qkOeEaQtRcH6mowTmgrGJBat8byxjN6ICqQYWsIRI1GLt5sBBBRl6kidsiZznEBP3xgNREzLVE9Kl1udCjqQaTUzKELPcHAFphCtPnoQE+la8J5ByR997ver8EKaHa9dTjoM8rO4FDZDFprQBq2Eh33DmU9RIWqcdhFOCpZGofvedQAVaZQZ9x5CgVy1uFoSUiji1g6HiXMv1by6WP1g3jOb+f3LyIdW9LKtl+jUDztG6235pIgNCQ6cZHTurdxinE0gLzH2GWoZRzGgSDZ80tGBa/V2nx3i/hZFjrmE8aWjq4y8+J6nqeQtRBIwSwqTRvDOMYUaR254+iW1khH0LNNZAOxZSS0Flt4eg3BRkmLYGszAZqyKvkbTbu9LICnbMKdPBiWxOB9g6LJ3vSd2m5Jq/tV618MZWPAWTSrwisV4ydJ84lPNUpnIDWNo+TvW5NcLkCO6uJYnJn3Mxwd61hZ1qEngjncDZmBjxeWFte5oQq3uKSJEzNPBx+6Ah3ZacRVgN5SpfCc681alY5uFUphH4JhlD8GpIvi/h2qkPdS1YzJSewCxx+LXPn77T6B0L4kZ2DpkYHry9kJOLdESnJpq1h9VVqvkGajQn0ASyr9O75whxdjVtibctG5Quei+xch4ap4wVR/PNuthyI2djYQ+RtMLQptegs8nSnS3PQlDb/84J6f67S8XtQpOMHDfQbJycTS8TZ91XhAvADoUTD99+0L4ut3NNWGr4kXbdb6Jt2BWozr0eXWJK/rfC42uLWdZuSJy6wFYQdLFVjb 0AhomJU/ KxvrJ9hGsTOsXfz3R/a2RSwPOWBy2AW9SoysDUdmZ56oo+MXl5e/J6hgLhWhthpKRqERtZ6QPtwZ+bbpgpLGYevwE4TMx2q7Li++448h0zUhtd1SezVNksU9wv+f5z+Q7Mo8gLZq+Oq/MPdRjiNJUfiKWr3UVv/rxBODc/jCFUdqEhXPI3s20LjO/C+E2CwF5sEHrDhKPAkBwAotPOLzg9faBJOH4BG2Q9nGxdZ5IKTPpV73SOWgQIMOvhQbsdIJf39FF8MZl7hu0NMTcfyReTTX+M9lZH4DFwpW2A0yVdf12V0OYc3ZpVjSpmSTVWT2FsEU4rXOccCj+M0IboATtlz2bb3xjivO4P13KJi+8po53pkmHlfrAUaeS4Ro1mWuAkHqT4iG1xnv1tLtX9sQEGLLPzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 21:41, Tim Chen wrote: > On Fri, 2024-06-07 at 11:09 +0200, David Hildenbrand wrote: >> In preparation for further changes, let's teach __free_pages_core() >> about the differences of memory hotplug handling. >> >> Move the memory hotplug specific handling from generic_online_page() to >> __free_pages_core(), use adjust_managed_page_count() on the memory >> hotplug path, and spell out why memory freed via memblock >> cannot currently use adjust_managed_page_count(). >> >> Signed-off-by: David Hildenbrand >> --- >> mm/internal.h | 3 ++- >> mm/kmsan/init.c | 2 +- >> mm/memory_hotplug.c | 9 +-------- >> mm/mm_init.c | 4 ++-- >> mm/page_alloc.c | 17 +++++++++++++++-- >> 5 files changed, 21 insertions(+), 14 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index 12e95fdf61e90..3fdee779205ab 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -604,7 +604,8 @@ extern void __putback_isolated_page(struct page *page, unsigned int order, >> int mt); >> extern void memblock_free_pages(struct page *page, unsigned long pfn, >> unsigned int order); >> -extern void __free_pages_core(struct page *page, unsigned int order); >> +extern void __free_pages_core(struct page *page, unsigned int order, >> + enum meminit_context); > > Shouldn't the above be > enum meminit_context context); Although C allows parameters without names in declarations, this was unintended. Thanks! -- Cheers, David / dhildenb