From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3ECE77188 for ; Tue, 14 Jan 2025 10:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0F046B0085; Tue, 14 Jan 2025 05:21:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF256B0088; Tue, 14 Jan 2025 05:21:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5FD76B0089; Tue, 14 Jan 2025 05:21:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A82806B0085 for ; Tue, 14 Jan 2025 05:21:26 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F00211C738F for ; Tue, 14 Jan 2025 10:21:25 +0000 (UTC) X-FDA: 83005665330.15.57AA01E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 8822B1C0009 for ; Tue, 14 Jan 2025 10:21:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xhj7bmp8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736850083; a=rsa-sha256; cv=none; b=Ve+E6giJrvoTlqy1AR0RzKD5GrrDRqihe/ZLM3v1mI+iJp0JssE0MiyvCK+jZFoe1qaso5 Ll7Jxk5g6t3Yef0zkqZKEiGOQFAQ9rGfr4htB8vsAZiJchiWsGQcCvpqIJmxiZA4JWtHuZ sZ8jkspKLwce54tR25sugFJV9pFGF5o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xhj7bmp8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736850083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/eDGvYOLeDMHVMqWmrB864wlTs2RG2NStXaSHeGJEM=; b=7P9E01dQshQdepl9rQzpYGiRAF4dbLtmHzdeHdxY8W79NDrmCjsqV46vEntjRIbYaKwtM6 YX5daLwFt62zgU1fPESYhkcaCXav6D/3bG5Wrsx5OpSbjImnKP/ZpBI7iPOUWrCc23vKHy B/QBe4uhApfAVOZEZnTfMh6oLZaU4o0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736850082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v/eDGvYOLeDMHVMqWmrB864wlTs2RG2NStXaSHeGJEM=; b=Xhj7bmp8nyx2QZgFF+/HD3ZxY6FvK6cyAF/PoKQBstrvNS/K2BKx8JXXN5BC8MlkAVeRJP XPak8eIMeySdhte4F01aQiwYase3J+l2x0J3aRrLFYcm4xsTagPz+M3YNfoBO5mVv2tH8b u21x6CsVFms1DD1ge+1LoAnZpb62kSk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-v4PkyofNOzqMqdv4QvDggQ-1; Tue, 14 Jan 2025 05:21:21 -0500 X-MC-Unique: v4PkyofNOzqMqdv4QvDggQ-1 X-Mimecast-MFC-AGG-ID: v4PkyofNOzqMqdv4QvDggQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361c040ba8so29737715e9.1 for ; Tue, 14 Jan 2025 02:21:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736850080; x=1737454880; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=v/eDGvYOLeDMHVMqWmrB864wlTs2RG2NStXaSHeGJEM=; b=GcEg+vXH8+G438cKJtDwFBEQbHSfax/Fd6YaCw2Ja92SyuPMyMpABVLz0vTJt5DN47 ud1qF7vt2OwVh9npD65NTho3V0VwH3dMzNY2gEnIkahMM5UggxjQtlN1Y7Yb3heO5IYO H3gQxCC2t5CTJLOQz/+9O5lLAv7sjxrx2ll3+xh6N2xb33gzmNveqNZUWnCBHLsWdPEj XFpo+AchQFvD03ZGEBxqJymmyQdCpFD3XFT4hBSf+ZnuPUJDfTgOrESFwDT9BV+WrLa3 znInNpfLcNE/TSEGt5M42o9NKol5bryyZefNMnXuRAWTqClaHTSGhS3ss90bOTZxihjQ aIRg== X-Gm-Message-State: AOJu0Yzqavs1oKpV7+6+WFOV0SlVw6jjTYOxAXV0Yu1ORbAbf+op3m0U z3XBqF/Ut6S++UZPTXQ9ZgSlG26pd8Qj8VXG7ViUqIttdLhI8BqbxxC6i1O2YCSX8u0sKV6FZvv JQGcJ7aBnPiwiMcisOeC5QFWX/t1B+dxTrZzt42lM3Bh2eWgv X-Gm-Gg: ASbGncv+rcuwsitjPGdUvq+V+yaJqTq6lO9uVEkv1gZYJvV0jJsJ1LQjV8KFCIVUXw0 u3kO2khW/xHOJVV2OpUPIpRB5DJDPn80KL5beY+IbUY/iWktB50EbqTb6sSmtcSYakH/g7mM41B +bArXLBjPVatjAB49ybojXW3zS/srbiBR9bf/WDZDAsvhzCI6rKrkhD2mEw/ut1+IfzeVON288C j3BD5brLdCMzICQg6uAaVZbT0ekYRKociOK4XSuldSwSWt6xNP+rV5ni4ClVwO+dPqDQo0/jllY noNZBwJ61PZiOeET2Dkr4NLWmZbPinO8ywNH56LKEiGKRxlyVlgJeBl1Mmt0EhzOgZnuQziGYb+ ARPcXtSSC X-Received: by 2002:a05:600c:1f95:b0:434:a525:7257 with SMTP id 5b1f17b1804b1-436e26d946cmr185726025e9.21.1736850080369; Tue, 14 Jan 2025 02:21:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRX4r3vQSk65lIDDMtCZ3iqMQpWAru7hzZ2jkt7zPuzHqnJH+ZR9OmQCGiZWluLKj3OZXNDA== X-Received: by 2002:a05:600c:1f95:b0:434:a525:7257 with SMTP id 5b1f17b1804b1-436e26d946cmr185725875e9.21.1736850080018; Tue, 14 Jan 2025 02:21:20 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2dc0bb7sm202589705e9.16.2025.01.14.02.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 02:21:18 -0800 (PST) Message-ID: Date: Tue, 14 Jan 2025 11:21:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm/mkdirty: Fix memory leak in test_uffdio_copy() To: liuye , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250114023838.48589-1-liuye@kylinos.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250114023838.48589-1-liuye@kylinos.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iYRi_CqeoJflfprBI9cTCR_7Aj33cy1vs5opE0YiDhs_1736850080 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8822B1C0009 X-Stat-Signature: b135tdxopiap5xxooubyh913czmt5ant X-HE-Tag: 1736850083-396346 X-HE-Meta: U2FsdGVkX19sffHiFQloF1MDplUFWdDDJgGby2vn44U7cuyO2Nz4F5CVea/7LY68EtyAlu1Yeuvg9Qyi55sU5af4FXIwLHvrResb96P0HuBicq55o8Vzx9OaI8sH1tYvycjfErGRBu0hyQngo4qdZRFSkVFyxREaTVFF5tjQXmNzBPGW1DtA5cPhMNPvzfv41mxpxtS33m1KtB3LOP6K57SB6QvS9DZzAtAGWljzaIdFw5uER5Wxvt9LKmmrDjHKtA7YiUiAySjXdw7td8MOfbxs6bevZNm8+CzDfXhp/oMWVLUrcqKdz0h7swKO6H3lSPAzEgXGKQGxcpqwH6e38k0EgzDAPOrFnq4il1Y6adxousfPeLUQoAPUsT1TAqrwYelyCmUuhC9v5SQ3zr4yu9jwsoqAHMBxfUfeF0aHQlUFYVLi5bLPZJcBeGXXfKmROL7S2rNAgh9ag3gN0F+L1V4xEf1dxhhIT0vD0XtL8dgIGvkQmVng+uF/I/9pPmU9sSJJivGQagVnBM123MulJ5lIyrgWj9DPBQ63hyMkLGbUCeQ462Jfz3WVPIF9DtH+DtjB3bMpd9d4RsxWKi5tBYVPIvDgzhZJixD/E8vfGVbcAmgN7o38rRmtStEnh6D9WPnZCDpM7s4QxwuLlvqhbwM1O7TfnckrsRDeHAja5YCiY2MjN6++HsXxObtc1icuIyGnk47pnsnc/4k3u55ZH1wrSApCWRfBJ9dCDltX5bj7goFxYLyubkLbRO4Rx8axIBRWJohrUT6AsG9+mdz0E4b/7SWEjj5pASO0XDbYGlVyVwDfnIAAixst/fHeDePMZjtnSyB4ws2CNnW5UNWDhLlNIOHFUb2YJEZPKRzjDqBoE7aRho4etKljXFPNjTuzPU8pg+IDoZjpV72qDLF3HU5EIw5npGoHiVB/ZBWl54fOk9vD8FYg8Qw++3th4ybrB1kCd1CJrZiTOZTKM8z ChJDKu49 nTB+X4TYaAEmhs646qDrQPWIXEOax3fVuRQfWvlNUOk+gpNhRm1AGGsYj5YxWgCCw4wzx5RwsXvhm1rjIG1f7lUi8IidhtoKmSnECZqzvP3XmVNpETayyTqUaLbYUBXUijwu8wuV/9z4sCG/HOkyTjiqBRuhhRrYC4RcdY7dw9FvW2SC0lVPd8rBVXJdQoTQ6wRHUjQ0oPMSSgSZW8qXsDZuYTwF58GLrLTa9qQAZnVJxRbNBWDgBhz1H018q3uKSieDGP4swbAY+rJMALxO/JrbHijrDAVHbB2uYoUftITPKSw2nKJZIlfqv/wT0JLxA+n4vCP2BwFvRPL1xeuhEj1fZm127D2abfyKXtaz6F+0tjCYbXinrXl0HoFaUAl6exT2N18vmJVhrrakPrw1tlkcUo1RaqdaR/0pejJaoE0iwqP13A/+Ot3jHTDmknzpawKghH3Y4VG9q7m7OtzK8GjaFHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.01.25 03:38, liuye wrote: > Release memory before exception branch returns to prevent memory leaks > > Checking tools/testing/selftests/mm/mkdirty.c ... > tools/testing/selftests/mm/mkdirty.c:283:3: error: Memory leak: src [memleak] > return; > ^ Don't take this the wrong way: there must be something better to be done with your time than fixing memory leaks on exit paths in tests. > > Signed-off-by: liuye > --- > tools/testing/selftests/mm/mkdirty.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c > index 1db134063c38..af2fce496912 100644 > --- a/tools/testing/selftests/mm/mkdirty.c > +++ b/tools/testing/selftests/mm/mkdirty.c > @@ -280,6 +280,7 @@ static void test_uffdio_copy(void) > dst = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE|MAP_ANON, -1, 0); > if (dst == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > + free(src); We are immediately exiting the test afterwards ... In any case, the change LGTM Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb