From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0541BC4725D for ; Fri, 19 Jan 2024 16:09:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7945C6B006E; Fri, 19 Jan 2024 11:09:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71D3F6B0080; Fri, 19 Jan 2024 11:09:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BE436B0093; Fri, 19 Jan 2024 11:09:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 46C0B6B006E for ; Fri, 19 Jan 2024 11:09:44 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E61A2120D72 for ; Fri, 19 Jan 2024 16:09:43 +0000 (UTC) X-FDA: 81696546246.28.6BA48E9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 5F20A1A0028 for ; Fri, 19 Jan 2024 16:09:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705680582; a=rsa-sha256; cv=none; b=IdnkTjxqtbhBgBAYnPMNgHgxiSkRqhWJrhjgyAknWHykMNTuWdWZze1bxDP9MzgoM7RN2Z OaT8d5l1BvJh9z8QSw8bS4gBzi08xY+zSkH+HPnw/PHAOhYJPiM1osuvHil0HiDA6hotRA 1KBYdZbI5LcloGemasGG1jM5vOqBHp0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705680582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbpZkI2FURU4mf3gpDD6//kGwVqgmALvcOyy2RpgGkM=; b=hFnBWNJC12l3IgxT5rdQWCEqnWfQASSCvZSy6FeKtLYlo9O2ZbYo2lnAafJjfm7W7YfyX4 nt9/ApOPQWYxzvEZSmSihahmMQb1MOFe8dbhyNpsxfTtHWGxbOjsqq8JogUqwCg6o976B5 9tUZxCzZE2KDoBhadKdrGJSmfxM4BIo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73B9D1042; Fri, 19 Jan 2024 08:10:25 -0800 (PST) Received: from [10.57.77.97] (unknown [10.57.77.97]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 04F803F73F; Fri, 19 Jan 2024 08:09:37 -0800 (PST) Message-ID: Date: Fri, 19 Jan 2024 16:09:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: add missing tests Content-Language: en-GB To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240116090641.3411660-1-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: <20240116090641.3411660-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5F20A1A0028 X-Stat-Signature: bk3fpgmietrjww4oxej1pdnwb3teyu4p X-Rspam-User: X-HE-Tag: 1705680581-431508 X-HE-Meta: U2FsdGVkX1/FE9aO/mxovmEPxjtwMFEu39tlVj1HKrWWQqifUnAB1Jh6f8CMfM8EQF1ovTKtT7b0qaDSEFs+mCTPatTLwRZdBdfSdZTVq1g3SpHoXeu7lzhDzUlxUOn5CAAOFfxSht2bTfEGVDmIjzKNUKbsVjEVCwdZf7eu/1Y+enR4Ls28rMnQooh6nOf6lUKD8Dacq2rLD11pVFvNfbeXCvMCz+fa6jyPWkMYejqqQ3KqAo/wR5ovhO3KJB/Ank2QlZ4xkx6oIcq97tfV5VcG/5DFn4C4PGRJpM4KPCrwz046YkclDFqRHU1tnKluAz/sm978O40yOukMGh+Yd8V71gp4vx0jhkaTMacYkB08b66CQJWQq84LDX3jxawe9k5qK7/M9chApHHgUzvHm3q519vJD8iUQjCxFJOKRbjsNxb/xQEhdco051YSH8beZWZAXzevhYK3j2DCWzo28TnyG9dlqTWKhd/uqiE8LlnFgweYagW1cVKeJ0esLkeRRHtO4sLemDWzfoH+rP85ubUNJMiiRYyH3ew/TvX5BCU4UHVwgYNayschXXgc3iIvlpN+FeCtyCJoaU8xXa/u6LQ6cLgWOD6LBFQIc1Xd0qo81TSGon/naqaMfo+BeE726uqrmrTVZnAsdee6X33Ltnq38E+YcavwXLA7cJDXETJj2g4EcgTpAdcU2uV18A/dafyWJgBYnmmRhsn+Q9jEHGQzaA//C+M2sJiRiFKuhp9Y/y87eelbZvvKbsjUzY9tqCc917a3R6ZYS2+hYbXrf8ihQCD8yZjjic/Dy86OMrzlEBRR5VnjQMRsz19+65AwnESD/P3zOdJgeArnN/8CLrgMwcHcWTf3VXzvnAfap4K2wcxvL1XMvjiS4ThvOMA9p9/nHxX629cFxW3a1Urg/MK1SjZmQUig424PBXvHw1RXo7i1AQbUQuRuojRP6ukRDwzT+6dwyQUeMYRwApl A5nhTwb/ fT1FPS3Q7CfseTzEzKJVLUkZRhGI/1BdbyGjlC5s8HAijroL4lBuddTfk+Kc4KcCiw6+UxGyHIREcIB5IOaVaCECbCV/UFr1S3kcglxfgylMT0z1yoMCu6F34/w84dOfzBKuvNJZobQxXI/QQO9LfgsNUU1ELFYjy254CGb3UFH1iNwZxvRlsBnHcO6DTejJapQrERzHXE+HFleGFoc2ghDi+tDgP9iqDrj4fJ83xpVaoagehHpq/13HB1oe4pNcPTy7e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Muhammad, Afraid this patch is causing a regression on our CI system when it turned up in linux-next today. Additionally, 2 of thetests you have added are failing because the scripts are not exported correctly... On 16/01/2024 09:06, Muhammad Usama Anjum wrote: > Add missing tests to run_vmtests.sh. The mm kselftests are run through > run_vmtests.sh. If a test isn't present in this script, it'll not run > with run_tests or `make -C tools/testing/selftests/mm run_tests`. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/run_vmtests.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 246d53a5d7f2..a5e6ba8d3579 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -248,6 +248,9 @@ CATEGORY="hugetlb" run_test ./map_hugetlb > CATEGORY="hugetlb" run_test ./hugepage-mremap > CATEGORY="hugetlb" run_test ./hugepage-vmemmap > CATEGORY="hugetlb" run_test ./hugetlb-madvise > +CATEGORY="hugetlb" run_test ./charge_reserved_hugetlb.sh > +CATEGORY="hugetlb" run_test ./hugetlb_reparenting_test.sh These 2 tests are failing because the test scripts are not exported. You will need to add them to the TEST_FILES variable in the Makefile. > +CATEGORY="hugetlb" run_test ./hugetlb-read-hwpoison The addition of this test causes 2 later tests to fail with ENOMEM. I suspect its a side-effect of marking the hugetlbs as hwpoisoned? (just a guess based on the test name!). Once a page is marked poisoned, is there a way to un-poison it? If not, I suspect that's why it wasn't part of the standard test script in the first place. These are the tests that start failing: # # ------------------------------------ # # running ./uffd-stress hugetlb 128 32 # # ------------------------------------ # # nr_pages: 64, nr_pages_per_cpu: 8 # # ERROR: context init failed (errno=12, @uffd-stress.c:254) # # [FAIL] # not ok 18 uffd-stress hugetlb 128 32 # exit=1 # # -------------------------------------------- # # running ./uffd-stress hugetlb-private 128 32 # # -------------------------------------------- # # nr_pages: 64, nr_pages_per_cpu: 8 # # bounces: 31, mode: rnd racing ver poll, ERROR: UFFDIO_COPY error: -12ERROR: UFFDIO_COPY error: -12 (errno=12, @uffd-common.c:614) # # (errno=12, @uffd-common.c:614) # # [FAIL] Quickest way to repo is: $ sudo ./run_vmtests.sh -t "userfaultfd hugetlb" Thanks, Ryan > > nr_hugepages_tmp=$(cat /proc/sys/vm/nr_hugepages) > # For this test, we need one and just one huge page