From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14C7ECAAA2 for ; Fri, 26 Aug 2022 03:21:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3109D940007; Thu, 25 Aug 2022 23:21:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BF7B6B007B; Thu, 25 Aug 2022 23:21:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1139E940007; Thu, 25 Aug 2022 23:21:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F15B36B0078 for ; Thu, 25 Aug 2022 23:21:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BBA5CABA09 for ; Fri, 26 Aug 2022 03:21:11 +0000 (UTC) X-FDA: 79840292742.17.FDF60E4 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf20.hostedemail.com (Postfix) with ESMTP id 3787C1C0019 for ; Fri, 26 Aug 2022 03:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661484070; x=1693020070; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=0Uf4dPH15LnHNbIIUGFKViP3f4zYbR6U9dvaJ/TwSGQ=; b=Mdxjy8LL4iaIq/ErHAzZksXcb0i6kSAAimlBO3K8brhEQv6qSI2MN6qP 4kiE0mwZ6Q9uEi2MQOHe8Hco9jA39teo0KIatnH6tiVw3gN6bJoTZZr3m yRgUTPfJcGoDAFnr5xuRUd8bOMEwcsZHYUeVKlp4iS1203JirDUzeJo/m FFlbqGGDoXJjqxSYO0tEONn5nYowuPcbptk/e83OPst4ywXz2ETTcgmFu +QifjwnR/aATHM9owDGzrqmeMwQfAsqn6O6rh3v12AHoBwcvfzXGtJG0i dCS+KbQFuN0VzSJdHmIy7WmQ8hpwHKbudJN4RsX3z5nW7wPMrSERkAMX5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10450"; a="295685635" X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="295685635" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 20:21:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="613394273" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 25 Aug 2022 20:21:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 25 Aug 2022 20:21:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 25 Aug 2022 20:21:07 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 25 Aug 2022 20:21:07 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 25 Aug 2022 20:21:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1dSvUy/zaILzCydzQtZmlscJZ9ZqS9N2JG1cL5IvLkVZl29Gul1lY4xgnHWNmCNzKZL4/L9YEgwMo/3YfnwgxRGDaTM9wd6o22jBqjsu0xmAxouHQeu3Z3T7yX6U3UVkh2aItac/pJD6LNe/zSsfY6QzEtLGJ26mJnjC93a58suaf8deNhKb9mOMNxwn997f44dX0yxBp/6HS1g2h3bPsB5ggITIOjZ1ev4lN4rWIEf5xjqFovNRuxohYmFyCgYapajS936NdW5oH7hrY2FGEbao5WGWOXghq3I5NTLAYoTIzvPUeX96VjuMbDzJR3U63if2A3hQNLvZ7x5mZEZAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s+bpm7GqhiH3T9SXAETLxqYC6bRW+P/7tFPwIVFVTPE=; b=S6ZWlXNNz5H4kLj7qju2HfjzK9KsBCK0YpUkFr+xd12q62QAYAl+Q1Y9Kr+N0TVdaFIRtKZh/yF8LCoX3Wo8FeRQHJtUCjwVWeMugbWRJNRQ/mfpLdPQXxYEYEQCQluwz7mZhITildoJTBGa5kycbZcJASzMnT9KbDpHinWrzCPMmYCWKIUxmmdrRE0KrZPfdwkOoCnrdxp/V1K2NeNMrvAAF4cbzl/ExA3Ch+MRgmI1mx5ntNP0MwF9pXRsYKzgWlIDltoTP446l6UuAuaejcxEJlmj1xGOa6cOjTGYgocweYltODNwhtcmz8xboBlpmEu4bn0Yc+OqcVCRnHHELA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SN6PR11MB3021.namprd11.prod.outlook.com (2603:10b6:805:d1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 26 Aug 2022 03:21:05 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8845:e130:6f6e:ac66]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8845:e130:6f6e:ac66%5]) with mapi id 15.20.5566.015; Fri, 26 Aug 2022 03:21:05 +0000 Message-ID: Date: Fri, 26 Aug 2022 11:20:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.0 Subject: Re: (resend)WARNING: trying to isolate tail page in isolate_lru_page Content-Language: en-US To: Matthew Wilcox , Yang Shi CC: Yu Zhao , Minchan Kim , "Andrew Morton" , Linux-MM , =?UTF-8?B?6Z+p5aSp56GV?= , mawupeng References: <485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0114.apcprd01.prod.exchangelabs.com (2603:1096:4:40::18) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6998f0d3-a2e2-4fe4-9b84-08da871202fc X-MS-TrafficTypeDiagnostic: SN6PR11MB3021:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1tyyMCyIBpm7sSB5thMjJmUEbUz+u8BqHWLaKAregFLjbWl5B9yOZuHvDI1tfgVBbGli5jg0en2OoT/YhFJHqgnwbfIByvhsl+8HVlCzZhmPaAQSURSrb7+lpI3ODlVOtCZWJfWHWD55SX3xaWZ+Rgz8UmuAPLU+7ApefaGn0bF/YS07MmMdu2Z/hrxdK9nIwppib3BzpP2CPSOKc9NGx6wvMlI02BcOzqArnd7DCRgOS4bexnf7mIZfX/+t6UolK4dlXZ4idmU6qs8PZze46ZbsTaw9M06ml6IrfthoN37HPD935xQoxTdQNdBAcDmLPAxuemR4vJhiVNJiH/WAenDn16G9/qyvRqPpWKnA0W1RoT9jPcBRZzjH6ri+6s+gZ9Rk5bn/hOMA7KAcbcazBB0xyNNtQ+eW71jqJuXoSSUFsS9HF4N4FBpwu8892VDPKZz+rL04ND2C/Xvklwf5kDfTr8hOZklbx/lF8QNjmG/Str2iTWBiXXTBpq1SF/k2e4Ccwd+/TOSLE+OfpPNDjtuAoc9Ry63KN0jA5usQnlm0AaTRhzg8dO3h9MjZkGYUKwVKbcOXtcjyZk7DLf4Er4ZHmY4ezY9KRwZaAPceLdcg9Y0XGelf0w1e6Mn2zkMWmgb6rTV3mFGQeQXYoRFXNs6hlWVjYzu9x2Ggvf9vLFs2i1RvXrZMz4s+vrtUcKPuZJZ08BwTtjuST9f7LsiZ99RWZjT6BPP1QvRGG6D3cgp73MVGCol1BZJyesE1DC4hdIppoIsI47FsxJL2o7LllviUlTdErZdq5ddbiilQ++4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(346002)(366004)(136003)(39860400002)(4326008)(26005)(316002)(66476007)(54906003)(110136005)(38100700002)(5660300002)(66946007)(66556008)(2906002)(8936002)(8676002)(36756003)(86362001)(82960400001)(31696002)(6666004)(478600001)(31686004)(41300700001)(53546011)(6506007)(6486002)(186003)(6512007)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0JnMmNYNXl5enVSMTBsV0xISEwrZFEzVWlmUTJucFBlQUYxWmhSaVY2NHdN?= =?utf-8?B?SnZqckJjVWdKdDhLUHR1VFVCTGxadXFoNTJIRG1LdHFYN3JkZ3QrY1g0cnRi?= =?utf-8?B?M2h1d1UzWE94ZXRMeGJ1U1VuQnRNeDVTQzhSVGZyR1VxMi91VGYwM2lzL3I1?= =?utf-8?B?emF0NFZqcnArUzRtSEtUMHlucGYyWGhrbnMycFBhb3JEUkhxbk5aNVpOS3Nk?= =?utf-8?B?TWdyZ25YN2RGTVBMYXd1Z3Z0WE5PMVJxU3NvTS9NYkVtTGVWRXNuUUtUeEVR?= =?utf-8?B?M3RSK0dzcm04L3kxUjA2VTBQbmgwK3BOc0JiWW82M1laZUdLMVlVdldCaU81?= =?utf-8?B?REdpbkt5elJFZjlOQlkyYVB0NStoL2VydUplY1BsTHJkRC9iVzRnanRWTWJq?= =?utf-8?B?WDFjMlFPTXJQaUljQmJXREtLZERVWHpTQjR1eTU1MlUyZFZoYTAwclhTVHVZ?= =?utf-8?B?U1JsK0orY0tkc29TZ0ZxL2RLSk5sWW5Zb29BeDBqS2thbW52NFlzdU13TVQx?= =?utf-8?B?b0pqVDJod2RGN2k2bkRXaEZ1Mk5BRVUxVlR0VW1hb1R0dFhTaVJkbXZ0c0s4?= =?utf-8?B?TVBSZE9UbGhXL3JURitaSHVPUTJCL0Z0Zkp2TUpKbkV4VUpuQ3p2WGVXWnox?= =?utf-8?B?YnRYWVFjVmovU1lRNXQ2dnFRdjRVYm5pWGhtRFB3b0FQRGh4Vm9UTkpqN0Zn?= =?utf-8?B?TE45cGI2K1JQNUwySFJpTVlPVHZFY25CU0hJVnVoVXNZdFJ0VUhvOHRCZnRK?= =?utf-8?B?dzlrMVBiM3d2QmJzTENYSXNzYnFVTlFMYjY3b3Z2cXFFY3NYTTAyeGJiTFRN?= =?utf-8?B?V3BFdFloZW1QYWs5TGtKMHlCcUZYQU5vZGwxKzVNUnpYbTRWOEdFS2h4aW9z?= =?utf-8?B?UHEvczRsOEtrM1Q5dzJ6T2QwQW5ObTZUZGloZU1LY0h5Ris0b0dFSjBDbTZm?= =?utf-8?B?STIyYVY3dFFYL1dpKzBOTUNmWXc3Y3BKaDJvN1dBTHJmNTlNSG5LZ2pucnRH?= =?utf-8?B?c1lJbWZ3Z3JLTkNJZzdhcGNTVnJ4akVGT0huZmFxQUIrSGdJY2gxZkpFdUdj?= =?utf-8?B?VW1jaDZleUNUVm1YNDRReGF2bjRUOEs0T1ZwVlVENllaZXhHSE1aVjJnS3FV?= =?utf-8?B?QVZKTWJVVW5aVjBLK2RRNkp3UmMzdGdMOUZCeXRXVS80SU9UaEV2d3kwUkkz?= =?utf-8?B?ZXZlM2ZZVG5pRWpibDlEWkVucXNnS251Umlhek5kYmprNS9hbUZha0FyL2lh?= =?utf-8?B?OXpta2xTUkRjTVpxWWhZeE1PbXl6cVp3KzlCZ3VUN2J6QmFmVUsrWFFtMzJN?= =?utf-8?B?cG1HcW1tcGZqZHFPYVRxSUJvWUUrakRiNjluRThlQ3VMSnFaZmR1dUtjWmZZ?= =?utf-8?B?Y2NjMURBUEIwM2VUbDRWMzEzcHkydDVjOFdOdkRWL1R0eXVUVjV0TWo4RXVZ?= =?utf-8?B?WCsyTHN0d2U3N2FIa3docWlWaUw0TStqTldkRjRIS3MvRWJsS1k5a1lpS21v?= =?utf-8?B?Ulp5TjF6T2hobGdPcVVYSDJvTHFRYXpITlE3YUwvYTFPRlE5aUFueW1SVVpm?= =?utf-8?B?WGFRVzZ1WVRnOXJKZWNiWjBmampuQWVNdmtaekdMQ1JlT3M0VzNOc1VQNDJh?= =?utf-8?B?OWMwQnBSbDlTTmpmL29lZWsxVmlTT0U3bUhMUHh5emtyOUhuSGJ4VWNGVkJ1?= =?utf-8?B?UjRmZERDQThFNTlNWER3K0VnQnRFT2x6ckhMZ3VzbE9FMk5DNEhZMlVkaC9h?= =?utf-8?B?NHZLUlkzbitna3hkVVVpbDZSVXpMaWpVUDhmZnYzMzk1cnpzdTZOcUl5RFhR?= =?utf-8?B?SUNIWE55cDcxc3I3c3NlVmQyUnN1czYxMUVYZTNRaVd6ZHZzTlQxaElnenpl?= =?utf-8?B?RzZ5QTZ1OVdwQTVrQ0ZNS3ljR29NUWQ3YllvUHY1eit2V0Jib2JNeThSUmpM?= =?utf-8?B?ckx0MHd4eDlzdFRLL2tHVXpWbVpVNlgwcFQraVNWQ1Q2c1ErRTBlb1o4VHpq?= =?utf-8?B?VUsxekNWTUx0bk5MeklpVU4vTHRDVnhHNEdqTXRvRWloUU8vN0lMWGJHQm9B?= =?utf-8?B?MUZnV2JFM3h2RHpSSEtBd1p1bDZQM0Rlc09tb3lpcTZ6ek5UWi9MeWsraWVX?= =?utf-8?Q?FKt3OkkaArcnKEb8ZHUPJp8Fe?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6998f0d3-a2e2-4fe4-9b84-08da871202fc X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 03:21:05.6710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nSOLFo2BfgXFcR33yxfY/inKMLLFGgatutJ6xG1fP3qXBBOwccLyRLqWCJLHVBmsuaeArk98xPZObT1QJgWsgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3021 X-OriginatorOrg: intel.com ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Mdxjy8LL; spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661484071; a=rsa-sha256; cv=fail; b=uRI6gYEOngWLpVTwdqGgZ5+oYrCrqdxuV81vL1MxOjuuEsIJ89svp0NLRXDzFA9g3Y7Fev TqBBbpkDjwE14+mdCYPfXotjtPXl6UFvICCdFhjAo99fk1+P2wuXBYQ/Tu7eZfbU+Ju3xB MjWriD3q9wwFDnobjsnEU5xea9Y391w= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661484071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s+bpm7GqhiH3T9SXAETLxqYC6bRW+P/7tFPwIVFVTPE=; b=NKOKa6MVVrEgHGfl+tY5v1yl5n/jsrR+oDUrQEE1ukY4FGVxJsrGlBXkLM2XK9u/Mar6eF PyLg0IVGaQLn49W7CVW8vdZ4MOOHzOHnZ2MZdES999r5QRty/DCvk4sRfNfLtWbMa4Xeor I5Yo60jgvu4HQoJKjGpBi6kjX+wMjs8= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3787C1C0019 X-Rspam-User: X-Stat-Signature: 1bgrnacarg4d3ot4rskb4nia8b4ygemq Authentication-Results: imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Mdxjy8LL; spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-HE-Tag: 1661484069-720672 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/26/2022 2:46 AM, Matthew Wilcox wrote: >>> Looks like my analysis from yesterday was dropped: >>> >>> : This all seems quite plausible. The reproducer seems to (correct me >>> : if I'm wrong) create an AF_PACKET socket and mmap it. af_packet.c >>> : seems to create compound pages and mmap them. This isn't folio-related >>> : at all; I just moved the code that warns about it from mm/vmscan.c to >>> : folio-compat.c. >>> : >>> : Looks like a long-standing bug in MADV_PAGEOUT to me. >> Such page should never be on lru, right? We could test lru before >> calling isolate_lru_page() for this case? I know isolate_lru_page() >> does the check, but the tail page warning is raised before the check. >> >> Could the tail page warning be moved under the lru flag test? Seems >> possible, but it should need extra handling (re-set lru flag). Seems a >> little bit overkilling. > There's a number of ways of solving this. I'm interested in seeing > which one Minchan thinks is best. > My understanding is: PageTransCompound() return false for compound page if THP is disabled in kernel config. Replacing PageTransCompound() with PageCompound() could work here. But for the long term, folio should be the answer. :). Regards Yin, Fengwei