From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2AAEB64DC for ; Tue, 11 Jul 2023 09:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36EDD6B0071; Tue, 11 Jul 2023 05:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D1C6B0074; Tue, 11 Jul 2023 05:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4FA6B0075; Tue, 11 Jul 2023 05:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12F196B0071 for ; Tue, 11 Jul 2023 05:57:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D4FE54015F for ; Tue, 11 Jul 2023 09:57:36 +0000 (UTC) X-FDA: 80998878912.05.7106EB0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf17.hostedemail.com (Postfix) with ESMTP id BCD1340017 for ; Tue, 11 Jul 2023 09:57:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EjqzrF7d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9GpLkrj7; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689069455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ndrpTB8+BW2nsVzC9b3EPrI8jU76zMdu9leJSYbJQV0=; b=JeWYEctJ5Z4HowINZ+8yaOfqhQdIoo3P9jxjgRgE1DoPHk9U2zcxA0NZazZWOO5v6onuP8 U5eW3aqm76End1kRAF3iUrOlJn70cJY7/k5KeSE6IMYbLW6RmurNy31rQgIB6Vf/XIApOG D8unQTHoaMhQKQ8RWse/N2az20B5bxM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EjqzrF7d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9GpLkrj7; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689069455; a=rsa-sha256; cv=none; b=UL3uduwuHkNM/5TuB8w4TUFS74GNi96dZ8vXge9VOZpHOW2/B/V0F1O3zurFCWD10KVx3u 8VmZNWeBtQ8K5S8KFwg/KIYzdvN3D3PVsBeNLbII47zbNEVm3V5YCi6UwkN7N2GEoHrv4q oTwawMoWlIbO94IPG60oZw/PMvswAo8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F21BD204E5; Tue, 11 Jul 2023 09:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1689069452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndrpTB8+BW2nsVzC9b3EPrI8jU76zMdu9leJSYbJQV0=; b=EjqzrF7dzWaSqgYHubdacAC7OAN0opHtYL6Gic/sAK5h0MpUDXaasJN+90ETQ4BTmHefVp WURR79+G0fdLTTTaYnLh9Mq3Zy3cUocLtn0lXFicu5J7cZIGofryZS/bBnAhc0shfe+PoW RPLDQ9P+IaCO4M9ImS/u2bOeMr/E79U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1689069452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndrpTB8+BW2nsVzC9b3EPrI8jU76zMdu9leJSYbJQV0=; b=9GpLkrj7A61FyiXBpm5p0gjrtxvX0Cs5FWR9baHVxFZYMl8yzih5HTFJY+NeEJ5G3K/1IC KP7Ax+reBTezT2AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0FF141391C; Tue, 11 Jul 2023 09:57:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zyMHN4onrWRAaQAAMHmgww (envelope-from ); Tue, 11 Jul 2023 09:57:30 +0000 Message-ID: Date: Tue, 11 Jul 2023 11:57:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] mm/slub: refactor freelist to use custom type Content-Language: en-US To: Matteo Rizzo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: jannh@google.com References: <20230704135834.3884421-1-matteorizzo@google.com> From: Vlastimil Babka In-Reply-To: <20230704135834.3884421-1-matteorizzo@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BCD1340017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 55h13hcerttmtgtdb7uyumpuf9m7btoo X-HE-Tag: 1689069454-147661 X-HE-Meta: U2FsdGVkX19qy/FfgoQct3cJmxRzFP6xszkPfThbA7il21JRcp+zsvxvircqgBLISaFqB0OhTLdFNRQSksp8PxMSBdTUJ679mFrCsISXG16vAuqfvSK/vv2qXrxnCyH3GX4L2J3RWrnhRjsBT+qYWs0n0OEscUYvgFyM8iG0IMxN1kKnK0u+sqDZYUkWSL+3HFWf1qsMypI4tsKEjP6hMFnR1jqvwRwWcwYyjbkDfEEJYC3Bfc2zNo4OgL+IWbv0KPEFaIven5P76PrzymXsFR1lEaEGq5zB4ty73pxSjuSfG2SXL3IT7rukIy9hD5ZFI9PUNp1kFFfvHdeLo5rBNZ9ZEDQPc+tDgJY1dA0aoakGyVO84lOnSWVm+4rMlgCk3DwuUGVT9nmSzhHQxuprOuHBED0nJyWYG5giYwiraCnIzj5VKj6RF4WQkTHWaE9TpBGVvjquLi/OCKdwVlxcnErcU2P7CxMBuQdC1hf0mZHTgeCP53R/iFoRu7cxvO+d6zMsw/aT1ZvRWoGIt7SAibW7TK2Rs41f31w3f02oP3g3bstg0vXiSvlkDhQ5gNr2Pbgq8uVe6EP/6PyVCpYWNdPYe1nxCLG1P7hJEMNY3ABtHUIUSzQKC73pwf/TpCCfCzp4cyanoNwubA9x7QoKeWvZoRRqxqr8HaH/j1cMPYT1iQXQBU5eXUVvq44K07zP8/qett2C/bOzyMA2fNyITJnXw+593Le6h9WundOvZwj9E7pMlmhncXXbfKMfU1npaHEWLKcSYYwKShbio/Lt/4LiaeR7fWzzxcxP1202b9v0x6CaO/IDW0S+sdktbSHBDu/kv/IKynzuBodpfXqL4Q3xF7MTXawjEU8w7URkZn48ED79fYaCfV1l51Oi5Utw0MNNXCa2SMFuNXoN0YT86uoDkUS5fsRfK1a9yklFl4UDSEL9FnuaF2pe3pPTYrSqX2w1NdWClGH+zoDTuOY KiIzAA/w bYZYqzOyaPppCDgLDVIrYOirR6sDCjbAKHGYdaKvqbNtZSohi4p8l1fFybD8HYmoJuYUFgn4owpr4NVdacEqdExfEclrwKUf6VRcQ/IPSoSxA0m02XqKgkBZ0sZiK+DlEpztx1YdT9n58RTxHM8lb1SLu0JzmgD7O9BlAvC5fZzeJypWvbO3Qo3Bk4PPFLUqlndfUpxvsREh1rqU2QFbU3nQ9Dlomato8DHQD/fCT3LZVsEM6TuXQEuOlNaN8NQgi0qhi2KOhu5vh2DLqTTh0WwK0fPrKwEHkdKKQnKAVAbd7egPe9DRsrADOOMW53ZVV7xnYP+2ucHugiqtlJF+G4yDlm4Q3EIKaxEXo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/4/23 15:58, Matteo Rizzo wrote: > From: Jann Horn > > Currently the SLUB code represents encoded freelist entries as "void*". > That's misleading, those things are encoded under > CONFIG_SLAB_FREELIST_HARDENED so that they're not actually dereferencable. > > Give them their own type, and split freelist_ptr() into one function per > direction (one for encoding, one for decoding). > > Signed-off-by: Jann Horn > Co-developed-by: Matteo Rizzo > Signed-off-by: Matteo Rizzo Thanks, merged: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=slab/for-6.6/cleanup While reviewing this I think more cleanups are possible but I will post them on top as it's better for bisection purposes than folding anyway, and should involve kasan folks.