From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337CFC83F1A for ; Fri, 18 Jul 2025 01:43:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A67378D0002; Thu, 17 Jul 2025 21:42:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F258D0001; Thu, 17 Jul 2025 21:42:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E47B8D0002; Thu, 17 Jul 2025 21:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7A9FF8D0001 for ; Thu, 17 Jul 2025 21:42:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 119D112CBF2 for ; Fri, 18 Jul 2025 01:42:59 +0000 (UTC) X-FDA: 83675686878.07.F8B4EAE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf18.hostedemail.com (Postfix) with ESMTP id 664EF1C000D for ; Fri, 18 Jul 2025 01:42:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OzhY6Ggx; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752802977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=suQss3GNP11xFC5L3Q4ast43zzYyKcXDz27VF/7omBU=; b=Z73+sMt8iEIbXwa/YQDcA0pn+azKJLTRQqUCYstpyFdRJ6S8Ei2a88mCL3M+Illrh4uLch FnyXiPaCEVVWXjFdW36Jcaaiy9Gv2u097ZzwOl+wXSErWcUsFFRLy1zgqiMkLh4eIDGCQw ColVqIINtjxOdhvIiQSEKXyMpoXRav8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752802977; a=rsa-sha256; cv=none; b=fyoMU1JuxZQe13BK4/ctGbLAj10vZoGUhejPlBY1iBfgT51XpfkoS85Yw33nsbyOlsxd5E ixZn0Jq/cC480UhFd7KPaPYsSzZOsZ2FvuFrs+/6v1flMyYC/TqfkNfWoNXhF1WdqXItgi 5MPGjA9EO9JKdHZbMihRZWqNVFmlOQc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OzhY6Ggx; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752802977; x=1784338977; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nALzQ13/hKtBqXb8rfNtCTmHGGtFpFLO/y5dIAkAQfY=; b=OzhY6GgxP2QmLeIgvMEWT21pPLOMJWdmi4z6kAjhZadMgsq6FqtpJTm4 7W6aGA1mtajznHDbnHQduPhJVpUUqucJINQ9NBNy9XzVBJIm4OrE/QoA0 MQzad3/iI6socqyUo4H5z+Mv85POdb12Y4TwMIlWdZ0LMYxJw/rSm3mEk NZ/ZAER/b8qMcBF89wisRf2zHdDXrWT61o9nRgn2g93GwsJ10wU3Xogw8 pkYubbonHeyfz8wZ1UWa0K67kCk8U0s5JsfuPTzoNVaXwwSbyZ+WkfKoH dUar9JKS2fOIJYfYeohZpdM4tD+W+kiS52UYZdCanZJGUf3TVPeFyOmQr w==; X-CSE-ConnectionGUID: JyfmGHTMRgmVNo1JsRtatA== X-CSE-MsgGUID: bxpRxTmoQX2r5yHlnjQZLw== X-IronPort-AV: E=McAfee;i="6800,10657,11495"; a="77632266" X-IronPort-AV: E=Sophos;i="6.16,320,1744095600"; d="scan'208";a="77632266" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 18:42:55 -0700 X-CSE-ConnectionGUID: ZkS0VEoES4W3YCuvt7mYLA== X-CSE-MsgGUID: koIEcje3TW2XcXgRJ6Mvag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,320,1744095600"; d="scan'208";a="157754551" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 18:42:40 -0700 Message-ID: Date: Fri, 18 Jul 2025 09:42:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 03/21] KVM: Introduce kvm_arch_supports_gmem() To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-4-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20250717162731.446579-4-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: am9q9k6ir4gxeq7d753u3zxkxpprtdja X-Rspamd-Queue-Id: 664EF1C000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752802976-911337 X-HE-Meta: U2FsdGVkX195cSQmaG3b4ZseZCzyxPgtFjLYgN4duGySPdmGhTXkYJlvuwCbETXMj5SApE+/A1pIe895YUsEqEb0LhAfFvgI81LAqxLF5JWneMnQ9f4rTj2hfINmxjhZABhoe2oiqYOiGBQVsR01p5PFoFYehZiZsBEfMMCDhZq7uYdf/NUBJ76zPMGRmTfxdL4A6RfzKlq0v4Is/+j3wS31OQPuqrKzU8n5Han1qApAw//T6tpN1rsq4X4iEOBi4b779ZTLgqvrCpWsNSpJEoo8Z+wFi4XHiWniVW4WPsjRfMmjT7KdCt7iRCABdloSeEXfFCSsWEDOKfjj+Zr5REMS/RVKrtUjqd28LME0/oIh0T15KDK9Yy4VgBO/awFsLx2oGCSPxGl9lL3LQ3xW34loSDeuy1Sf1KaCM5rPnUWPYrEXFr36Y/UMK1LhKHPMp9a6Vba6IaR7YRS03AlVHx4AEmWIYkdOCxj9VqluUSLokTTCqxqqSb2yt/+a9m17GM8A4osugXIgJeT9vxoD17dPpw69H/fXQY/dqX9sAAhiK2oJ/9FCPhi7Yrvd3zj2l+qfUZ+vSrebsIGut1zSQiiYcHdOiaXX3FX1DQRbx+i1hfSbbXt53ohvq32tOndmNKgPux2PFeEd4fe3s0mb/h61DOzVydvWCB0QTTdmTlmbKGvhOwKWFLtS3xBCN7xctq/6Vl+kLhx4c2yI+wirsj6wjz7hDoBo6Aroqg3uRH9041RXFn4oxVSkSxChBvkVtZy1gJBDFcJfpqRSE3EMGjbepuLt1dDtMuECaOjsiAPHqoGFWnPvJqv04yinPGacurte7NWqaGQ8iVkKB0vHmfjfH7JlZ54GqhlrDh/haXQg35qV9UhIE1SYlpQ+L171Hvcw046IdpzOao+1qodOsVJGmO1POR6D1j+lIvL1TQMQPR35MdOSs6kL2p0Y66ykAhmQbTLL125M7w9L0g1 FNVg8ndj cRT3IRvaJmSYqs+lyD7SplokSoJEUeVI39RJ96c1QlzftAsMD/HhjVHH5JLnMPi/oq4UdaO2zozhkLC0X09J0MbZy4IYzFKLgc5oFhmOTt5AfCvmSpQaz//kkOpaq4FKp3IB3ASnYzIePoKxX1npkpXWSbF/LhNjeZAuWKrmp4I+v4518zDm75MSNvMSTo1XZSYHpQZu6da1VI9JGZpKf/C2ECzncnVFhFRR/shKiShFrz676+gE8iVHxHtesfNLZyVpv7dOJOnpT2nm2vNOnFr0pqMCLgAJtWUCx8rMskgp33+i7o+b9c4EytK0Xcp7uYiyz9UWZij+Sj+t++O8lZ/cmbqcLZzgHV9HxEiraVz6Wc1RLhWL9pMi/Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/18/2025 12:27 AM, Fuad Tabba wrote: > -/* SMM is currently unsupported for guests with private memory. */ > +/* SMM is currently unsupported for guests with guest_memfd private memory. */ > # define kvm_arch_nr_memslot_as_ids(kvm) (kvm_arch_has_private_mem(kvm) ? 1 : 2) As I commented in the v14, please don't change the comment. It is checking kvm_arch_has_private_mem(), *not* kvm_arch_supports_gmem(). So why bother mentioning guest_memfd here?