From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA41C4332E for ; Thu, 19 Mar 2020 02:11:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1254720767 for ; Thu, 19 Mar 2020 02:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cF3lAWhR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1254720767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A677F6B000A; Wed, 18 Mar 2020 22:11:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A16A76B000C; Wed, 18 Mar 2020 22:11:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904826B000D; Wed, 18 Mar 2020 22:11:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 760DF6B000A for ; Wed, 18 Mar 2020 22:11:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1C883824556B for ; Thu, 19 Mar 2020 02:11:12 +0000 (UTC) X-FDA: 76610484384.16.pain10_7ed8b820dae56 X-HE-Tag: pain10_7ed8b820dae56 X-Filterd-Recvd-Size: 3419 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 02:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=Bx+nWphk0Tx3WSlxwQ4mWK6qyApS6Kk6UiaD7YfEwcY=; b=cF3lAWhRGUmF0h6gYJAtrg8uRJ 7/sVOSJRSd/WTA4DcA/g4Otv7tZ7tQDwJg9NINJFIVqo7psvXjZvt1atVl7x15xOYq2MdI9EI3WOr 0ueb2s7h+zsJCi5itYwZcy2IimIZYS3vp4wnMFG13ojIDGx7dyTZ1nB6tpGJzmEDgXREw3LxBCF5T EslFcghYWereAbjkREKBREt8aPkqTfk1QTLhRjsPlz8oAxdr+j0ZhPmQBgPiqrPhqiXimro+4dQjt D6+1BjKxYx4s2QOjgFoJGg2dSZ5TWfsaF2TNlD5ntVsukv0QlgoDp557eFEZllbfgILwTHpjYPwlq L3VDGozw==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEkeL-0007tW-H1; Thu, 19 Mar 2020 02:11:09 +0000 Subject: Re: [PATCH -next] mm/hugetlb.c: fix printk format warning for 32-bit phys_addr_t To: Joe Perches , Linux MM , Andrew Morton , LKML References: From: Randy Dunlap Message-ID: Date: Wed, 18 Mar 2020 19:11:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/18/20 7:04 PM, Joe Perches wrote: > On Wed, 2020-03-18 at 14:33 -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix printk format warnings when phys_addr_t is 32 bits, i.e., >> CONFIG_PHYS_ADDR_T_64BIT is not set/enabled. > [] >> ../mm/hugetlb.c:5472:73: note: format string is defined here >> pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)", >> ~~~^ > [] >> --- linux-next-20200318.orig/mm/hugetlb.c >> +++ linux-next-20200318/mm/hugetlb.c >> @@ -5469,8 +5469,10 @@ void __init hugetlb_cma_reserve(int orde >> 0, false, >> "hugetlb", &hugetlb_cma[nid]); >> if (res) { >> - pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)", >> - res, nid, PFN_PHYS(min_pfn), PFN_PHYS(max_pfn)); >> + phys_addr_t begpa = PFN_PHYS(min_pfn); >> + phys_addr_t endpa = PFN_PHYS(max_pfn); >> + pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%pap, %pap)", >> + res, nid, &begpa, &endpa); > > You might correct the odd use of an open bracket > then close parenthesis and add a new line too Definitely needs a newline char. I'm fairly sure that the [begin, end) notation is done on purpose, meaning is included in the range and is not included in the range. > > Perhaps: > pr_warn("%s: reservation failed: err %d, node %d, [%pap, %pap]\n", > __func__, res, nid, &begpa, &endpa); > > thanks. -- ~Randy