From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8F4C4332F for ; Tue, 12 Dec 2023 14:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B8276B02F1; Tue, 12 Dec 2023 09:54:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 968A66B02F3; Tue, 12 Dec 2023 09:54:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82FE76B02F4; Tue, 12 Dec 2023 09:54:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 730F96B02F1 for ; Tue, 12 Dec 2023 09:54:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3E6B240A46 for ; Tue, 12 Dec 2023 14:54:42 +0000 (UTC) X-FDA: 81558462804.04.18AD3B3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id D154040026 for ; Tue, 12 Dec 2023 14:54:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpWPonnD; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702392879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nHow/OuTkq7ZGC7us2BB0pRida/FxOxA+wS3+9JxabI=; b=oOmT2ZhvqCegP1b31fOzGUpm8+x/xfCTcdroKobrpss9JMn/3b4Amc9xmtt5/uJnFKIuHu UlQGtjyeihiGUdmL8MfESG87JNKbQZj/OEN2jOI5K+UZOE0OERwAnooqgJfbi1fdeQDfCP ONI0Yn5X6/dSWbk6aMdch2eZGVJM3SM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702392879; a=rsa-sha256; cv=none; b=7W3EH7e208efMrLWJUx3Gy0h1lVN4VQWD+DcQS27Q+Hw9ifRjpFSGH8ONMzGUsFVy9Ajsn vZIMCsKyqNOIQXMikNdVdp7fUfNp0KnhHAOzZo5E+Av+9E2BG8r3FkFk2P/pw0rxHR3oBE 5BBDn9B+fifzsZJRir/iIt2NvgoHp5I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpWPonnD; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702392879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nHow/OuTkq7ZGC7us2BB0pRida/FxOxA+wS3+9JxabI=; b=EpWPonnDkYtIfTi23kKvPSOITPnfvWg3KKrO24x1iLIq1KeZWgTDyblwHPJ8/vWQ0KKa55 NH369uGEwCF/5/XYUc8vJGpx8KbtIf2/mnbN02oAUYSYVVLXTf+pBwCEPSSYpbATfjmf/8 e0HuZQOX+Bp4WndGisPLr1rnemN5+lg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-Fzk6MkmSPsW3qUpXrVQs0g-1; Tue, 12 Dec 2023 09:54:38 -0500 X-MC-Unique: Fzk6MkmSPsW3qUpXrVQs0g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40c495a9c7cso12855455e9.3 for ; Tue, 12 Dec 2023 06:54:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702392877; x=1702997677; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nHow/OuTkq7ZGC7us2BB0pRida/FxOxA+wS3+9JxabI=; b=K8konn3lsHon7jE5X6eQnYGjOBZcVyQfQJu+S3DqVW8rCIa6QAAUxgixJJuE8X5vgp RlPAq4WALsGtE0oC2kX3f3r1eCcsZVFJ1RMOydnlmHypavt2PSYe7pgfKt4potfa9IBD ZCNxMPjTIBVQGRHRhLdSJjyb2w8kSvYOLL+PXI832Z/7O3z/Y9sseNQmN6M5fuFO5E+9 ihq24qtYrxIZ7WjzPFRpZZZonhqq7wD9ZcYGNbK3MOWDKeHe36ccY0BjS4+QZF76qz9r H2fr3a91swuRPzGeYIgPIUJVicYvOl1a0RJFennXW5rMcjz1VEe6ZZuH8UPGMgNw5Et9 C1/w== X-Gm-Message-State: AOJu0YwJlodAXyyj3nN3wGq0PVj8B+ErHHXmhDCrOTdDe2TGFKWmI0IW 6NbTCAHWc3E7EUUZStqyc0NKf1nAmIVMl5OwjLo4fHGsbhL6P+7pf3rpggDMpvjcDAvJ5X3J18h OOmM5WeawWSo= X-Received: by 2002:a05:600c:2946:b0:40c:296e:7bfe with SMTP id n6-20020a05600c294600b0040c296e7bfemr3180084wmd.140.1702392876808; Tue, 12 Dec 2023 06:54:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuE/LNZkhO6BY7R3E00Okx+cRdSCf/S+VdKZyExVc3zn/84/FQA0KMC/O7nHgd8h2W5hfVTQ== X-Received: by 2002:a05:600c:2946:b0:40c:296e:7bfe with SMTP id n6-20020a05600c294600b0040c296e7bfemr3180058wmd.140.1702392876335; Tue, 12 Dec 2023 06:54:36 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id fs27-20020a05600c3f9b00b0040b36050f1bsm16489167wmb.44.2023.12.12.06.54.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 06:54:35 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 15:54:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 03/10] mm: thp: Introduce multi-size THP sysfs interface To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231207161211.2374093-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dft9huu638yyttd9wwdya1zrwesart55 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D154040026 X-Rspam-User: X-HE-Tag: 1702392879-970284 X-HE-Meta: U2FsdGVkX19FVRYfseKKNE9ugPvpIM+1+U2YqET4ifM2DdneUoa2+urj0BfYNozcyfIJEfqao3MqYoG/QxYiLuew8yepl60EOfY38IUGn8oEsklDuotTaTLjZw/BNAuRkz49FT7XGTd5WR27J+U0nz0i1RcTtrnP8NDUwe7wbDrTlDTSXCiGe0UVXx0lu80pUqVKuHYbMLgZzuhBBpu+Cjk8+OzwYB4vVZjz+V+L3JsI6QSXkKosYcTTb8o2Ko0I1BYLciAu1oS1ojgzMPPCrupqbwymQUKmWddI1PYyzX1jvLBqgnQstqiSqNiHyX+nhrM38QxzebPs6bJHrcYQeCsilCiEZPyhTgVauoxkJQEdR637hygGrpr+XrdJy34xIApObJ846hO+p3vhPBzy+3F5UXsL8J5LZN8Y8MluugrHB5PGcuNm11dXbM2RW4z6zpDaWupOZy2fo55mSeRi4zeaz8eWqh07/d1WCGWEHdomJEhSSu1ds30aVcGrsn2uQ+ilTj49SlRkNRVpnDk7hUTc7zRJz5SE4WhoPtK/Qj3cE03RAemAcG+ra+t6TPI/ZVHAHWzNOcQsboAMnddG8GJN5SuunZ/H7Pi38v/KMSzf/98e+HT/j80Hp2n25ZUFek13N4sGaHidchin/KcAp+c42l94sADJu/Q89/0xaWGndPOpMecKFQE4sqQ6abYkANXcGoCyylgqq0md3SNDl0lX7XEW/5L/wutqdnekJCfzboJyA4H+ZiJGETBix+fMU98EmW59C03FwlIGLTSZ87DbEUf9kh1fIoq07XiKLsR8WmBicYOBRkohakdV7bB4xGb82YVuhiX9Fdyig22nfeHll+APaz3qAQ7Q/pgMrfuTdqytd4GAiMEm7AWBCpBz3+40mGHV2RFl07E2z9Ga6BLdrYiH6oqnpw2roCX2zP7AINDUMS24sXUQvFwkJfFno9LzvUDomRpME3W/lOm iz/R5UZp eYa9vlzQDS3nqHWX/fuyjjVndqnYzQ9d0AcI3BnKy8LYRl4xi59RHyj9k5/7K6Jp8UhP5K72vFlITnBvj0wr9NRGudy2+YYm3cOCWMI22892E+a/IH4AJwabUQq2kPOouNTrQH9dB8CENPYARDPTXvq/9vre5O5zFMh2TjBuP0Qlv1S4dKvVQ4kHlb3z51lh9pRtB/VEHZJNk1H3o0tyKnxqiZBNTcx8mJ1r3iDaudQJLjo1jyMlV5jd2UpR3uJS3a6H9BOmR5McpfCwekTv41fg+fsobi9/g4Jt5KrEnj+NKHGyGgxAXXqmvV3RtpoGV5BKZmaU1iz95FoRAKX/Xb7S+aej4p00jJuX6m5ut/Y/Qt/l+b+LWvdt9vBvnvmO15rox/WGJQWj2nMYqEWObbncnVv7x9DrOeHcn0IbU6PU+AyWRWHhd9L0oEi8ed+2FMO7QMUlC+8za9QBCrirJ/DGRFL0KWL+b7qZDh958y3teeTha9eGh4Fm/pp487SIjomhX2dbBkTScKIchf7n1ZajrjgdBRrXDbQifGH8E7a1JgwWbqgrV1rgdytCGBmNlbNmUoPUdJhiEMxPHCPL8PEJF7n/OwCCbt0jmBjpHMh9ApO47jIs2zjBHiQE766vFmJ40fjJ75unqmrreW9d6JBBr4I6lwtT4/byCsiYoIRLtAus= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.12.23 17:12, Ryan Roberts wrote: > In preparation for adding support for anonymous multi-size THP, > introduce new sysfs structure that will be used to control the new > behaviours. A new directory is added under transparent_hugepage for each > supported THP size, and contains an `enabled` file, which can be set to > "inherit" (to inherit the global setting), "always", "madvise" or > "never". For now, the kernel still only supports PMD-sized anonymous > THP, so only 1 directory is populated. > > The first half of the change converts transhuge_vma_suitable() and > hugepage_vma_check() so that they take a bitfield of orders for which > the user wants to determine support, and the functions filter out all > the orders that can't be supported, given the current sysfs > configuration and the VMA dimensions. The resulting functions are > renamed to thp_vma_suitable_orders() and thp_vma_allowable_orders() > respectively. Convenience functions that take a single, unencoded order > and return a boolean are also defined as thp_vma_suitable_order() and > thp_vma_allowable_order(). > > The second half of the change implements the new sysfs interface. It has > been done so that each supported THP size has a `struct thpsize`, which > describes the relevant metadata and is itself a kobject. This is pretty > minimal for now, but should make it easy to add new per-thpsize files to > the interface if needed in future (e.g. per-size defrag). Rather than > keep the `enabled` state directly in the struct thpsize, I've elected to > directly encode it into huge_anon_orders_[always|madvise|inherit] > bitfields since this reduces the amount of work required in > thp_vma_allowable_orders() which is called for every page fault. > > See Documentation/admin-guide/mm/transhuge.rst, as modified by this > commit, for details of how the new sysfs interface works. > > Reviewed-by: Barry Song > Tested-by: Kefeng Wang > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts > --- [...] > + > +static ssize_t thpsize_enabled_store(struct kobject *kobj, > + struct kobj_attribute *attr, > + const char *buf, size_t count) > +{ > + int order = to_thpsize(kobj)->order; > + ssize_t ret = count; > + > + if (sysfs_streq(buf, "always")) { > + spin_lock(&huge_anon_orders_lock); > + clear_bit(order, &huge_anon_orders_inherit); > + clear_bit(order, &huge_anon_orders_madvise); > + set_bit(order, &huge_anon_orders_always); > + spin_unlock(&huge_anon_orders_lock); > + } else if (sysfs_streq(buf, "inherit")) { > + spin_lock(&huge_anon_orders_lock); > + clear_bit(order, &huge_anon_orders_always); > + clear_bit(order, &huge_anon_orders_madvise); > + set_bit(order, &huge_anon_orders_inherit); > + spin_unlock(&huge_anon_orders_lock); > + } else if (sysfs_streq(buf, "madvise")) { > + spin_lock(&huge_anon_orders_lock); > + clear_bit(order, &huge_anon_orders_always); > + clear_bit(order, &huge_anon_orders_inherit); > + set_bit(order, &huge_anon_orders_madvise); > + spin_unlock(&huge_anon_orders_lock); > + } else if (sysfs_streq(buf, "never")) { > + spin_lock(&huge_anon_orders_lock); > + clear_bit(order, &huge_anon_orders_always); > + clear_bit(order, &huge_anon_orders_inherit); > + clear_bit(order, &huge_anon_orders_madvise); > + spin_unlock(&huge_anon_orders_lock); Why not perform lock/unlock only once in surrounding code? :) Much better Acked-by: David Hildenbrand -- Cheers, David / dhildenb