From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B33C46CA1 for ; Mon, 18 Sep 2023 11:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950766B030A; Mon, 18 Sep 2023 07:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9004F6B030D; Mon, 18 Sep 2023 07:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF466B0311; Mon, 18 Sep 2023 07:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F09B6B030A for ; Mon, 18 Sep 2023 07:33:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 382C5A0D6D for ; Mon, 18 Sep 2023 11:33:58 +0000 (UTC) X-FDA: 81249508956.23.88B8C7E Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id 72BE4140017 for ; Mon, 18 Sep 2023 11:33:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695036836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5FWUD3A+WASfPmfnXpg6Os6+zYl9lBZEVwuMD/Ogihs=; b=Hdclm9+/aL/9w4abNub1b/KuFsPnvGfjfCKkDZsGzuQxQRGBiMsnKilGJCdL69QAdcCwyN lzvkFhO/zhLz17pCb/WgPguX0ptkVNC0lhpWe5JrUKOYrb1Ujo3K4hkXaU5cyZGqt3MBNX GjEHwRI95pDOEjxncjGDx9FZLA9PlA0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695036836; a=rsa-sha256; cv=none; b=ktQf0EZxkQ6occQI5TxxzN8P14CYV+JkMo7YJTrJnzF4JvnUrbz0PUt72iWw5n3zdAjRun jrdiiGFdKkaW7oqQV8QxyWF02Qfb4oNCYOPwn57Ayd6GHtyCXPY/8HROcPLKycdzIWWph4 70JoTGsN/3Ihlp5KquIz5WJ/iMg34/A= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rq2dj1WCLzNncT; Mon, 18 Sep 2023 19:30:01 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 18 Sep 2023 19:33:46 +0800 Message-ID: Date: Mon, 18 Sep 2023 19:33:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 1/2] mm/damon/core-test: Fix memory leak in damon_new_region() Content-Language: en-US To: SeongJae Park CC: , , , , , , , References: <20230918110009.78365-1-sj@kernel.org> From: Ruan Jinjie In-Reply-To: <20230918110009.78365-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Stat-Signature: 9s8fyz3rgkb4h5cic78nksfoe3qdek38 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 72BE4140017 X-Rspam-User: X-HE-Tag: 1695036834-263950 X-HE-Meta: U2FsdGVkX1/IxyeCqf5Zw1VxFVcbjrBCPhHHchNd3LyuXh0eSn38qALq1YaedKq2qdWa6S0endbsGrFsNUB/Xs7H/nX0vPJA3ZcdwM6MVIq6deDfSL7uJK45QFOo8jn1THtx1ZaWh5/zMtqPFklyXbBnZE9BXwEYvNIAORvPcGTj7NAPzwwR0RZIFxJh0ZtQotT+ZiVvs1DS+p5VK6RPOFdwtEfFqHTA/q5ItY8taD8wovc8xZDjzsbFnC+WYlWYl5TvKeM7wVqmmxWDAtsQPBic/c9hSpP7sXaza9STkPcQpg0vnAQhRl9wddt3wcDUx1IafTBPqq6tkQWcuRzTqmWsjELTRJM3Yh03L3wZS62W1QIZnw5GpvdDAz7SoMQ7GNVC9pTQg7kzDufceB0QPVa/99pXwJd0g/wygrpWc1Xs8U0Qc5ccp4uSGxzf2d4w3EO8JTR3HyTtRd/qT5TcxR5uwK4MYY/uYuCeVa7iyoeR1DrxIh9sK+EcfDganNbKrSPY4kvCelRf9T4dLLQAGTdueNHHXk2RbtGBfDg0pBF8tm7/F1u+52DV2iRtplpK5tdhOC+yMJXj7Zv0o48aHkn3vmIWb2AtUmTIBu2o+R29lvAQDW1aFVt90hed/ZdzgivaNjgVlRDPDLHroGWvFDKNfQP7JN00/cj9404hTtl6CaXknyzh+cDyemOmgWs8KVuNz8/NqhaIlzyhJ0WQLTFA7Wm1a/CD1ZEnbL9xDIUrLR2zxkp/dtpgtgsCdN6lIkqjN1/NsXo8ozpjunoJYOPNyMYoD4k24A5I1j0e+9zsnZ1Zyaw6Z1+BrYVFLlQVD4priikLafYQkZzpTyhzNGKDo2bgh8MDZIIkybbID/lKtXTMjnmIaGmPg/y144aEW/8uzxL6+PMjxSbz8f40MKIiGGPl0fyYxXVPUylc7ik2N9cRI+Y6OLJSqPSlFPebN8N/7qabR/rH7EEcnIX izRc6Qt8 l4PyoeZwjuytaRMBAnafG4QrhkLM87znhoFWtX8keMt1qjc6wnTtb40hmSpOGzvqaM4ZJLjCKe9AQ6UIl8dBCtv7reuTcMToEYaKplkzp/+FAPkhdDGFvVHjUgeSh2GaofKk4KrfH2nHkFWKc9+i51430iwN7kLxpKcABovuEwYpVxh90i96IX/HQPEPKo/sqt0gGvoQAFKHmOJxe/aj4rvoyAMr5CHHAgL5tAMpVYEHtdzQCa6VTeONUG5/lmti8daXva0Pds+NJ2V8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/18 19:00, SeongJae Park wrote: > Hi Jinjie, > > On Mon, 18 Sep 2023 15:47:58 +0800 Jinjie Ruan wrote: > >> When CONFIG_DAMON_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y >> and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. >> >> The damon_region which is allocated by kmem_cache_alloc() in >> damon_new_region() in damon_test_regions() and >> damon_test_update_monitoring_result() are not freed. So use >> damon_free_region() to free it. > > Nit. This patch is not directly adding use of damon_free_region() but replaces > damon_del_region() call with damon_destroy_region(), so that it calls both > damon_del_region() and damon_free_region(). > > I think this part might better to be re-written? OK. Thank you! > >> After applying this patch, the following >> memory leak is never detected. >> >> unreferenced object 0xffff2b49c3edc000 (size 56): >> comm "kunit_try_catch", pid 338, jiffies 4294895280 (age 557.084s) >> hex dump (first 32 bytes): >> 01 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ >> 00 00 00 00 00 00 00 00 00 00 00 00 49 2b ff ff ............I+.. >> backtrace: >> [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 >> [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 >> [<000000008603f022>] damon_new_region+0x28/0x54 >> [<00000000a3b8c64e>] damon_test_regions+0x38/0x270 >> [<00000000559c4801>] kunit_try_run_case+0x50/0xac >> [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c >> [<000000003c3e9211>] kthread+0x124/0x130 >> [<0000000028f85bdd>] ret_from_fork+0x10/0x20 >> unreferenced object 0xffff2b49c5b20000 (size 56): >> comm "kunit_try_catch", pid 354, jiffies 4294895304 (age 556.988s) >> hex dump (first 32 bytes): >> 03 00 00 00 00 00 00 00 07 00 00 00 00 00 00 00 ................ >> 00 00 00 00 00 00 00 00 96 00 00 00 49 2b ff ff ............I+.. >> backtrace: >> [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 >> [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 >> [<000000008603f022>] damon_new_region+0x28/0x54 >> [<00000000ca019f80>] damon_test_update_monitoring_result+0x18/0x34 >> [<00000000559c4801>] kunit_try_run_case+0x50/0xac >> [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c >> [<000000003c3e9211>] kthread+0x124/0x130 >> [<0000000028f85bdd>] ret_from_fork+0x10/0x20 >> >> Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") >> Fixes: f4c978b6594b ("mm/damon/core-test: add a test for damon_update_monitoring_results()") >> Signed-off-by: Jinjie Ruan > > Other than the above trivial nit, > > Reviewed-by: SeongJae Park > >> --- >> v2: >> - Replace the damon_del_region() with damon_destroy_region() rather than >> calling damon_free_region(). >> - Update the commit message. > > And thank you for making the changes. > > > Thanks, > SJ > >> --- >> mm/damon/core-test.h | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h >> index 79f1f12e0dd5..3959be35b901 100644 >> --- a/mm/damon/core-test.h >> +++ b/mm/damon/core-test.h >> @@ -30,7 +30,7 @@ static void damon_test_regions(struct kunit *test) >> damon_add_region(r, t); >> KUNIT_EXPECT_EQ(test, 1u, damon_nr_regions(t)); >> >> - damon_del_region(r, t); >> + damon_destroy_region(r, t); >> KUNIT_EXPECT_EQ(test, 0u, damon_nr_regions(t)); >> >> damon_free_target(t); >> @@ -321,6 +321,8 @@ static void damon_test_update_monitoring_result(struct kunit *test) >> damon_update_monitoring_result(r, &old_attrs, &new_attrs); >> KUNIT_EXPECT_EQ(test, r->nr_accesses, 150); >> KUNIT_EXPECT_EQ(test, r->age, 20); >> + >> + damon_free_region(r); >> } >> >> static void damon_test_set_attrs(struct kunit *test) >> -- >> 2.34.1 >> >>