From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB338E77188 for ; Tue, 31 Dec 2024 06:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E86AC6B007B; Tue, 31 Dec 2024 01:59:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F826B0082; Tue, 31 Dec 2024 01:59:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB01A6B0083; Tue, 31 Dec 2024 01:59:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ABAEF6B007B for ; Tue, 31 Dec 2024 01:59:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1804C120CE8 for ; Tue, 31 Dec 2024 06:59:45 +0000 (UTC) X-FDA: 82954353384.02.761B744 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 062DAC0015 for ; Tue, 31 Dec 2024 06:58:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735628339; a=rsa-sha256; cv=none; b=QFh//DmG9XOxmXTWdeKco2o/Yi+bkX1I54Sww8vSaMjH5yDdrOh5+6f+eE2UkzaNO1CG29 YYJYLvAg8Y3miSLQUIj+Awc7a8SnVjErvcBwUsEd8VhRMb2lO55lYGpPKWkr6pXbCVPcpO K8suCxwsoMzk9IGmVFdaxwd6TdcfTcA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735628339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kg0xzBmwQrArrOItTGxpNn1gMbaQ2Jt8yThpebw6PVE=; b=bPnexpAngQb1+zYMYLpjXPb6vAtaF7AA0o5YFhmafDfoLJ7v361DHLtVHCSPjvlO+A05KY Mmaq0YWMNxkWwzcLdk9fciH9O+4lK+b4Bh70kGlxV/Kxu+CEt3PNEduanqeALmV3j4pOjV AhcxJNEWsgSp1cE4mHWnQli4/RTkSq8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 529D81424; Mon, 30 Dec 2024 23:00:10 -0800 (PST) Received: from [10.163.53.15] (unknown [10.163.53.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 071B23F6A8; Mon, 30 Dec 2024 22:59:36 -0800 (PST) Message-ID: Date: Tue, 31 Dec 2024 12:29:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 To: Zhenhua Huang , Catalin Marinas Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 062DAC0015 X-Stat-Signature: jhwj94u4hdcpcagstmneor7m6mppwh4r X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735628331-55625 X-HE-Meta: U2FsdGVkX1/tQ+6+Zo1D6xHCofKAR2jzueTe40KwTPz6ANlyguWNsLAIUAGJ53qvHCXlmz4UDSjRM5jefHuyKZVY7X4TS/IrOmhWO0KnHwWh9fsCdy4HSkZtjDMG0fGT0w3FqaRV34ZScFBEo0HgdkTJrej40V6WFjxRN1UHCrpyzjYp74+tGi+kWMphH6aGjyIRz+KinB7p00H3Gib2ci6xngYU/kN9o+S6iNKDmW2c2ibCfDv95si6l54qn7/kRfYFw4vgopAOeaT2yBpozairzbhWJ1yi7Soi1ZGV4hGnfe+ZTZgzwi61Zcusjfzo77R4JTiPcmxcRRZP0NMG1jbdQ79kYBcai5svk1v0fUcCItPQdl/Du2R7i48lK0wTIdrbSPUYN3rfgrgn2ccSi35atEsNIYaifO6aUixwojz95I5sPBJUnzfDTGFxgMHt3OeI3OCkzlEqXgqVtw0zsY0HcBIG0FQPSxtmaR1YwojsRUslNcafjfTMHB0VZNXeZDfEC12sO2rO3eU6xwMBBXNfqcsB3pqckVA7HImibBCOc+JVTd9TIRm+DzZau4I984f8KdnSb66pwG4vyjGP5cuXqdW/62nG9KDxQLoE9+gQOZfkekcB777I6RrBga4cEDQLdA6j5a22Yb/CmadqjdmduQvS7egbQuhBYtzM8jBe0hAsuB75DTgBBpXoivOW9e+2mmhXq/GXtfQWEwAAHXjAWhxFfq97eXxUPC8x25OuRR/sAPtCYL+wbitk2hZeHLBcw60NMTwPpcIxSHerqzKODCbVm2pwEPZFvyTgOgl5bk0FSlfsX3qIHwiI+G5+5h7l+Sx6NjFkDh7ltxU5efy3PtlJoaLa051Dyv+P/f9C2VipLxD4vTOwo4AdVMyLW84yw8DG26FxG00bLZwd5ndOrbTZ1/I0FMCOC/UtcKHnlbVf1N5YUsqbtH3rxYVx71ocBE3KFnycf05ngJ1 NXuzIKqY coEF+uhpfg1zoKZpNBmzPg34pMBZP3VNfIUpmNYKpJt4EBOwVksIifyO+QFhbQH6GJFSrpT152OhqarnauR5x9SNNOLlqNfjyi2QX/ZMcsxbf1jTSA+ok32uZZ6YG3DvmZoMlwyPtUsrR9VVRn/VI4zxsNxzz7ZsbABQX3VWVbpHRkDLDHxc3XORw5ZFTarJuLKXF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A very small nit regarding the subject line. The callback vmemmap_check_pmd() is already present on arm64 platform which is rather incomplete. Something like this might be better. arm64/mm: Test for pmd_sect() in vmemmap_check_pmd() On 12/30/24 13:18, Zhenhua Huang wrote: > > > On 2024/12/27 10:57, Anshuman Khandual wrote: >> However it does not really check the entry to be a section mapping which it should. >> Returning pmd_sect(READ_ONCE(*pmdp)) is the right thing, which should have been the >> case from the beginning when vmemmap_check_pmd() was added. I guess because arm64's >> original vmemmap_populate() checked only for vmemmap_verify() as well. So probably >> this does not need a "Fixes: " tag. > > Hi Anshuman, > > I agree, will remove "Fixes: " tag in next patchset Could you please send a V3 of this patch separately instead and not part of this series as they are not really related. But after implementing the following changes 1) Use READ_ONCE() as indicated earlier 2) Drop the "Fixes: " tag 3) Update the commit message explaining why pmd_sect() is required here and how the originally commit missed that 4) Update the subject line