From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E65ECAAA1 for ; Fri, 9 Sep 2022 11:32:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 822148D0003; Fri, 9 Sep 2022 07:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D2E88D0002; Fri, 9 Sep 2022 07:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A998D0003; Fri, 9 Sep 2022 07:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B7A98D0002 for ; Fri, 9 Sep 2022 07:32:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2D92A412CA for ; Fri, 9 Sep 2022 11:32:43 +0000 (UTC) X-FDA: 79892334606.22.89653AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id D1ED916008F for ; Fri, 9 Sep 2022 11:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5dH8rD5L6M9z0I77gljxR/cy6eNJfaXJvN6rfg8iFTw=; b=IpF1mIyuqrl6t1V3ldwq4sEC77t2kBb4Ecwaq+b6G2Ag+7zVsd84fQQGXQ2fX1NZqGGI44 tQxZZRDhq5FHV6XABcRCa639obmTlrEkUGDzkxInJLgRcyPDazIsZL/rfvnoFnGwzYATiQ 1idA4B7YDArVcagPXFdi8WibSDKPGgk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-553-gCXDzuxwMtefppEwrH-L0A-1; Fri, 09 Sep 2022 07:32:39 -0400 X-MC-Unique: gCXDzuxwMtefppEwrH-L0A-1 Received: by mail-wm1-f70.google.com with SMTP id n7-20020a1c2707000000b003a638356355so722525wmn.2 for ; Fri, 09 Sep 2022 04:32:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=5dH8rD5L6M9z0I77gljxR/cy6eNJfaXJvN6rfg8iFTw=; b=SMrw5jfYEPAvBi+8bJlvfaUErkvQUOCecMTNwagiABv0y/o1Za8AbA5nD5+NgFWO9c qHCLsXf0URQ5qNCmP1SRYLQbldyaC54/Ce59ouLTa+YHI0d6l4zGfcQ5xD8nBI0AOPhi RmUwM847qd8/YGcdcNqMBPLpGcgL7ulvaCvjEgN7tJGZV/DN6VJk1xWXlayoOcvTNlu/ w3+uPIFNujRcetqA/VrClnNe8ksg/KZejIPagezjvDBQ8Bcc6/D7G9egecysbLVVjGZB 30ixGC82f66gQnEw2wjGt6RMM4yM2wC2jg9xko9J1d7tP2b5mM8llJw6+sWnZbvw+a3i vrWw== X-Gm-Message-State: ACgBeo1/GNE3FzjALGa7aQ4v/eUdrfrYy9lzIvz1ektInio1UM1yGbrR zpsrju8tiAJCey8VRKiZ4j6GbTjT6l/GB+OKX9b63XyqEBOAKOj80TlkneWZMxjBuK8MZpVdJ0x coyjlkPNzupg= X-Received: by 2002:a05:6000:1865:b0:228:de57:f1c8 with SMTP id d5-20020a056000186500b00228de57f1c8mr7960301wri.370.1662723158378; Fri, 09 Sep 2022 04:32:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR6MItsI+H+1YabaJrFfrnc5NhFRGMdojAjSqaxzqEZzfxKBZad2gA8/HUE8X6nCBqRrpOwxQg== X-Received: by 2002:a05:6000:1865:b0:228:de57:f1c8 with SMTP id d5-20020a056000186500b00228de57f1c8mr7960289wri.370.1662723158096; Fri, 09 Sep 2022 04:32:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id m1-20020a7bcb81000000b003a4efb794d7sm340325wmi.36.2022.09.09.04.32.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:32:37 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 13:32:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 11/16] mm/page_alloc: make boot_nodestats static To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-12-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-12-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723162; a=rsa-sha256; cv=none; b=kn6RYe70oP85qG1mthijVqrDjBPPQkCedpSLkQO939qjvmQxQ4CT0NzrD2x8kfUc+I/IM6 zWwVImeA4BalcJyp686z3aCH/g7E/nat0fMtrtGAkMzZrC3nsA12AO6TSUQ6eqmO8GQqT1 83BE2TV4E1gmuoN4IksdFwX+L+FPRIM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpF1mIyu; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5dH8rD5L6M9z0I77gljxR/cy6eNJfaXJvN6rfg8iFTw=; b=hZNKo6w2EzxOrtHwXcN7gjHuV1+1+FQLM8AbcFlcRsWf1iz2mBpS8rmQikA/OQtcI0JjNJ ze4usLjYe4NflkSsPWwSBlqyJp8PMFmoR2zl3LF0aWLSNcyd6FVP/Y9d1Bx+Ud6wC6UJqE o1AkGgAX4e4zMidZcth8SwRI0gRmtTc= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpF1mIyu; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Queue-Id: D1ED916008F X-Rspamd-Server: rspam09 X-Stat-Signature: kp9psae1ttgxk9yxyi8njz311xzyezfs X-HE-Tag: 1662723162-795921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > It's only used in mm/page_alloc.c now. Make it static. > > Signed-off-by: Miaohe Lin > --- > mm/internal.h | 2 -- > mm/page_alloc.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 2424fcde6538..43a441d35baf 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -864,8 +864,6 @@ int migrate_device_coherent_page(struct page *page); > */ > struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > -DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > - > extern bool mirrored_kernelcore; > > static inline bool vma_soft_dirty_enabled(struct vm_area_struct *vma) > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3417232afa45..7a8a6bb08a15 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6571,7 +6571,7 @@ static void per_cpu_pages_init(struct per_cpu_pages *pcp, struct per_cpu_zonesta > #define BOOT_PAGESET_BATCH 1 > static DEFINE_PER_CPU(struct per_cpu_pages, boot_pageset); > static DEFINE_PER_CPU(struct per_cpu_zonestat, boot_zonestats); > -DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > +static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > static void __build_all_zonelists(void *data) > { Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb