From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65DA9ECAAD3 for ; Thu, 1 Sep 2022 07:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E918B6B0073; Thu, 1 Sep 2022 03:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E407C6B0074; Thu, 1 Sep 2022 03:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D08746B0075; Thu, 1 Sep 2022 03:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C4BAE6B0073 for ; Thu, 1 Sep 2022 03:38:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8AC2D1605C9 for ; Thu, 1 Sep 2022 07:38:03 +0000 (UTC) X-FDA: 79862712846.26.512B577 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 395D614005D for ; Thu, 1 Sep 2022 07:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662017882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/MJQpcPd8ilsE+iHuPOM0sBVZL0bmjk6Frq1r8jdmRQ=; b=eTRS3bLAQiMedJeS/gCTU8XgiHkCmjesYPptxj/tNnsZuoi+JiLDhxk0hMlZGWPD93mx26 ZDOBtw+/1FbdjfRkKmWXSHOMKf+V/iQYEmzLY3oGX/mqob8jk5ID9xEsRLVpwdxxzXThAi aCmcN/CbFZRm3hefaSqpYCOKYh3JvFo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-392-59Na0GNaMXat3LzlPCdKaA-1; Thu, 01 Sep 2022 03:38:01 -0400 X-MC-Unique: 59Na0GNaMXat3LzlPCdKaA-1 Received: by mail-wr1-f71.google.com with SMTP id u15-20020adfa18f000000b00226d4b62f10so2327325wru.9 for ; Thu, 01 Sep 2022 00:38:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=/MJQpcPd8ilsE+iHuPOM0sBVZL0bmjk6Frq1r8jdmRQ=; b=euY5c4xAQ2nXFsOkqCjangtDSKGgWBa7Vp5xqPZEgpgE8oxOVvl7CaSKJf8pmVHfa0 IQ2PYNwhdDBLJQU5UZL84jtyx7+mVS5pSKSQR/Fy0NgAycR4gqGLz6eDGZ3L5muCsrMh OS7xEfJZFtKciZDblYYqTPt/I16WnL5ffxBhnIdu9jYghS69aEqEdkvDvL+13Gd5ha11 SmkywOUCC+SVnWmnSjiaU/fCApha4NxYkmkf2BGbLVnrzE4D9U4ENCX6j67e+mQLFiDy TjCdZquXQHiEoiVOE+AcvNSeldIDcCNCyYuhGyNkZoyHTqsfFlE1S9O8wxOVIGu81pWI DeAw== X-Gm-Message-State: ACgBeo1NhNG4uAZEe2AvYBW0WYvJc+LJEUNaFXKJpJsuvW10rarLWaST eCbSk2sjSiEdK/AIQPlgYL6vFZcZ7o4XPPquiBMYxLkaklBvpvnKuT3Y8XbTawobI1Kth8njfrt bTfzDDRFH9aI= X-Received: by 2002:a5d:684e:0:b0:220:63df:3760 with SMTP id o14-20020a5d684e000000b0022063df3760mr13050000wrw.508.1662017880481; Thu, 01 Sep 2022 00:38:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR6uAAlaEbliOr8SEscGeiKdIVPCDI4GZRY0wtVuL4pwMDIZvg9GHwC4eItvjQFlTCKwU7FAFQ== X-Received: by 2002:a5d:684e:0:b0:220:63df:3760 with SMTP id o14-20020a5d684e000000b0022063df3760mr13049988wrw.508.1662017880199; Thu, 01 Sep 2022 00:38:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id n2-20020a7bc5c2000000b003a5c064717csm4402765wmk.22.2022.09.01.00.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 00:37:59 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 09:37:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page() To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org References: <20220901015043.189276-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220901015043.189276-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662017883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/MJQpcPd8ilsE+iHuPOM0sBVZL0bmjk6Frq1r8jdmRQ=; b=vMZxfVUo1C7N0TIh/caRcd1xOfnN+hHAPkSTA0mS11l9cB0okyeI/fpZ+RLQz1EhctQSfA DCe0M2WPFT/uvA/7HAr8BWOSMqREHgtmV24XnG+1WXZEzN1b5two1oSMDMowZ890UkyFIJ S7a54eP1GRueETBx0R+hXtapmu8/jds= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTRS3bLA; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662017883; a=rsa-sha256; cv=none; b=Dz94qX4VTkCE35cY6aOeyM8pGblY0xaX1D1EQ1vSork4dfEPyFPB9LYJmr/pgI1S6/O+Bp uxZwrrHabgsKeK1udkxS3QRPCIoYbCxdhp7YcnjCyu++YT4TslnkUXOr+3P2mKP3OLXkci WXOSw02bKFtTFQB+lGiJm04oOX5qs1c= X-Rspamd-Queue-Id: 395D614005D Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTRS3bLA; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: i6fcih4unfy6u1t8gkt5iy9g8kup55a6 X-HE-Tag: 1662017883-937734 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.22 03:50, Kefeng Wang wrote: > Drop unneed comment and blank, adjust the variable, and the most > important is to delete BUG_ON(). The page passed is always buddy > page into __isolate_free_page() from compaction, page_isolation > and page_reporting, and the caller also check the return, BUG_ON() > is a too drastic measure, remove it. Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any value anymore. -- Thanks, David / dhildenb