From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD81C27C5F for ; Fri, 7 Jun 2024 12:31:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E86AD6B00A4; Fri, 7 Jun 2024 08:31:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E10756B00A5; Fri, 7 Jun 2024 08:31:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89756B00A6; Fri, 7 Jun 2024 08:31:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A6BA06B00A4 for ; Fri, 7 Jun 2024 08:31:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5302941927 for ; Fri, 7 Jun 2024 12:31:10 +0000 (UTC) X-FDA: 82204027500.23.14817F6 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 4BB9A1C0023 for ; Fri, 7 Jun 2024 12:31:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FSB1yFFN; spf=pass (imf18.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717763468; a=rsa-sha256; cv=none; b=8Lk7FiTjcoqOTJ49HN6BK0Gc50AqRolqImz8n19vonjcYBPw71MUUaMhVrc3g8ARmj0i1T ssjBYy4Cj43XM0owsRRm/PpIWtpBEahXZWsLecTQv1zcyGMRkSzLg1ltyCaT2sbbAJ/wjy M7b6/mhwD8bfCk22RawS0dG3DbOJCrE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FSB1yFFN; spf=pass (imf18.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717763468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N0t9qQNDQyMfGhvDGBq4R0rinqRtCXO9/OSll4uI/+M=; b=B9WQtYa95DK1TARiEPtrhpcQANRiBiCuQK/VrehYyxXd/iDMjcklaoyDZCywNRhOCVnyIH 3AhAiG8QAMnmNGSF+YgkSf3Hv0girQPCH7LM7eqid0qHQawd62swB3OW1o+uZP9TIvskdK Fs4qjtYf7n/diRyoq9d4fK6TU4NMWg0= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57c5c51cb89so566863a12.2 for ; Fri, 07 Jun 2024 05:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717763466; x=1718368266; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N0t9qQNDQyMfGhvDGBq4R0rinqRtCXO9/OSll4uI/+M=; b=FSB1yFFNDU4NIgcsZpvwIlTTU6TeX9qfqzYE8i5zi2zMUtWC3Cw3O82GYmfG2i8t2r rgwKaJl02XuNAqYw3Vmwlzdac6nSh/0TrsW7+b4d3hUXmxmxkLP02kUjPh/e7t3CbPfJ sETuTx2axY7/ej87jaRt/UztwWwHKmo2wQoAUuLFgt4AidM0gnNWCT8Lqn+MF1cCFGon KRwNnYJnMNvm2vmK6kN2DSlsIYKih28NoDquUfwCoKUli/qZ/9Kv7W4WOGiwDFWlrJ3/ IZc8uC+YrFmBoX9GAPDbs7OybGk1q+1Gif3mAuSz+zjAr3TPNvgTnrCBgzSD0wtONa1+ 7GPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717763466; x=1718368266; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N0t9qQNDQyMfGhvDGBq4R0rinqRtCXO9/OSll4uI/+M=; b=Vo1/kywRRLqpchcyZXQc8Zvm/Purw2fEUFX3dd+TJx4mNp71iqucaSH0VcUaYeDdTG +lcxfUnTWnPM50A0VPDXeeZ0AIFHRyGr7ZGP4wXPPuPleNiTDdhKz1yc0LqLhk1S7TGs i7+nJO9usRxUU7gdto3lJb8jTDWu8X0ezOIIH32BGji5Zw4RqB7+FYwPjblrEyio0nwM GY2bjNCcI5KGoElR6Iok/bdktAuVQWeQg7gPd/Z4bGGnNFTLJvRAg31K9Vfgg9BrWW3F 573RELNi+YIjAKhnZ6Bwnupap8cr++wxODlAcUk++eMhrM/2von405vXC2WQRTLuNWyv aaXA== X-Forwarded-Encrypted: i=1; AJvYcCWM2rfR4ZKR1PFGBYwrzjGKzMmgRhlU6TUKpKQliDPRzxZBecZgPEvqzTRv/505IqtCOuY6V3RYRhOx53riWbXVjVo= X-Gm-Message-State: AOJu0Yzbg1jwWhnRV/moe8I4ZawF2zRXnm83XPHEskJqTXfuNEvV3Vx3 w4LD/KGWjhr4s81n7XBaz2mIdniut+y8ZtsP38PEUEqycxntGOj+ X-Google-Smtp-Source: AGHT+IH5SNInb5yZq3Cuj7U8oACNWHmzMuuF2G63X2k2tjaQ/s20PtWq1uTiQglncTLckDH15vmQlg== X-Received: by 2002:a50:c181:0:b0:57c:5ec9:f5d9 with SMTP id 4fb4d7f45d1cf-57c5eca001emr1193325a12.31.1717763466203; Fri, 07 Jun 2024 05:31:06 -0700 (PDT) Received: from [192.168.42.93] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aadf9d8d0sm2682019a12.8.2024.06.07.05.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 05:31:05 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 13:31:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v10 06/14] page_pool: convert to use netmem To: Steven Rostedt , Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox References: <20240530201616.1316526-1-almasrymina@google.com> <20240530201616.1316526-7-almasrymina@google.com> <20240605214837.44efcc6f@gandalf.local.home> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20240605214837.44efcc6f@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BB9A1C0023 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: pbjdwydpm69dse46tqrnytinoqs66ur4 X-HE-Tag: 1717763468-591293 X-HE-Meta: U2FsdGVkX18UiAZ+ILazb5XRwxqvJdktRJgTnE2RYOJKDLtp9VGWnFz3VA8we9nWr8uGiXTOWefmfOGQy+AZoLiupjQjBfY0LgblzKjBu7GCulQp9MCpsanfKddkJ4Uac+xRCgFTZSBfOfY8H7ymt+iKr8iQ5TKotGL7Jj/Vs4BLDuNu3BIPrsXEHhKf2uAUFv5BW1iwPJ7qKm4ANMVhxLMCFs0Dz5ySN9CrlifenicJ9J5AWGiCVq1V/yiQ1gCkyiqSVFYm5ACxNV9z82pXTvoVV9GpQBtilaSsXn7hmwGuIl5dvzAdfWJT4PUswGymCjq9EA0uUrP4ptjyR+JNQ8e4YgDyzlGqkyxM51iuzlZ6A3bdLoRkPvTifRdDzmRlFs+oZdxfxRSR7iMYZ3zAio6l1Jx7WCLNNKxCXf+1WEal5acCYFPo2WtK9SaRiAsQiTxy6SEF/dOcqkzHRTbK4Byck0iPpHmbVdcTgbcFa7L8BAn0HzwkbYO+LoF9AZIM9jOrEffI0U0xcxlDchOl/d44Hlt8TOzrPpUtmF5KeWH+dbNKoAqCbZgwIJ5HIAwAphvlhBccFbGFUDh50/S8FqtlYf7cBm0vgRSTufVmNlWEAhKYMTblL7Bl8uDO3sPzTfWw4CalWjVcROxdyTcaFf+PlMn2MBLkiIdsRmufv+l/Ev1Mh4SAqhQMYZ5A2Eh7+JGo65BT+D5sqAp7wzy6buaY9kbw/uBnIWyr/H9yH0hMDQiS4D7upCLUyI/T0r4Wr1181R2AFI6Vnwo55KXpmk1k0aUg9k+LT+CjHt7HmPJikzU5P/2Gaeb3cUQpfKSG1MHpeG12vYerSx4PYr0xd+EaEew/JkGjoXye0tYEUF07wtD6Q4TWpnEWoZLQSKql5f1EHTIGNDXLBcdQ/fbQB8Pc39qHcaBuEB7WJYEN5XR5t9HxYdcEnAhcL8VZG6NW6Rf6nvQQLkskj93eVb3 c64uTnRW /qLboWTxEhBO4G/b3nKenCpVKt2RZKmUj+f8sRaj6oYeAtjTMynx8WFhUq/CSfQd/IJI5R6DyWu5jAXzgWgROKnXMu7vGyw5Q81D5nKa5dEm+MraLM9BBZSB2DWws+uf76hEvaN338I8doSiyRKeSrAZJj2iPQJOmDjEK2SRB5D/aSJ1LwpwOWD5P5tKvRv5uiNffoj0jDkWHabVMnvvIkT8BilzehwQZ5CC/chnzMDIy9Qe1QGQKYYaskj465SpVnYDA4ZipZo4Ayx5lACFJxAajPm32uH8iCFkC6oPnuyOIAtVRjwZH99iEjC111T4pp7XOXKHv1RZ1srAtHzXnIhjw+Z/T74zhivmEK/Xz8dPFA8LZl87BmZdKiGsZGccytiOVf3SP+J23u9KDvKkT1Jp0q4wuLl53GpO3tfBio4QZ039lG9xGMONnMWcXz8gXDfETaudOcWS2k5Wn8Mc3tBnPTx0ZuAOydhoosH7tElqR3DFbiIMNw2iVLDLivQma2zHFgTf91OI8h6JNChwroKsJEiZTGB47uclOcIaNwVikIr3ZbsXcFjo3Gjo0e+4dw0JMs5nti0h3RE0hmCSIO0R3Kr3+y3I+/R3TQMlD6QZ931gl23XaDhdr9LjFc304aW6TUg7PK5fEQrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/24 02:48, Steven Rostedt wrote: > On Thu, 30 May 2024 20:16:05 +0000 > Mina Almasry wrote: > >> @@ -42,51 +42,52 @@ TRACE_EVENT(page_pool_release, >> TRACE_EVENT(page_pool_state_release, >> >> TP_PROTO(const struct page_pool *pool, >> - const struct page *page, u32 release), >> + netmem_ref netmem, u32 release), >> >> - TP_ARGS(pool, page, release), >> + TP_ARGS(pool, netmem, release), >> >> TP_STRUCT__entry( >> __field(const struct page_pool *, pool) >> - __field(const struct page *, page) >> + __field(netmem_ref, netmem) > > Why make this of type "netmem_ref" and not just "unsigned long"? > >> __field(u32, release) >> __field(unsigned long, pfn) >> ), >> >> TP_fast_assign( >> __entry->pool = pool; >> - __entry->page = page; >> + __entry->netmem = netmem; > > You could have this be: > > __entry->netmem = (__force unsigned long)netmem; > >> __entry->release = release; >> - __entry->pfn = page_to_pfn(page); >> + __entry->pfn = netmem_to_pfn(netmem); >> ), >> >> - TP_printk("page_pool=%p page=%p pfn=0x%lx release=%u", >> - __entry->pool, __entry->page, __entry->pfn, __entry->release) >> + TP_printk("page_pool=%p netmem=%lu pfn=0x%lx release=%u", >> + __entry->pool, (__force unsigned long)__entry->netmem, > > And not have to expose the above text to user space (look at the format > file it produces). > > It being of type "netmem_ref" in the ring buffer is useless. netmem is a pointer with one bit serving as a flag, considering mangling it might be better to %p it and perhaps also print its type (page* vs iov) separately. -- Pavel Begunkov