From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07269C433EF for ; Sat, 12 Mar 2022 13:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152A38D0002; Sat, 12 Mar 2022 08:09:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1028C8D0001; Sat, 12 Mar 2022 08:09:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0BD28D0002; Sat, 12 Mar 2022 08:09:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id E2B898D0001 for ; Sat, 12 Mar 2022 08:09:22 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A6247120A for ; Sat, 12 Mar 2022 13:09:22 +0000 (UTC) X-FDA: 79235765364.02.6B9A8C3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id F0F021C0027 for ; Sat, 12 Mar 2022 13:09:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 43E491F38F; Sat, 12 Mar 2022 13:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1647090560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/rDypST7vHgO9YGygPYsdyXk0mmoD/4eH6Om3TjYeYE=; b=ZtgOSS6t3Ue+6wmUJRXBiBa8KTzizrF6C1R2OcKx666r2zhx85D7h5d4hdrTayM3envDrK zjslz+sVVJA5TptlfvlAay0TKZ4oSL2hYS7J1PGHAJA2+Izh0XDsKbR7eOFye2HACBGImi XuzaT8igttpQFG7/SrMk31qebJynobg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1647090560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/rDypST7vHgO9YGygPYsdyXk0mmoD/4eH6Om3TjYeYE=; b=Hb9fGLpHUPCvAJp6m6x+ltGyRUN+dqY6TzYCLUsySiwCfe/VbL1bvGjXlL+NhmTEZ3sc+G ef3C7u+/vdm5/8Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 19B7813AB8; Sat, 12 Mar 2022 13:09:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 932eH3+bLGI8dQAAMHmgww (envelope-from ); Sat, 12 Mar 2022 13:09:19 +0000 Message-ID: Date: Sat, 12 Mar 2022 14:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [mm/slub] ae107fa919: BUG:unable_to_handle_page_fault_for_address Content-Language: en-US To: Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: kernel test robot , Oliver Glitta , lkp@lists.01.org, lkp@intel.com, LKML , linux-mm@kvack.org References: <20220311145427.GA1227220@odroid> <667d594b-bdad-4082-09d5-7b0587af2ae3@suse.cz> <20220311164600.GA1234616@odroid> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F0F021C0027 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZtgOSS6t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Hb9fGLpH; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: 4zphysrxp7u4oh46oszdyz91kfe3zdiw X-Rspamd-Server: rspam04 X-HE-Tag: 1647090561-518483 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/12/22 13:06, Mike Rapoport wrote: >>>> Ideas? implementing something like kmem_cache_init_early() again? >>> >>> I think we could simply make CONFIG_SLUB_DEBUG_ON select/depend on >>> STACKDEPOT_ALWAYS_INIT? >> >> Oh, sounds better. >> >> If we make CONFIG_SLUB_DEBUG_ON select STACK_DEPOT_ALWAYS_INIT, >> that is simple solution. but stackdepot will be initialized on >> slub_debug=- too. Valid point. >> But I think no one will set CONFIG_SLUB_DEBUG_ON=y if not debugging... > > If memory wasted by stack_table is a real concern, we may free it after > parsing slub_debug or add a condition taking into account > CONFIG_SLUB_DEBUG_ON and slub_debug=- to the > > if (slub_debug & SLAB_STORE_USER) > stack_depot_want_early_init(); > > But I agree that if somebody runs a kernel with CONFIG_SLUB_DEBUG_ON=y, the > goal is to have slub debugging on, so making CONFIG_SLUB_DEBUG_ON select > STACK_DEPOT_ALWAYS_INIT totally makes sense to me. Agree. We had to decouple stackdpepot init from CONFIG_SLUB_DEBUG because almost everyone enables CONFIG_SLUB_DEBUG by default, but on smaller systems doesn't want to always pay the price even if unused. But I don't expect anyone to enable CONFIG_SLUB_DEBUG_ON and then run with slub_debug=- by default, and complain. If anyone like that exists, they could also add the stackdepot_disable parameter. >> I don't think making CONFIG_SLUB_DEBUG_ON depend on >> CONFIG_STACKDEPOT_ALWAYS_INIT is good solution. only KASAN selects it. >> >> -- >> Thank you, You are awesome! >> Hyeonggon :-) >