From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3FFC28B28 for ; Wed, 12 Mar 2025 12:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C547280004; Wed, 12 Mar 2025 08:55:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17292280001; Wed, 12 Mar 2025 08:55:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A82280004; Wed, 12 Mar 2025 08:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB926280001 for ; Wed, 12 Mar 2025 08:55:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF9A01610B6 for ; Wed, 12 Mar 2025 12:55:10 +0000 (UTC) X-FDA: 83212894380.24.5588DF0 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf07.hostedemail.com (Postfix) with ESMTP id AAF6240007 for ; Wed, 12 Mar 2025 12:55:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZIO2PTUw; spf=pass (imf07.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741784108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q4gPyi4FZZFwvRtlGe5MzJLQjJpIeYPB9yg885XBwy0=; b=TD36Dt0EdW4D+yBzvv6EiacL5P9nf3JuR8ih5NhRCfri8h+eLaai51zIJX3Am7KtonQvnK p7GjvDSZwRbe793hd01S4TvZ6POfQbjjkqP8qsMtsgHHiI8whtViCieqiNbO28SEywAjs5 p4NUJB9ej4fIbYom8nfyLInm6nqFACk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZIO2PTUw; spf=pass (imf07.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741784108; a=rsa-sha256; cv=none; b=fipGnqzl9UeOWhX7bR6H7g0SuSZzkpEilctWmjz8ruCSHDkA8fEJeaF5RtJzWlOS0YlRaV uOSc+OJShDOUqToMTSEDVjhz6gYNGsD+ou6jVEADHU4qIHkGmOFaVPZ8zw/zlXLEqHN8ZA sFN2kLFODc61qvEBZHu1tPOg0lj/Nls= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-38dcac27bcbso526695f8f.0 for ; Wed, 12 Mar 2025 05:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741784107; x=1742388907; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q4gPyi4FZZFwvRtlGe5MzJLQjJpIeYPB9yg885XBwy0=; b=ZIO2PTUwemk+5ifGbVjnHcRISbNf1ip5M3Ksq+YxIOIVXqmMHQjiqty19ujTiHMbQp Qm7YW53qDkQLB078ntYsfaUFLetzwhh6na39f7BSWIszg76r9QrGBf/jNEbSaL+fovEq t8DQTBiRStmkg6jYcR8wc+mXdQPfpOnlSUADs7XbXnl5y4UH8/+N959TGNlkGxE1oobi O7vf5SbwKfPD6nq6lOc5gZGuOCOz7hYnqMTPjNdZJQvdwA/BzzGvLPjgtuv4y4PDZwGq FaieRpU+llpOrI/IoBZR9lPklGO+IxbBU5f7pXdwe+kfMwjTM9pltzuVEqtAhQJ8BZR5 ymXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741784107; x=1742388907; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q4gPyi4FZZFwvRtlGe5MzJLQjJpIeYPB9yg885XBwy0=; b=O4fwEc4GrsX98808Oq76Bm2aBsCXuHKHU+pSG+TZkMiyUMU0aFK3l6dkv6OV/n0iYu oeVHqHFTrs+CyXOYSNMcpzuxUdeHWZqEdS6uE6SapYg3V7bUjhWWs3mocEgt1wBTZ/iB WmxTutphqyWuf4hKTv1z9vcS3g3Z2Zf0HtB7PTJu/1SOYo7V+E9QoX//s4TBw5C+lc+Y viiA907/xlbWaOJomsSPYspdOmYMoiuQMOuJmfNWsv6Khup4EgPHXOqTCnUZnCVoiV3K Q3E9J+WtQLM2FvEg0FmTXHuwI3arSbwhrVsenLyYXiqifPsnvyWnn2Iyk9ATOtD1M/mD RSSA== X-Forwarded-Encrypted: i=1; AJvYcCVVpMDFfCTTAaJFPuu7EuXq9/WS3WUgqxS22scLQugxUYHBk9tAcWOT3wC4mtGsSg5dYVLABUC8/w==@kvack.org X-Gm-Message-State: AOJu0Yy6y8KO9amDCt/6hlGkBOl6/qBavxZrElAxPCHGC+94fUx/CZoC rpj69fGmiVbSiKBC818PISHKR4acTQ1+5Snx3wGmXfvI/Pq3Gaiw X-Gm-Gg: ASbGncuFkV84snOaUrdlFdiqTKRVYCs0CE6XvjyOWcaP2CJ0Jgfvno/A0ZDSoU1HXMe E7vBeqM7GGarmTGQETtyvQOXVya622Zy0SYA4sdxLO66dDcmCtwfU882G9UzIEOwpLPROrR1ar2 sP29mso3m07x+r9N62ckDXYtw1iOQ5sr+0/0ObM3TGswD/sn+YVnovk1K/1hTeYcpInMw8s5k1a TjtnRLwe3ywWgnuKJZF9EUAM1fxdxdPhhJBcUJ+fPDdSrcxVuvYJTedA3/VFkYKWOvUrdY3uPIo wUAo0NDWU5KmQBc+RnSnIp0waHHZIEehppF9PRci6u8KtebOlVAnvTZxCA== X-Google-Smtp-Source: AGHT+IFR3Rb2grZMDNG/FG7ThrCX73kNYbrZrm3oOz4rnrivx9Eh09Z0OPa03401c9Z37iby/jGepg== X-Received: by 2002:a5d:6487:0:b0:390:e9e0:5cc6 with SMTP id ffacd0b85a97d-3926bdf5c18mr7406230f8f.1.1741784107046; Wed, 12 Mar 2025 05:55:07 -0700 (PDT) Received: from [192.168.116.141] ([148.252.129.108]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfbab43sm21390829f8f.15.2025.03.12.05.55.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 05:55:06 -0700 (PDT) Message-ID: Date: Wed, 12 Mar 2025 12:55:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next] page_pool: Track DMA-mapped pages and unmap them when destroying the pool To: Matthew Wilcox , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Mina Almasry , David Wei , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Yunsheng Lin , Yonglong Liu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-mm@kvack.org, netdev@vger.kernel.org References: <20250308145500.14046-1-toke@redhat.com> <87cyeqml3d.fsf@toke.dk> <87tt7ziswg.fsf@toke.dk> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AAF6240007 X-Stat-Signature: pmr1it1rj7s373wtcb3rdnt5h1y1ocfn X-HE-Tag: 1741784108-685882 X-HE-Meta: U2FsdGVkX1/5S8jdUPRmD+i1lERDzfFJppT88iw5pxo90YAG8Ipao/U5dxOVtzLmqXHschUQuENg9LOO2FkV7pIzzr4V5hbESy0PpZ53p7GX+mzoDps/Q1xFUs/NSq6THq+GbzJzpdes6ajm5aR3xotC8LrxLwzCD9Sb8I/m+L9dLTzrdSosYviSOejHwe3aUdswPIOPeHCWcK1BWThmtKhG19smY7tLFy87WGv2pBhDmHp5NYqFajYi4HvRP0KTLkzSsG9Hjue/HprItF1lOEitg2xSTgRMfa3mCpPS+0mS1xCiYJgL1Qi2c2z5caYoT+aQFIraPRVPuo7hFY7APzu/RnENn/9N45hHZaMnkZ9lxa6TRfG3raLHsqIvAtQCOSh4GqEgp5wNqWm4sZytxQNWdyBfwfjSucxKwcKRVo+KlBpbsBsGy8+yF+DQenDCTBpaOctGvtjlB91nXS9HERu7obU1HARJMdO19p2u2FA7eyZJXCTDB4JCWxbcnzzAooXPd7TPOoOfxrGyMZyg8L1QlIz0OULiT05rEGPw6sBsGTG2ugSbKBHwbiMleGNurvGVR7me2m8r7ZQhVxozosRQHOk8nKvsj2sNMNAHBXtDOGFj21WFS/2Nuu1vCYM6vxnsct3aMHDDcp3pbctCZWKAKD9C+DtifzGlGVtm4Oa9UO8ABPs69z8g+5z/68kRfcZOiOxDe5XLyIvX2KA+bW3RStSQesodhVcznYvhwdsVWdmG+lxSbFu52th3pb2as4HfGfwvLWmdIcqbKGfZc6FbXuZMcRRPlj0D8AKvjbweoyWtaLyKuUnEDqtpnA0fs0jO0gjiJz+5gbHx+sYTEuTHYQJMb7QQFCwy1klD32uh4B7B/ylxiu4+ngdshLOGXCJEcUGScnHI2rLDPJ3LfNYVCYQidCriz9xKIm3kKbLwL+M3ci/5ZEGpTYWVDyqjNhUHDqyhvfOccIFMNt9 XD9NJZg+ 9vUUuoaeVVNqbdN8+panpov59vdXJbeLTCZbPFS9wZpOsVQRfEdiwSdeTwTSVzVJmAgNRGD55wb1m+tw6bwNxMPXmc61WmKifl589he1Im2aIDH5ic+plcyO6LwXmpmYR5H16M32q473wmjgxo0CbHGUqopPUL1soeIDkOv8wZV6DndyGTkX1Cd9IikFHESdTeygFPCl63qs81AQXLVXxX/JU/J+pD9Iwa7PxdP9MkOe174Q1Z8pz+HspWVnGS0fjxLDRdy4UldJD9vIcPkTXngwh9lcHh0dy/5qH/16K21b95EryjIbtEEDlq6lOK6acJ68yC8LkZqOkLlGbp3EjdFuB4nDRbf2dKwkPoXFLh3Hn8PHmxix71m612xqXhfmm0lGK3SZ8P2DwH5MR+fUsYcQvg0R545HaQNTiSNlY15VjCK5HbM7aNxNfbOsgrXvigolfdNb3JUq/y+/AhTpgwnqGZ9ZSS1s95itpGIr7gPBeadaytSzqgTzihLwlJSzZZqNaZthQfocbGpDaFhYuhYpzrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/11/25 16:46, Matthew Wilcox wrote: > On Tue, Mar 11, 2025 at 02:44:15PM +0100, Toke Høiland-Jørgensen wrote: >> Pavel Begunkov writes: >>> If we're out of space in the page, why can't we use struct page * >>> as indices into the xarray? Ala >>> >>> struct page *p = ...; >>> xa_store(xarray, index=(unsigned long)p, p); >>> >>> Indices wouldn't be nicely packed, but it's still a map. Is there >>> a problem with that I didn't consider? >> >> Huh. As I just replied to Yunsheng, I was under the impression that this >> was not supported. But since you're now the second person to suggest >> this, I looked again, and it looks like I was wrong. There does indeed >> seem to be other places in the kernel that does this. >> >> As you say the indices won't be as densely packed, though. So I'm >> wondering if using the bits in pp_magic would be better in any case to >> get the better packing? I guess we can try benchmarking both approaches >> and see if there's a measurable difference. > > This is an absolutely terrible idea, only proposed by those who have no > understanding of how the XArray works. It could not be more wasteful. Which is why it's so great we have you here, not every one is developing xarray. So maybe it is useless for this case then. -- Pavel Begunkov