From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F979C3600C for ; Tue, 8 Apr 2025 05:48:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C93280004; Tue, 8 Apr 2025 01:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0AF1280002; Tue, 8 Apr 2025 01:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAAE0280004; Tue, 8 Apr 2025 01:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A7DF2280002 for ; Tue, 8 Apr 2025 01:48:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 020F3B835E for ; Tue, 8 Apr 2025 05:48:30 +0000 (UTC) X-FDA: 83309796822.02.35B224E Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf25.hostedemail.com (Postfix) with ESMTP id BE9EAA0005 for ; Tue, 8 Apr 2025 05:48:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf25.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.236.30 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744091309; a=rsa-sha256; cv=none; b=aEPuhju13C+0v5+0n7q20QXpT+9Q7APyPKVtV2/pFJP57WMnkSerHynC3NyJKtXW/mqFCK 2dUHrVpVE0x1RIHETav2VsquQpEofiDo3u15NuZv6vqTV/hTktZOEyeitrC2tx0tpc5ci1 9p/s2MAKZmbQa/7acYjFvCbYAM5Knjw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf25.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.236.30 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744091309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZxMGG04EPMAWKey8j7JhNalgvxUnjwJSpyC2cpoCPyA=; b=zGqdI3Uliy5DY6AR0m4BWIBZpIdZoAN0P8r23oHXQecruyMJMXhkNkmq9u7UJwHrIUGdPz q46X9kwECJizbhaZ7TYkEV0mIQQoX2Bm0PAG7CZsPIGaLC9PAOKUVDMVRkjMhgUTG8TUF1 N8aFjqrY3d/DzLpn9lmNVgAkgQtF9uU= Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4ZWw9P60QFz9vkm; Tue, 8 Apr 2025 07:48:25 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 42ojJD_HJEii; Tue, 8 Apr 2025 07:48:25 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4ZWw9N2JlBz9vkp; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 369B28B76C; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id aUNb9W1lbxmx; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) Received: from [192.168.235.99] (unknown [192.168.235.99]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DC9078B767; Tue, 8 Apr 2025 07:48:21 +0200 (CEST) Message-ID: Date: Tue, 8 Apr 2025 07:48:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM From: Christophe Leroy To: Mike Rapoport , Andrew Morton Cc: Alexander Gordeev , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Dave Hansen , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Gerald Schaefer , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Jiaxun Yang , Johannes Berg , John Paul Adrian Glaubitz , Madhavan Srinivasan , Mark Brown , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Will Deacon , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20250313135003.836600-1-rppt@kernel.org> <20250313135003.836600-10-rppt@kernel.org> <4b9627f2-65ff-4baf-931f-4e23b5732e6b@csgroup.eu> Content-Language: fr-FR In-Reply-To: <4b9627f2-65ff-4baf-931f-4e23b5732e6b@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BE9EAA0005 X-Stat-Signature: yxq8d5unwjmnswam5mbbps779zjit1ot X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744091308-109722 X-HE-Meta: U2FsdGVkX19ngieZ/oVyIzOES5705EFCoRYv3eoi6y/D18rJGdYtUKj/wu+ChEW3GIKPqOgOy3eDTff6OcDVCKZKnF1AQs4oZ/G5ouzJltLPxFyg//56pAtZzkv8jo9b2esY2O41mS25l/p3vMsSfv38fbqvyGMQwaK4rltUJQk7W1vd+X/lzSKgxCxek9cp8RxntM5nSxlnvQJuseWe28eIaHqpd4v/FDSq+UKZAbVMAmQGcFFM5QxAA/FZuA+wquX+aFPAnM6sTxOcyEm0ns5b4gcf3rCKT4wyUagwR1FauKAMZk7pzuF9h/LwV+VH/t4L+q5kkhI+dhN4NjBs5SFdpZRjTw0D6UqD7x5adgUEsHfvttnTFnShzZumiIdoOtIgSH2M9cB8OMj90Wb1Cfr12mdZ7zmqQqr3Um0wBbt+t0apxkZwrAErVWaeJ5dIOJI38qOYrVdPR794HrzEIIdazW4ccJRyR2TSrfs+IbLnT0c7lN70LCNFFFNBylVf/c45goGNd6K8O12VM/X9crm8hinrAdofIpoWDw7gb2DJa+iBzQ6PMxGGmyPeSROojPZ9aU5cbKIUZDLO1zS/HTw8tC5c9VLlypGqrI/MMYSPDEBOyHnamWQBqBn/+uEiWzPUy1Ty8R2zTC9e709mnEzEvljZ/lBu443YTa3eJ5QhDZuZFz3TqDil+GVTRc4fXxcrTybWQVpvGtY3rXRud8Zy8MDC/neMDhX2/kggBMX3EhSJBwzRC986tKRKEptKtdcQsbWZ/+7K/ykvhl5FM7iwkh0Gck9tAlwXT9k893G4NvnzI8nKOgt9tcQV8vCw701nw3vu3JNNr0GuPhO3OotplVws38GTgo+APZWqsGBncU8ZeVYG44b+Uucfpy7PVEE5boO6azQlu+iZ3SZYU49s/yDaxgTwDAgLGoTMpJHYi2dY4Ua6vxksSp/AduUO2fvT/cSFXALaw6GyMbz 2BLGiPgU iDKEQyTpZiSwQXkqIrWBzaXHgU6W85dUO7014uTCRZP0IHGD15E+TMDexqy8Kv/unpGHQT9I5E5iWmWwYT1YpP6AOGqtlfMl5aLGHXMP/owU+d8XXH8ubpx2+xBd5rVR+HTVzPjLf5bDV+LW8mAyAdWSAyxg2nUCIZveVpTJakzHtZWIvIqiOArGLnbM4B7Byx4Kr47dB6mqrypMQbZKfH+nSKZ0CPBtOI8d16pmqV5097d63XvQ/68ndYGqVrZMsmUj4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mike, Le 14/03/2025 à 10:25, Christophe Leroy a écrit : > > > Le 13/03/2025 à 14:49, Mike Rapoport a écrit : >> From: "Mike Rapoport (Microsoft)" >> >> max_mapnr is essentially the size of the memory map for systems that use >> FLATMEM. There is no reason to calculate it in each and every >> architecture >> when it's anyway calculated in alloc_node_mem_map(). >> >> Drop setting of max_mapnr from architecture code and set it once in >> alloc_node_mem_map(). > > As far as I can see alloc_node_mem_map() is called quite late. > > I fear that it will regress commit daa9ada2093e ("powerpc/mm: Fix boot > crash with FLATMEM") > > Can you check ? I see this patch is now merged into mainline (v6.15-rc1). Have you been able to check and/or analyse whether it doesn't regress the fix in commit daa9ada2093e ("powerpc/mm: Fix boot crash with FLATMEM") ? Thanks Christophe