From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF9EC04FFE for ; Wed, 8 May 2024 07:13:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B1906B0089; Wed, 8 May 2024 03:13:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23B596B008C; Wed, 8 May 2024 03:13:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066FF6B0092; Wed, 8 May 2024 03:13:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3D176B0089 for ; Wed, 8 May 2024 03:13:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7B7F4120D59 for ; Wed, 8 May 2024 07:13:00 +0000 (UTC) X-FDA: 82094361720.15.0E348A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 41DB6120018 for ; Wed, 8 May 2024 07:12:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IbL5Ctkq; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715152378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6rW4wJ33EkBWxqc3YAFkR2q+QRdmV4hBDk0pwGvIydY=; b=TYuwYtQSJy41LwA8NGqV4rBvgeKUkl7U3uo3icZ8W+QoArzA/HAcnJZrxYj7pXPgLGWjS5 MMXlr8BucPFtOQ4NQBYGpsFJvftdQ2fCUeI0vK1a3otwviFc5CuZEui5E+CRHCf55aq7sr sCikSgb5EVvLSleYtG07Adzk2vGpr+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715152378; a=rsa-sha256; cv=none; b=xW5cM1ci5yp3eH3EMzWKQbjyh+QC6vxEzqn1Fg8zrPvZAKAbB1ZjayeHZDjk4m271JOD7r 3/3aZ59rTwvLOp+Y2KuZlLf5/ohBpz9+LW4BAr/+cDSjQT6cTDlWHCSJGkojCBfdtQShUU d9Sjm3zrBAXqrYC+qWRbIPlmtI8Ud5c= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IbL5Ctkq; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715152377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6rW4wJ33EkBWxqc3YAFkR2q+QRdmV4hBDk0pwGvIydY=; b=IbL5CtkqUJ4F98dMY11or8pY8btBF2OCOPHH3oCMs8SUkMNDvYsuGNWz5LSsJ4uUScyfIv NQDxCGzvtqb/euBFoSJlifdwBFBKxIQZshjeODwWIk5s/r+XC8dcbaLDPxJ39wMjYZ3Sf4 Q+acyHa/mbVBJCqkUkMLP3o3HJoiGqc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-1gbHwrJ2McqaEMs_thKTWQ-1; Wed, 08 May 2024 03:12:56 -0400 X-MC-Unique: 1gbHwrJ2McqaEMs_thKTWQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-34e2ac93f8fso2398558f8f.3 for ; Wed, 08 May 2024 00:12:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715152375; x=1715757175; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6rW4wJ33EkBWxqc3YAFkR2q+QRdmV4hBDk0pwGvIydY=; b=hElfhBOJTMf2G8WnMAA0sUdn58RV1dL+oNbGxhObInzmqnYJOYvr7QwsTVwmAYyuwA 0AbtvrQehDfWTc3gO124W6+FaCmrr2oDExKnDM3hUd6Vzr9fIGDDcBsA3wRW5pRfQ2rA ukqNJY4ZchoXaCVqA5pOjVj3hZYSQ4hKS0Phg46NilAe9tXd4r4QSXCRSPVk+DBg+KTn g111PNzla/9m86+YGM/+ZK+TTxtQDZw05HQycp2knLwW6rApz3GIKM1bYX++qPM0EVbP WA1MCZ/xLHLX0nh1DKW59vn2NFddOSbM8mPbP3nWOAw7dd1CD5ymxL9MWO4xY8Jmi1Tw BXSg== X-Forwarded-Encrypted: i=1; AJvYcCU9nPaPkxXN/i/IO6c8gbv1YU5lF5A2CAmwm+MJ3orSMlVrcnFrMr+6XltXadP6HOtbKjVvfot602OCWonsYgcLjvs= X-Gm-Message-State: AOJu0Yw9hJziha2dfFr0zY4vzdn+yg5Xa67N1blpv1/v47B5ZhTPx0jq l1mWuDmDZFZGvnOPeUG/0jiuZTtXhjKkzToakB2x7z4OWOS5LbMXxS7xZ1AraYZbI+4HVDHSRaF i/eFQURGYl1CEm8+HeXm43BHEeszYMYgPtXMWOiTflzZA8kZ4 X-Received: by 2002:adf:a388:0:b0:34d:118f:21ee with SMTP id ffacd0b85a97d-34fca2428f8mr1246033f8f.28.1715152375093; Wed, 08 May 2024 00:12:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZZupsg1Db/5JE5dUmFPCueW4kf8DoanWM6rHkv8I5Eu8zlJOQv4ibsbNV5d/M0ESqjYAQPw== X-Received: by 2002:adf:a388:0:b0:34d:118f:21ee with SMTP id ffacd0b85a97d-34fca2428f8mr1246009f8f.28.1715152374591; Wed, 08 May 2024 00:12:54 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6bc3.dip0.t-ipconnect.de. [91.12.107.195]) by smtp.gmail.com with ESMTPSA id m1-20020a5d64a1000000b0034edd6d5bbdsm8882608wrp.7.2024.05.08.00.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 00:12:54 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 09:12:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm: shmem: add multi-size THP sysfs interface for anonymous shmem From: David Hildenbrand To: Baolin Wang , Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6b4afed1ef26dbd08ae9ec58449b329564dcef3e.1714978902.git.baolin.wang@linux.alibaba.com> <30329a82-45b9-4e78-8c48-bd56af113786@arm.com> <0b3735bc-2ad7-44f8-808b-37fc90d57199@linux.alibaba.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: dntwocqwn8itrdmfowk9hcqihtbdyw4q X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 41DB6120018 X-HE-Tag: 1715152378-492273 X-HE-Meta: U2FsdGVkX1+KT+4JcojNgOD8JR2drVvMp9Pm/W+zaCDhfjbAL/rVzYcNWTwD8aiLRvorv8PmZ4I0SlK7cmHyotFgQm5HLJfhRYbA2ZSb1t03bO1JsDeLp8/01hSksywW5Qb/cF65zIfhZEQ2IKJUN+oaz8Ishyxzkyqvu0NUBCgZmUtYNxvgSmT4FgjzZM/San0Ite08j5/3pJuwM8NIqWMVVhrn74yjg95QAxge7Op8AesbOi9yQZ67MGydTEr1CC53hzSBE/y/rESSqs9htlXVrgXbv/HujOhdhEee4VrJsRYG2Jkp1EpQsGBE43xd7FmhPdA+/Bx8ST7w/w9fs43AjfQzP/XW1MJSMv5xDZ2GC7P48hYjUCDZzR1iF/oq9dfxyWvvJNSJBpIWAMN0t153ooB2yZKv7CYwPhmfSvTu82ySFj00s18gFnPb8eX5szwQhUMTL8leiijTQP1pti0NfHs1c8VeJvCh/uZk85tT4BlNiBhpwBMFBdSe2gwQssF+ujyEU9KHp4tyw9AwgHAhlyvBdmllda0/gutJ6LpWTRZqNBrk+d5L1UJncciR5V1t8h3jom0j0ECByjLELxJLi2lfs2vdrer14ls71HdUwMElD9iXik7bNPSXd08AeYsTtSQlC9DmnMtlcW5265hbBaPAGTsDB+sKb7eOAk01b4MHpiEfp5nxbXTUL+5HDziTIy2QON1RUDEUERyRJy1KxTWxCb+1iB7xWqUkK/hs384obQ4Qsnp8byAMWHeDS4ioBcsW2LrRe9w5htWaRFpL9ZhuZ9Mu0gFw44k2fuZq3AZ4n/SYMLggiLTrxiQ/Ogzm1FPH0MvTQdF9ZvEwqHikKEDkGTQa2vgo2q0WXCYSJASkV+SKecAJqm9OHwUutbNRXsbrCzZvsp74N0uB35ts7YZOBhW4aU+sKE93doo/+p3D5YgrgEOscXlwGXEEQx4NGw1LcMFW0uGI0gA vLqWcpgo bJo+BGL6VicRkYLJONdB7Vst/19ugo92oaymddbHlVFnT4NkV2p6KUTzg8ADqTbXN0AtFQmwVgEo++MkVMGUT//i8qDuxFoReOV4va07xsiKuWJCo3SRYFNHIQBXwaRXT3zSrkTqLFGbFLvZbQI13kswho31w7oeFpsnMwwWYhho0uqYSRhq6tNYUKqu0I4xxQwfLO/oKs4OPn0JxQ3H6MbZnwVU9+Xo2mORqmSxblIgh1p+SHP29uHgFUiXn9QBMuzIISJZIsJ0Vpbva6BG1FH5ZdzwUeeXnywfvuvjaBEjmr91qvSO3nYqcXtSMWvtgZr57qbkdz6Qn6iiKjM6/cUSJSNW016JjYLnJt5AhkhHXTqTMkjh1C7xt5xTBi51p4whrxUn1ob9Icm0OOT2y3uk1djZxUKzb8ylCtRHUh31ZR38i6smEJ7tLQJv08aQFo5JcDikk4s7vo/9bs2kFB+sATVy7AVb1bk0zuSb2gZwUYpsnDNxqlLsxfYApBOf6uvogMxeZrDcrarE59FgE362cFRV8DrRiEVERcahJevfQdc4+cttKPPMRbYOWG/haEh51 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.24 09:08, David Hildenbrand wrote: > On 08.05.24 06:45, Baolin Wang wrote: >> >> >> On 2024/5/7 18:52, Ryan Roberts wrote: >>> On 06/05/2024 09:46, Baolin Wang wrote: >>>> To support the use of mTHP with anonymous shmem, add a new sysfs interface >>>> 'shmem_enabled' in the '/sys/kernel/mm/transparent_hugepage/hugepages-kB/' >>>> directory for each mTHP to control whether shmem is enabled for that mTHP, >>>> with a value similar to the top level 'shmem_enabled', which can be set to: >>>> "always", "inherit (to inherit the top level setting)", "within_size", "advise", >>>> "never", "deny", "force". These values follow the same semantics as the top >>>> level, except the 'deny' is equivalent to 'never', and 'force' is equivalent >>>> to 'always' to keep compatibility. >>> >>> We decided at [1] to not allow 'force' for non-PMD-sizes. >>> >>> [1] >>> https://lore.kernel.org/linux-mm/533f37e9-81bf-4fa2-9b72-12cdcb1edb3f@redhat.com/ >>> >>> However, thinking about this a bit more, I wonder if the decision we made to >>> allow all hugepages-xxkB/enabled controls to take "inherit" was the wrong one. >>> Perhaps we should have only allowed the PMD-sized enable=inherit (this is just >>> for legacy back compat after all, I don't think there is any use case where >>> changing multiple mTHP size controls atomically is actually useful). Applying >> >> Agree. This is also our usage of 'inherit'. Missed that one: there might be use cases in the future once we would start defaulting to "inherit" for all knobs (a distro might default to that) and default-enable THP in the global knob. Then, it would be easy to disable any THP by disabling the global knob. (I think that's the future we're heading to, where we'd have an "auto" mode that can be set on the global toggle). But I am just making up use cases ;) I think it will be valuable and just doing it consistently now might be cleaner. -- Cheers, David / dhildenb