From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0421C2B9F4 for ; Mon, 14 Jun 2021 13:44:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B238611CE for ; Mon, 14 Jun 2021 13:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B238611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 861146B006C; Mon, 14 Jun 2021 09:44:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8105A6B006E; Mon, 14 Jun 2021 09:44:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 689D86B0070; Mon, 14 Jun 2021 09:44:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 3345A6B006C for ; Mon, 14 Jun 2021 09:44:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C36986D92 for ; Mon, 14 Jun 2021 13:44:48 +0000 (UTC) X-FDA: 78252449856.12.96B978B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 70FEA20010B4 for ; Mon, 14 Jun 2021 13:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623678287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lrIwXDeHLLQ2dpMrbw5IZ7PKfiFZNvx91zdI2k8RLy8=; b=TpPs9lLt5JSyOuOYx1lTZyO+FXZTw16D69qCek1MkZcBN6rtRWRM5ZmKxG8HhKxW19yewv RXF+lirED5TjgnWrkgAASenLUIYuRAxpjrLX8FqteNT7hBbM7qy4+OZTiNjPzHO/QPJ1I3 NkfGgQa+RAXs0oi7zded9RNDxspWB/M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-6nSUdJ5bO0yvZgLGky5QNA-1; Mon, 14 Jun 2021 09:44:46 -0400 X-MC-Unique: 6nSUdJ5bO0yvZgLGky5QNA-1 Received: by mail-wm1-f71.google.com with SMTP id k8-20020a05600c1c88b02901b7134fb829so2409013wms.5 for ; Mon, 14 Jun 2021 06:44:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lrIwXDeHLLQ2dpMrbw5IZ7PKfiFZNvx91zdI2k8RLy8=; b=BYdqTY04UUZfsDRLfmOfmdjx4f7XBm8HEc4y3VSoohEj8xzXD46NKs2Zdth9hsk7PO 4e4bgLzc1f7aoUlQQPnIrw/vaQQ1V2+mh8ttel8nIUyAC7z5XD9TdF+xKXGRJCIEDU2x 9o8t1wqnwYxvMot4oKQD2a5gC/EE/ytBBJHR9TxJVjvSITnsrv8hHubhaygRjq2h1NPE rpb9iy84lJfg/Rc2ZqfDxoJUReXRrgXuUnbHQKO6cQOxsddZnh0gz2QI7G9swTc7NJCY 7Zvo/ACmH6QwzLQJfOYHMpyUlpcrzCM6CjH6Ak+Veu5J51bD/2LfYZN3sH2rgMJjDnWy 346w== X-Gm-Message-State: AOAM531q4NUVpGX87l9GIVY1SsPySGrFUQYd/zWwnxJWdjQWRCFOpYAi NyDedUYL+ppm1EI01JEy/03B6izppF8zNCihQBrDu4kT0srmcGOgIZ3+dHgJayWgtwD/2Xqx9NR g1V1AMA3MFs8= X-Received: by 2002:a1c:f206:: with SMTP id s6mr16351337wmc.102.1623678285298; Mon, 14 Jun 2021 06:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFXrW+YbfMtfgwKXb7OxONoQUWezJP1D2Ith4tIayhYHEhRZ9UZdTJKdX2jlwWnzIBZZCPAA== X-Received: by 2002:a1c:f206:: with SMTP id s6mr16351304wmc.102.1623678285091; Mon, 14 Jun 2021 06:44:45 -0700 (PDT) Received: from [192.168.3.132] (p5b0c66ca.dip0.t-ipconnect.de. [91.12.102.202]) by smtp.gmail.com with ESMTPSA id o7sm17627580wro.76.2021.06.14.06.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 06:44:44 -0700 (PDT) Subject: Re: [PATCH v4 2/2] KVM: s390: prepare for hugepage vmalloc To: Claudio Imbrenda , linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, linux-mm@kvack.org, Nicholas Piggin , Andrew Morton , Uladzislau Rezki , Catalin Marinas , Thomas Gleixner , Ingo Molnar , David Rientjes , Christoph Hellwig References: <20210614132357.10202-1-imbrenda@linux.ibm.com> <20210614132357.10202-3-imbrenda@linux.ibm.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 14 Jun 2021 15:44:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210614132357.10202-3-imbrenda@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TpPs9lLt; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: eaotrrfxe9kpw91d6gp6ykw6m1iiniay X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 70FEA20010B4 X-HE-Tag: 1623678280-218907 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.06.21 15:23, Claudio Imbrenda wrote: > The Create Secure Configuration Ultravisor Call does not support using > large pages for the virtual memory area. This is a hardware limitation. > > This patch replaces the vzalloc call with an almost equivalent call to > the newly introduced vmalloc_no_huge function, which guarantees that > only small pages will be used for the backing. > > The new call will not clear the allocated memory, but that has never > been an actual requirement. > > Signed-off-by: Claudio Imbrenda > Reviewed-by: Janosch Frank > Acked-by: Christian Borntraeger > Acked-by: Nicholas Piggin > Cc: Andrew Morton > Cc: Nicholas Piggin > Cc: Uladzislau Rezki (Sony) > Cc: Catalin Marinas > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: David Rientjes > Cc: Christoph Hellwig > --- > arch/s390/kvm/pv.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c > index 813b6e93dc83..c8841f476e91 100644 > --- a/arch/s390/kvm/pv.c > +++ b/arch/s390/kvm/pv.c > @@ -140,7 +140,12 @@ static int kvm_s390_pv_alloc_vm(struct kvm *kvm) > /* Allocate variable storage */ > vlen = ALIGN(virt * ((npages * PAGE_SIZE) / HPAGE_SIZE), PAGE_SIZE); > vlen += uv_info.guest_virt_base_stor_len; > - kvm->arch.pv.stor_var = vzalloc(vlen); > + /* > + * The Create Secure Configuration Ultravisor Call does not support > + * using large pages for the virtual memory area. > + * This is a hardware limitation. > + */ > + kvm->arch.pv.stor_var = vmalloc_no_huge(vlen); > if (!kvm->arch.pv.stor_var) > goto out_err; > return 0; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb