From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EBFC282D0 for ; Tue, 4 Mar 2025 09:43:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA76F6B0083; Tue, 4 Mar 2025 04:43:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B56376B0085; Tue, 4 Mar 2025 04:43:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE986B0088; Tue, 4 Mar 2025 04:43:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E14F6B0083 for ; Tue, 4 Mar 2025 04:43:46 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1267781A19 for ; Tue, 4 Mar 2025 09:43:46 +0000 (UTC) X-FDA: 83183381652.09.9624EA4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id A0A3C4000C for ; Tue, 4 Mar 2025 09:43:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=biyDFNid; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741081423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xcB5AlBL0CvxeH1tTmF1m4r2t4soM28ZFM3akt0yuwo=; b=BP+OyHvnOr81bSYLt3l/nZaG1VXwbd8pjyscZxR+6Uk1XaD7Be3AZl89QoqtrablSYtlSN Rm/eW+yVbKIQk8U/DPrvt7ZDx0sPiDhvXJCW/4ZctrU1wHAaE7medHz0Bp1xAy5odKVdH0 cGTMJ6W6akRMxEgbwhvjiDWljmtb5ik= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=biyDFNid; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741081423; a=rsa-sha256; cv=none; b=28spXKoYE+8IOyqg7YmfHDOyBiKa5y4GsKLlb1xa+Iq4drsr9Pl/FeXMDdUum6JH5ygAlR WU+rPlLiZ1gcfodacDn628sb5+O3j2GGjtS6UJksKakbmVQZW/ZIt8s8mWixaFH3Vu/rxY 55hvnVbb3Whmozh5/TgbD+Qvw7D7Bvk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741081423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xcB5AlBL0CvxeH1tTmF1m4r2t4soM28ZFM3akt0yuwo=; b=biyDFNidFgzYzubvJnhAEQJoIdxdpM8EjOwxYR4KGbEaoHyZeYLMD5P64uUymyrNWLFfwo eDmkiOngD0t6k4XScPbMRVMRBPPgWoA+XkK2Lx/t8h1KN5rftyx+3fQa14fV4XDqDC6ivD HnKl8xx4FVdcCPjHILU5+4s4iFipX04= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-GmggFSLUM_KoAmtcMisU4A-1; Tue, 04 Mar 2025 04:43:31 -0500 X-MC-Unique: GmggFSLUM_KoAmtcMisU4A-1 X-Mimecast-MFC-AGG-ID: GmggFSLUM_KoAmtcMisU4A_1741081411 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43bcc04d2ebso3825715e9.1 for ; Tue, 04 Mar 2025 01:43:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741081410; x=1741686210; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xcB5AlBL0CvxeH1tTmF1m4r2t4soM28ZFM3akt0yuwo=; b=Trlvx50rVyPh9yqdimXjkHAqkO7cI3G2aCcNUaiWqBxxN7805w98pPPnBcIpexzSzY RMinkCBB8JJwDINwbgKn5PtE5yqL4nZ3cW9OxNGyVzH6mqosVg9JYz7BlalyLUlFWgZN hi83qquWUHDMd7FibDd6cClI/CCIVbTRR8UV5sD3kam7fm9oZdegfb1SJgkRaBjPrLrA SApD+gUKh8Q0JGtkNCHMzAg2UcVtS7V7KvYpTL/+xh37ICRewhcPahPgCg093BBxU6Pw Wj0aZxnU14ovOM8r+JlOO57hkgmVbyYf6p7NapCA4a0RFWVQtT1u5q0fSma9gPrFGTs6 Ru0w== X-Forwarded-Encrypted: i=1; AJvYcCVtvtf39Y6k/1gmLCffB6egikAYboDmeA3k3N0Maf8Wuq7NKjf+6OmrAzZp95tO8PUtlgAE7ItIvw==@kvack.org X-Gm-Message-State: AOJu0Yx9RDVW1xHrpS8r/RkKsHaEDu0c1zL76P3nzRBIlsxiIEaE9HnO x0lgKqPcE0WGtrMxzwOTyu1Bau17d+s2F/ELp8Q0WU+uH4agEI1wO2YBNUWxO9oYFOB1UkhGSxx TNa0w3/xd1+pVbEe8R53wmSMe8B6mbOyC7JmmykX2WxW6t/2n X-Gm-Gg: ASbGncuHvoP6Nu8El8PlJ6EtTrd27Xm9RKAV4rk61YKa8r5xzKJcF596XF1UkdzNY0R wlfpV6nr3awKyCF9UkoWt9fMnSIYrHkBPOHQTGMj3/5jOrc8No1BSezODq99HVPv/cy/Y+Hqsgh 1hOF/eEl8GINpDv2E1BgpRuz/4oy582Y57sWhd5LgLF934GFfASrldTrirNARJphIe40yflwDbR 3sJSM4yPr+LxLByA9C9ICsAq+83b8y2FRn1uPb3T+ZyxIS5CLvMfiZCYQhNWxveEq4h7KyO1Vcg K26YB/jk2k16NMCC07HgDo47WVdSPnvcxKxLl718oaT57L3vUwvaMeBeU9mBijbEQizH1apJk87 aQ2PRLgggWRnZ0okDV9guJrV0zZPHjX9Qjf4NsfrNTlQ= X-Received: by 2002:a05:600c:3b27:b0:43b:cf12:2ca1 with SMTP id 5b1f17b1804b1-43bcf122eacmr2631935e9.10.1741081410543; Tue, 04 Mar 2025 01:43:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEf07g49YF7edwBwnu5q9VN9CFepKmjU92h615Ki4i7JutZ6qqjb8AYAgkEbdipqsP1no48+Q== X-Received: by 2002:a05:600c:3b27:b0:43b:cf12:2ca1 with SMTP id 5b1f17b1804b1-43bcf122eacmr2631365e9.10.1741081410167; Tue, 04 Mar 2025 01:43:30 -0800 (PST) Received: from ?IPV6:2003:cb:c736:1000:9e30:2a8a:cd3d:419c? (p200300cbc73610009e302a8acd3d419c.dip0.t-ipconnect.de. [2003:cb:c736:1000:9e30:2a8a:cd3d:419c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b7370372dsm187477415e9.11.2025.03.04.01.43.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 01:43:29 -0800 (PST) Message-ID: Date: Tue, 4 Mar 2025 10:43:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/9] mm: Consolidate freeing of typed folios on final folio_put() To: "Kirill A. Shutemov" , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com References: <20250303171013.3548775-1-tabba@google.com> <20250303171013.3548775-2-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CP9aTzxFmb_BcFW17wnDdn5u3Q93st8B7Nk5rRQLmrk_1741081411 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: pz6h3hey8uffnwbnjf3xsoctkh79kqfw X-Rspamd-Queue-Id: A0A3C4000C X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741081423-548193 X-HE-Meta: U2FsdGVkX1+WuYrnMyVF7av9TqUW6AGbwkLvTAQbyBCfejEuSpgic5TSBjgCTmQDwOFpuiavylbgTC+EA8lXluxWUVi2hkXruN0dV2ZQ79ZsMIzbi3yqjfEk8eq0/KAx5dnsezXy6+sNeOD6bo2Igiy8HHU2bsbhoErPNzlmfTjsfSuftI68+dVmrxvUB4R55RT5gb6A9OVQSbTIM3wgiIWLtRU7SnEAABwyoWACxS3BCiq/R1xP71Kcm6cJkplfXWADYIUk/2J4TYN0u1QOIBl1Atp2aSQqnGaODDg7F8k1ZGg8VodusBBuGfGHRGtqXiQVtB9YFxMdolJ4o5MOtDIQvqIFNb1wcJTl/2aLeO3k5V1Bw5mQZmFHgmPFtLDGkY6EfvZV7okEi/quQyww4l88y1CDHyDbVLYIZsS6zA8kAfr28SCKDtTw5/FtdXvySGyXxW2ffuYJ9zwX8xZwC1V6JD8LUjonv19BkIEU0XtYMc09qN9QjBeV9AnpxZgujiJpCXrR5532V7E6SYzkTtoW201VM/+KD71WmI3xiV9cpCNqOX2sYU0g2ID3eupVEtEfOzStDpoDf+r6MBEN3NlmFrf78XDOksimkFyqCQteEwGwAVWB+Fpgoj5DPd1VN+XGq7N6qqdWVHn1P9crUMAMXLbwqMvchhMQFmXT2YB5hnEzYwA4AWK6wqXKFOFhUSqX8RhmVDl6ASzanr4MR9d07P+4QMjoAwU3vKdHgA46SZPx41ra8CVXJcFEXJitLpymMAPPQPMryNmsbl6DKGO83pDu0pLjuMihRqnz9C1TwckeBRd4tqnuJ28kqycNmmwoQ5+xRB803nhacI47rInrxVqBk8V27dNt/8kin9T6X/sA1XfTR80TDnlvBJvIQVF49l+Ef7vyZDKCmEMvbceP0slYho/uwVNTlnsgjrtn9xLk+Ai8svmRHXIlFxTEV3FnOwBKNnCuPiF77Pv 0VlK8uhQ rqMuXNgEDhhP+ISgV6AYgqltK5tol3D6KwCEJKFRQqxf8FqRCRHcyBezSfqJrqoCCvQ8XaPkobg6OwGvZ6Zsw5A3tQzJedlUJyZClJ7tgVYo7uCNSoEjBlShTXElPo5R3f0LatgGK+e5Ar61Gn7Ug2oDnGJXspU8E7gGP5adVbhgem2TobuxqhH8xfFWtMCljg3gfj7LSltghBtQ7sa5pCUAeJA84H7jqUYUNVeIp9Y1JTtJzIIvWW81rdhKOnExuY5AkhtwSo5AJ2LL2NSGBm9xi09t3zzJgGsLCrjlntMhUyrcvgCVx0S37TNtPy2hLUSNErXcfy/falSm61ODlnwAD3Vv+oB/jngnRnvKfnvHrf6EECsZywp3vo1+a0/WJZpbCekJSDkjw6Vh6gCZw+sYDOepssZ9ozfPUsC6Z/EtwiUgme5E5oWGkgPbkab4BVnQ/A6TRODgxPzwls8D/oxSVzD5tdwqWfEkmyAm6VT3ViFvzjgGvDnlnvjNakfkelEBl0vmIIFYk0FM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.03.25 09:45, Kirill A. Shutemov wrote: > On Mon, Mar 03, 2025 at 05:10:05PM +0000, Fuad Tabba wrote: >> +static inline int page_get_type(const struct page *page) >> +{ >> + return page->page_type >> 24; > > This magic number in page_type code asks for a #define. As Willy is about to rewrite most of that either way (once the page type is stored elsewhere), I'm not sure if that define is really valuable at this point. -- Cheers, David / dhildenb