From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45766C4332F for ; Sat, 17 Dec 2022 01:59:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD29A8E0002; Fri, 16 Dec 2022 20:59:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D82568E0001; Fri, 16 Dec 2022 20:59:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C72088E0002; Fri, 16 Dec 2022 20:59:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B7C608E0001 for ; Fri, 16 Dec 2022 20:59:52 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82D5B160636 for ; Sat, 17 Dec 2022 01:59:52 +0000 (UTC) X-FDA: 80250142224.24.7E17118 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf30.hostedemail.com (Postfix) with ESMTP id 6829380006 for ; Sat, 17 Dec 2022 01:59:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671242390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8TVaag/gc/3r+pxFk7D94N/65tPEdzd7hUx1g0007w=; b=irxgfddIcxvkEZzmIILAxGr1WjOWtAYIbJP7ggAELK/8hlQD5fIzBN9KaSnzQxX+g4G8Pf O+1RgVyh7frUdSazVYsIail5y9Ag4/PJR6dHZ6lMfKmlRLAVcSFvjjR64T3yzdsCeWYS4B pNcYthHTR0L6/IHxB+rx0rSHOBpFqr0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671242390; a=rsa-sha256; cv=none; b=0+O3FzPn+O9x1x+w1HYmuS37T1KTP4DJ7qYkje+525qbH96teccJVwJa55eVHX+Nb2Ku2N aO2y3FHfn5iTFcJguTrirUsn3Oca+j6hFhEtBNzRL1sZ4b+cajlx5402dbdMxuQTtMgxBl Ne97v8emDP4752hEmyPqpjh9I+cXxqQ= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NYpzT0hg9zJqS4; Sat, 17 Dec 2022 09:58:45 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sat, 17 Dec 2022 09:59:41 +0800 Subject: Re: [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas To: Mike Kravetz , , CC: Muchun Song , David Hildenbrand , Peter Xu , Naoya Horiguchi , "Aneesh Kumar K . V" , James Houghton , Mina Almasry , Andrew Morton References: <20221212235042.178355-1-mike.kravetz@oracle.com> From: Miaohe Lin Message-ID: Date: Sat, 17 Dec 2022 09:59:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221212235042.178355-1-mike.kravetz@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6829380006 X-Stat-Signature: mhmnwqwx9gqsnmc1fr4iffk6nqonsk6h X-HE-Tag: 1671242388-440732 X-HE-Meta: U2FsdGVkX1+ZlaWqEl50Av0eT6viYb61K053M8L4qYaG4VbJ4xmyn1tYfUal8lJzpNmfe7JN132XKj1UQOMblB/b/r2TCK6QEywJonQFAx/mQZLN+dEvn6OyMbWXqevC4ANhjN8Puv0ItNq7UGCpQJgC0n70Oyo9oHVCw78BmR+B/3M09scXIyp0AJ1ZjuIy526MYNzyexnANflgF9dIEE/FnIO+69gr2DN7lDIudtvyLMvyxnuUvfCinuePUMOCTPwASdhLBHqqoX3Kc0z9+Mp/y6Vk1O4Y1fxbld7D7w6fa03ZJyktqS6sYYPdwy30K2Q046rXAxrkjFjIENQYqe0M82fspUfUfjXDfz+t2UzpxGRs7QxMO3nj3tL5pq6whBIYPkSs+b2JjfUi0I0k87QYG3Gwd36j6dbEklX9wuCY6V7NYutdmFyb9FOo5FBMEQI0vk10GxpRtMBznzPr+s4uUj2I5gk1UPZFdG6v+nojUH9HlItvoUzsCc2jgLbevmVFAfz2iLjI0D5vtePIPsV1BtlCnhoAjWZFR9pYUVgklQinrTSzzRR95b19k/qo0j8XacKfJSQRXarHlt81Ofgpe8ibHJuCEv8S/WYldnlpQHfCt+jXjy2LG0Wzb0//jsFgFMmXzorE1Zg9nSxAXBIoWHvxRLarYrv8kf3BEcK4/N147gSEEAUcPqRR1AZx2v/oIrVxqyUYD1saSxAV9qqnsgERtkujSqVBzLSNxFi4MBH7/F5muu4uN7+fwBvKW/sxCFzHwNBQ3LMpqRAI2DXl3jPMEjvdMeXsufdL6igvgtaFW271ja8bhNZBS01z7s37VeUGPrQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/13 7:50, Mike Kravetz wrote: > Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") > removed the pmd sharable checks in the vma lock helper routines. > However, it left the functional version of helper routines behind #ifdef > CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being Oh, we missed !CONFIG_ARCH_WANT_HUGE_PMD_SHARE case in the previous review. :( > used for sharable vmas on architectures that do not support pmd sharing. > On these architectures, a potential fault/truncation race is exposed > that could leave pages in a hugetlb file past i_size until the file is > removed. > > Move the functional vma lock helpers outside the ifdef, and remove the > non-functional stubs. Since the vma lock is not just for pmd sharing, > rename the routine __vma_shareable_flags_pmd. > > Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") > Signed-off-by: Mike Kravetz Thanks for fixing. This patch looks good to me. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin