From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27941C433B4 for ; Wed, 14 Apr 2021 12:15:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72D2F6100C for ; Wed, 14 Apr 2021 12:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72D2F6100C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E2EFE6B0087; Wed, 14 Apr 2021 08:15:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF336B0088; Wed, 14 Apr 2021 08:15:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C58406B0089; Wed, 14 Apr 2021 08:15:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id AA94D6B0087 for ; Wed, 14 Apr 2021 08:15:17 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5F41E1EE6 for ; Wed, 14 Apr 2021 12:15:17 +0000 (UTC) X-FDA: 78030867474.39.156B04E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 38C66E000127 for ; Wed, 14 Apr 2021 12:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618402516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFtVeYRBrjEQY4H1xhMi03RQAo6ksAC16iLETUn+lv4=; b=SMZtDfhMJbPpXVJEsMiR9n1bFBVM4GZj8s/X6FzuIgkybyYp/qudaBpY4ojFW2Ys1ngRXj fiN+u1qZfILEknsB2p3zoN9ZQJpp85v2+0p7oC/bV2CrA8Z++EGc47Ukr5mrWrwY0unhi8 4Mn76D7Gq44tepM2lzPfwlFbwzVau+I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-tf3RGFThP46ebwbLp9j6_A-1; Wed, 14 Apr 2021 08:15:14 -0400 X-MC-Unique: tf3RGFThP46ebwbLp9j6_A-1 Received: by mail-wr1-f71.google.com with SMTP id t14-20020a5d6a4e0000b029010277dcae0fso989240wrw.22 for ; Wed, 14 Apr 2021 05:15:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fFtVeYRBrjEQY4H1xhMi03RQAo6ksAC16iLETUn+lv4=; b=YU1bSh1cpPUxPz4MSfHjYrWc4aLMiiARXNi+pScj7P40JC9+Yk97CKsBC7Pm4MufPJ rSKTMd+g7zVhXf9yyPQ/x++mXITdonFKPAwAMNOcWCjVziRfeBoKZp+a6eoRv5zIlkaw KPDiVyOkAmNIxS112XsQUwUBAaOqrg29XWZ76bhBZHTGEivURdZ8k0D+UBlHVzmofAqF oaj1agQYVnJ/I7hJfUlUuLJGhyktyPzFod55MIfrsVng4nDXcTGkbzu/ujetnD1OB7Vi CiO41bbTxj+KNQHVv1m72O1c7Er4g+O1vcx7SUyX1r7GyOhY3NInoY9T+B0UVd2lpYv7 Wvcg== X-Gm-Message-State: AOAM531rUm3GOcMR/inkkXUiOIrx3DAHSEPQGwVqXO7dWShMBEmw//1G TZpwYcU5oJXq76YKagDKTp1lxgXgr/QeqwVEsNRY28ofRRCdriMXxQOQEtELT4ofUhyI7+lEZez uQNCfCjYJXPQ= X-Received: by 2002:a1c:4b11:: with SMTP id y17mr2713654wma.72.1618402513766; Wed, 14 Apr 2021 05:15:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxH0QvK4xqEVaRk4x9rJOmv6sUKwBuhxWh8jHeD5J8xhbLpIv04Fo2Bfk4ww16Ld8EaO83N9g== X-Received: by 2002:a1c:4b11:: with SMTP id y17mr2713644wma.72.1618402513621; Wed, 14 Apr 2021 05:15:13 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6470.dip0.t-ipconnect.de. [91.12.100.112]) by smtp.gmail.com with ESMTPSA id o17sm11475628wrv.16.2021.04.14.05.15.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 05:15:13 -0700 (PDT) Subject: Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality To: Oscar Salvador , Mike Kravetz Cc: Andrew Morton , Vlastimil Babka , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210413104747.12177-1-osalvador@suse.de> <20210413104747.12177-5-osalvador@suse.de> <94992151-03fc-dedd-3e09-811908d26d04@oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 14 Apr 2021 14:15:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: odmjw1gwex8xzofhm6tfuxs8e4hb13b3 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 38C66E000127 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618402516-258803 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.04.21 06:59, Oscar Salvador wrote: > On Tue, Apr 13, 2021 at 02:33:41PM -0700, Mike Kravetz wrote: >>> -static void prep_new_huge_page(struct hstate *h, struct page *page, int nid) >>> +/* >>> + * Must be called with the hugetlb lock held >>> + */ >>> +static void __prep_account_new_huge_page(struct hstate *h, int nid) >>> +{ >>> + h->nr_huge_pages++; >>> + h->nr_huge_pages_node[nid]++; >> >> I would prefer if we also move setting the destructor to this routine. >> set_compound_page_dtor(page, HUGETLB_PAGE_DTOR); > > Uhm, but that is the routine that does the accounting, it feels wrong > here, plus... I agree. If we want the final activation separately, it might be better to have it as a separate step/function like __active_new_huge_page(). -- Thanks, David / dhildenb