From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DFD3EB64DA for ; Tue, 4 Jul 2023 12:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C27086B0071; Tue, 4 Jul 2023 08:36:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD7926B0072; Tue, 4 Jul 2023 08:36:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC67D280075; Tue, 4 Jul 2023 08:36:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9A42F6B0071 for ; Tue, 4 Jul 2023 08:36:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 64FAA160A9E for ; Tue, 4 Jul 2023 12:36:12 +0000 (UTC) X-FDA: 80973876984.27.001D6B2 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id C37D2140022 for ; Tue, 4 Jul 2023 12:36:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688474170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZflvEtiyuGNAl4cnO7wOIyEuAUClAKIbazJtuH2XZqM=; b=vFgwpfsB3IkeqSUaaP7Lq815JeMNYxFKucr+QbZNKqTQAuLvSvbZ9+ZGGjZbk0dWXHgFrr TwRMkLrtEelJ6QqmiY2876w3dSFVY1ihHAGzHo6EHjX4p8S3ULt5gVES39c7DlICBsPhAS djI8DmucnJsCLvO74W8rRbiMA2Ii2oI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688474170; a=rsa-sha256; cv=none; b=FYB5rgs8H5NhpMPn4oxVCcCRpJLCN0AdqVbsCv05QoP08+z0UMoR+wvbQ4oC6tQVx8D7nt c3KTgW15PVIUfSGf+EnFwHOWZ2GyGJOnQyQB04lrLa9yANaMy5/zhr4aZd6YcLIval/uhE TU7w3Gbk+xfWhj7muSjJkUlMytakijI= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwMgm0bCZzTmJt; Tue, 4 Jul 2023 20:35:00 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 20:36:00 +0800 Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info To: Matthew Wilcox CC: , , References: <20230704111823.940331-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 4 Jul 2023 20:36:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: C37D2140022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4nis9jgyfiydjfj7fyw6jz7hjgosxb8g X-HE-Tag: 1688474168-859232 X-HE-Meta: U2FsdGVkX185+tLxAx2yPtCxb//6+Fe1OTVpPR2wW7T880kvrEiQ4B3xGi5BLtYJsw7BCOqgisXzWSj6IEtl5ohDsYWhIuZXMA5xCQZl+dkkMEfzlzcnkOoBt26CxApD28ql3IcwUzcQZZL7FEwB+O+ScMwQVphJsUyqWzcxtn4T0MxEHHYA/mWKY7KwPELOdsTwWKs9xdhx3Bou4eGEZfov/I4+CTix/R+qwwwB0scqhs+ZRURor6856F3V+s4gDPsGHQbst621uS1NFsFBlHaMNom7D+yWKwvTz/2s2ChkCnxiNyDMavl9/qm2j1Zy7vvOcnW4qBHFCy8h5sAwAw3VgCbOUWTqcwWTw0gdLIQ4NeY3ucMYe0/qbGLe+F1jq94Q134ukryw23EnYMJqiNiKJ1EQxvuvxKQPlLUbvbPMCYUSXZbENNvVRQyTIB3CwCEi5+LCoBRa5VvcLIjiNVmolkOCHH6X9mbB+qHwIkTvTaNx4sxKu4wQ1r7K2/p6wY8B/L7xmZ1P/5RcaqL2sOKLKDBO5kxUrW42n9on9rptaeWLT3zVVjzJjQ1vKYGsGZHezy6HHG7tUPpXZzKephYiANa7GCw9L4uDqql9qfjQE2V5aZz0K/6hW3gL2OgigmAhyuUIj1azAbvTitGBLWHe+RrEXcnBOI7ZXkgo+Oup/KZkjDPL4SJUdbHf4SKTZPjEksJH8yopdArzQ/z7RyhHVwW6g7RQRsKxEBFDYgptZ/FzeuiWy6g81d9higF16bogF2bd9dj3jj9n+qUqRHJQRJLC8wCb4DQYL/9wzf9sONj/+l8CEE/g2Cc2q+w9xBZdfep7O67TAHM+RupVGUUMQMySDx90OkV+66+WOl5CTYITFhy7VlFQL+t7GLc5GDjPHZwmI15Mz9iCRQK9J0yZNxX8FhJ/oFWCu3xxZnIjFCLrhURsGpLZ+8112o+pKra421QQQq6s+1+LIcZ jqQCyTDF ZjssAxjiJsjUhQ9TsEFvWxE+qa3RaMbXibEIhSBJvky5nI0bjgy5qaEwqpd8qGXM2FsPqTveYVIdWZqkegO6mpd2wSNDACDXoIJgoeq1CkxegIVRugORcNF7GZaq+HSHRkaOcOKOrEI7Gn2FzRUb7t4jwWQvfWahRO8TQy4bxKAdQuS9pl0qcD7S9rA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/4 20:13, Matthew Wilcox wrote: > On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote: >> @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) >> sp = zone->spanned_pages; >> if (!zone_spans_pfn(zone, pfn)) >> ret = 1; >> + else >> + ret = 0; > > Surely 'ret = zone_spans_pfn(zone, pfn);' ? Do you mean 'ret = !zone_spans_pfn(zone, pfn);'? This format looks fine to me. > > Also, did you spot this by inspection or do you have a test-case or bug > report? Should this have a Fixes: tag? This is from code inspection. The race window should be really small thus hard to trigger in real world. And yes, it seems Fixes tag is a really ancient commit: Fixes: bdc8cb984576 ("[PATCH] memory hotplug locking: zone span seqlock") Thanks for your comment and reply.