From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8587C77B71 for ; Thu, 13 Apr 2023 08:00:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E7E76B0072; Thu, 13 Apr 2023 04:00:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26ED56B0074; Thu, 13 Apr 2023 04:00:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 111156B0075; Thu, 13 Apr 2023 04:00:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 020C36B0072 for ; Thu, 13 Apr 2023 04:00:22 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AFA6B160204 for ; Thu, 13 Apr 2023 08:00:22 +0000 (UTC) X-FDA: 80675620284.28.070E076 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf07.hostedemail.com (Postfix) with ESMTP id DAACC40028 for ; Thu, 13 Apr 2023 08:00:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681372820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iJzMxbW3OC9fMbgGfLn0qYDRTf17hKChmQDIB5m2Z/A=; b=XezJIiM4S2cgyJUXyhH8aLEXxgwOQesiyDzKBuXb/EZoa32oC85GlwJeKq3SrMc0AWnYcW yTAbYX9ydQOWTSSJgZVjj7MWrQLWeQ+oEbf231r0WnGifLfaWNGwxGBznnTA8lUmgZxUA/ 0G5g/pj94GOr/DO58/f4imhZDBJCX+Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681372820; a=rsa-sha256; cv=none; b=5WthwB39z3teo8NFjLcV1xlYcj/xTDSEtc8FKf5+QQDLo+wMgJVtB9ae1ibprdRceFTyqk vhED/DnsqybI+mbP6fw5sXUq7YQpSA5gvnlAUEHu+h8rI+NCFg+VRIHkG5Japa83vgrade 88aBGztcwfhdM2UMIWRqQxUgnus9zAw= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PxsPY2gNqzKxxk; Thu, 13 Apr 2023 15:57:37 +0800 (CST) Received: from [10.174.177.229] (10.174.177.229) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 16:00:12 +0800 Message-ID: Date: Thu, 13 Apr 2023 16:00:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] mm: ksm: Support hwpoison for ksm page To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "wangkefeng.wang@huawei.com" , "sunnanyong@huawei.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" References: <20230330074501.205092-1-xialonglong1@huawei.com> <20230330074501.205092-3-xialonglong1@huawei.com> <20230331054243.GB1435482@hori.linux.bs1.fc.nec.co.jp> From: xialonglong In-Reply-To: <20230331054243.GB1435482@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.229] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: DAACC40028 X-Stat-Signature: 3upi6j38uo3w4ieg8ybxq94rc3edzhsi X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681372818-592729 X-HE-Meta: U2FsdGVkX18BlPlQ7d52/0sat+7MGDhsZiTiIb5uKf2Y3ZEV1IR6M3K3Ws3antnaxPVRz/leJ/SYjdRp5WMSSavdEMxqSS80dOZOcOUA5+V2+KCeW6mxbUCFNvcWNDGr7buuNhBpyH8gMHVfid6FUnkb3+nJI/q1JWH72UKBXkqUWO5iAoc+/9CHoQiFEXngyIuNDF9YVB7wJzHTiUTxBLlhuLOHjjmE+J+MAeZfDc7SwoZ2uDAzH0Ls9edzaxMyTX0ZdmEeGcmEv2HOkn34C7z1ZN08UMTuKD1tstiBw+spF0szLxpqo/D9aURMceYBKA031eS5nsLWU9xvw6oElvtDTIL4wevb/PTFhjUAWI+f1aOb/H0fEaS/MbmI14i3kJw5HadMlttxKGN5kQsW+AI2AfvAh159ciTFLPN5TEtTRv6Nr7caEHFJBRGKlpEGTxMdbpLKqTwmTEaQnoq+1o37pQCMxpnFLoa4KVbtxwBaUt+nMiW736mHC3BT2hcTUSA0iwMEiCC+muVt4yMeGYbsu0BbO95icpcozmEJ7mJOGSJHnQLvOL+HIxNzevvqylu0krrQ5ZTBSyVjr0JcPqDCCICQcOh8z3MQPWM1WX2/FYrN7q6c8NFwXYAS2cTE9cLpQZVLW0m05tknmEhBfB9mCFGe3d06oLYdvcoGcGSSsqWLbs3dHPMb1JaLCApnpAUMTQSpYja/oK0wKdhjZub3Kdzs4KEovJsUhCZSpNGyQcCf/dokwcHqxNJveDyY4THsXACeE9LEQEUgo4wlRR4a5sDUD+1HmVTEQCoZR73cQRuswdqFdO70mJy3mWWpQBFyIz6EBtyCQ50ditk235QOUNsI+ts3P04TUOR4HG9E1ZAU52eoPjSnfZHxfAsMBDBYzkbugOGjW8uBCaaA5MshIhPS/j9xN54z8hLp/UaEG6teVMCUgtw6NWL1CEG/ftAnYsrXOhgt8VlmOZt dv9rRU5c 9x9JZjB/3bWv8nE9mJp7f/DaIY+Q2u55/he1lfrflhvuITAuFfRkuTIz4HC5meoSp2Iu5ShWjbXWiHYLuqz5DYxawZzOtII62ub9d8udrm8yngt3peP9gG0shWWHaEhO6FHsWMKy2OIAmjYOg+T3pmdWS/OwmhfFbx/vhNbAteGBZ030kd1JlnJnbJbgxLGiDelAt8z+wUP5RgugU5tLGCgUToA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/3/31 13:42, HORIGUCHI NAOYA(堀口 直也) 写道: > On Thu, Mar 30, 2023 at 03:45:01PM +0800, Longlong Xia wrote: >> hwpoison_user_mappings() is updated to support ksm pages, and add >> collect_procs_ksm() to collect processes when the error hit an ksm >> page. The difference from collect_procs_anon() is that it also needs >> to traverse the rmap-item list on the stable node of the ksm page. >> At the same time, add_to_kill_ksm() is added to handle ksm pages. And >> task_in_to_kill_list() is added to avoid duplicate addition of tsk to >> the to_kill list. This is because when scanning the list, if the pages >> that make up the ksm page all come from the same process, they may be >> added repeatedly. >> >> Signed-off-by: Longlong Xia > > I don't find any specific issue by code review for now, so I'll try to > test your patches. Dear maintainer, Can you please provide a brief update on the testing status of the patch and any suggestions you may have for improving it? Thank you for your time. Best regards, Longlong Xia > > I have one comment about duplicated KSM pages. It seems that KSM controls > page duplication by limiting deduplication factor with max_page_sharing, > primarily for performance reason. But I think it's imporant from memory > RAS's viewpoint too because that means we could allow recovery from memory > errors on a KSM page by making affected processes to switch to the duplicated > pages (without killing the processes!). Maybe this might be beyond the scope > of this patchset and I'm not sure how hard it is, but if you are interested > in this issue, that's really nice. > > Thanks, > Naoya Horiguchi