Re: [PATCH v2 0/5] Move kvfree_rcu() into SLAB (v2)

["Paul E. McKenney" <paulmck@kernel.org>]

On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
> > Hello!
> > 
> > This is v2. It is based on the Linux 6.13-rc2. The first version is
> > here:
> > 
> > https://lore.kernel.org/linux-mm/20241210164035.3391747-4-urezki@gmail.com/T/
> > 
> > The difference between v1 and v2 is that, the preparation process is
> > done in original place instead and after that there is one final move.
> 
> Looks good, will include in slab/for-next
> 
> I think patch 5 should add more explanation to the commit message - the
> subthread started by Christoph could provide content :) Can you summarize so
> I can amend the commit log?
> 
> Also how about a followup patch moving the rcu-tiny implementation of
> kvfree_call_rcu()?
> 
> We might also consider moving the kfree_rcu*() entry points from rcupdate.h
> to slab.h, what do you think, is it a more logical place for them? There's
> some risk that files that include rcupdate.h and not slab.h would break, so
> that will need some build testing...

Moving the RCU Tiny implemention (or maybe even just retiring it in
favor of the RCU Tree implementation) and moving the entry points make
sense to me!

							Thanx, Paul

> Thanks,
> Vlastimil
> 
> > Uladzislau Rezki (Sony) (5):
> >   rcu/kvfree: Initialize kvfree_rcu() separately
> >   rcu/kvfree: Move some functions under CONFIG_TINY_RCU
> >   rcu/kvfree: Adjust names passed into trace functions
> >   rcu/kvfree: Adjust a shrinker name
> >   mm/slab: Move kvfree_rcu() into SLAB
> > 
> >  include/linux/slab.h |   1 +
> >  init/main.c          |   1 +
> >  kernel/rcu/tree.c    | 876 ------------------------------------------
> >  mm/slab_common.c     | 880 +++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 882 insertions(+), 876 deletions(-)
> > 
>