From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Chunyu Hu <chuhu@redhat.com>,
akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org,
ljs@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev
Subject: Re: [PATCH v3 3/5] selftests/mm: move write_file helper to vm_util
Date: Tue, 17 Mar 2026 12:00:45 +0100 [thread overview]
Message-ID: <fe849bdc-485b-4cac-88e5-d8c5c49f36dd@kernel.org> (raw)
In-Reply-To: <20260317094419.1429259-4-chuhu@redhat.com>
>
> int thp_read_string(const char *name, const char * const strings[])
> @@ -165,11 +140,7 @@ void thp_write_string(const char *name, const char *val)
> printf("%s: Pathname is too long\n", __func__);
> exit(EXIT_FAILURE);
> }
> -
> - if (!write_file(path, val, strlen(val) + 1)) {
> - perror(path);
> - exit(EXIT_FAILURE);
> - }
> + write_file(path, val, strlen(val) + 1);
Wondering what happens if a test like migration.c that uses
kselftest_harness.h ends up calling ksft_exit_fail_msg().
I assume the ksft_exit_fail* will simply set exit(KSFT_FAIL) and make
the __wait_for_test() helper happy.
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-03-17 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:44 [PATCH v3 0/5] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 1/5] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 2/5] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 3/5] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-17 11:00 ` David Hildenbrand (Arm) [this message]
2026-03-17 11:06 ` Lorenzo Stoakes (Oracle)
2026-03-17 9:44 ` [PATCH v3 4/5] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 5/5] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-17 18:37 ` [PATCH v3 0/5] selftests/mm: skip several tests when thp is " Andrew Morton
2026-03-18 9:22 ` Chunyu Hu
2026-03-18 11:32 ` Lorenzo Stoakes (Oracle)
2026-03-19 15:05 ` Chunyu Hu
2026-03-18 12:07 ` David Hildenbrand (Arm)
2026-03-19 15:08 ` Chunyu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe849bdc-485b-4cac-88e5-d8c5c49f36dd@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox