From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D381AC36002 for ; Wed, 9 Apr 2025 18:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D7A328009E; Wed, 9 Apr 2025 14:29:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5620428009B; Wed, 9 Apr 2025 14:29:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DAA328009E; Wed, 9 Apr 2025 14:29:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F62B28009B for ; Wed, 9 Apr 2025 14:29:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6052F1A134F for ; Wed, 9 Apr 2025 18:29:40 +0000 (UTC) X-FDA: 83315343720.29.95755EA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf20.hostedemail.com (Postfix) with ESMTP id 800261C000B for ; Wed, 9 Apr 2025 18:29:37 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="fgc6B/+t"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744223378; a=rsa-sha256; cv=none; b=oIHP15/cYUIQreoT8W6vfJs7/mNegqdTIfD8ZE7UdEnomPT7J6gQMnOmDwHb/lei9Bmn/C YJkIQRcyCZAYOXhyqSY4gJ6EuvrkPJWIVE1owB2n0mNnqzm7+xIGnWlSkMp5IIQW8ujDcS tryOkskHNYYUlPKCWv9O+wuLWxV2tJw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="fgc6B/+t"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744223378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q/bqVqy224cGEX4Q+bGswtTw2+aFSSbBz2tPihS9H14=; b=BYmq5pRW9a7jn3aHJeHQU5s+OuXT67zf6bw1uMVrasQR/7G+YEJhesWASPwL3GkQv/IR3G 8EoxdeEp9etNqjciGa902eY9/yOLEfVhthXre1Xp3aNh74D71yw7W6DB/jzTB/YTMDwNW8 1qZXs8NeDPTsS0RuDBiAEslLE3A4/UE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744223378; x=1775759378; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XjMuS67xjDtuXFVkxS/Yl4HEwhfGPgBq+HWzq93mKC0=; b=fgc6B/+tx5LY3Pwc6jXD7IEaIhwznFk/R2qoYLQQpCi5eNJwFJZ8DOe7 TQpCYdOcpoJinAJ2tahQgwUEb3kI2dzHNgXMIoy6UTcIVoHt+BBBrdbKG ShoI7cPsu+jnTFtF45pZuWjwTnGpux6xYjfg41M4W17ZTjIQwRoFh6GFB hZm5hsbeqEbSQQnRCJD9VBwkJI7sD5N13U0a/KQh79xGmZrhXi0w/Cw/f MBgrsVAog42YT/vbt2VZvuq1SVMflB1ilzeAkLNUhcuryWvYuNz0C1ML1 Y4T+RnpHzbdEYbKwaGXuhrDK3o7Y9jnpH5rDhhVHYwP52TH+nKL5B22Vo w==; X-CSE-ConnectionGUID: nZy3jTqbTAWESsGujNYy0A== X-CSE-MsgGUID: U1sR2OlXQjuI56gNJdaiPA== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="45429979" X-IronPort-AV: E=Sophos;i="6.15,201,1739865600"; d="scan'208";a="45429979" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 11:29:36 -0700 X-CSE-ConnectionGUID: OYu0cAbzScCswQ/sr0tt1w== X-CSE-MsgGUID: Wx9F5wsaQd2PJHrJj+iwYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,201,1739865600"; d="scan'208";a="159629133" Received: from sramkris-mobl1.amr.corp.intel.com (HELO [10.124.220.195]) ([10.124.220.195]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 11:29:32 -0700 Message-ID: Date: Wed, 9 Apr 2025 11:29:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/14] x86: Update the KASAN non-canonical hook To: Maciej Wieczor-Retman Cc: hpa@zytor.com, hch@infradead.org, nick.desaulniers+lkml@gmail.com, kuan-ying.lee@canonical.com, masahiroy@kernel.org, samuel.holland@sifive.com, mingo@redhat.com, corbet@lwn.net, ryabinin.a.a@gmail.com, guoweikang.kernel@gmail.com, jpoimboe@kernel.org, ardb@kernel.org, vincenzo.frascino@arm.com, glider@google.com, kirill.shutemov@linux.intel.com, apopple@nvidia.com, samitolvanen@google.com, kaleshsingh@google.com, jgross@suse.com, andreyknvl@gmail.com, scott@os.amperecomputing.com, tony.luck@intel.com, dvyukov@google.com, pasha.tatashin@soleen.com, ziy@nvidia.com, broonie@kernel.org, gatlin.newhouse@gmail.com, jackmanb@google.com, wangkefeng.wang@huawei.com, thiago.bauermann@linaro.org, tglx@linutronix.de, kees@kernel.org, akpm@linux-foundation.org, jason.andryuk@amd.com, snovitoll@gmail.com, xin@zytor.com, jan.kiszka@siemens.com, bp@alien8.de, rppt@kernel.org, peterz@infradead.org, pankaj.gupta@amd.com, thuth@redhat.com, andriy.shevchenko@linux.intel.com, joel.granados@kernel.org, kbingham@kernel.org, nicolas@fjasle.eu, mark.rutland@arm.com, surenb@google.com, catalin.marinas@arm.com, morbo@google.com, justinstitt@google.com, ubizjak@gmail.com, jhubbard@nvidia.com, urezki@gmail.com, dave.hansen@linux.intel.com, bhe@redhat.com, luto@kernel.org, baohua@kernel.org, nathan@kernel.org, will@kernel.org, brgerst@gmail.com, llvm@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, x86@kernel.org References: <8416848c-700a-4ff0-8a22-aa62579d60cd@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 800261C000B X-Stat-Signature: bz7fj1fzrqq75qnso96gs17ij9sfc3bx X-HE-Tag: 1744223377-999843 X-HE-Meta: U2FsdGVkX1/KnPnKNlE4/E181xW+EIFW1MWJJ7ovQT6eb9Qn8H7435n7amHp0WClzxVxvigPu1628CJ9+1Wu4rVKTtxiTQmyHiO0jALuil0EpQYbPp2QRqT8xWgdmjeofra3hyjkas3PgMhPIPhevNL/i792qFjgKYpazTnmdNgsvzri4iJl8BQnLNXjh+mTS/1KU6p0YVSFk7VYkRnvoLUFbuh+sK9oa95U6fsFJ7Bbf8rMejhKSv3hrI/k2RplXeSSqNlTWTbDdFhXyayIcLPJCu5QhYD891pfPo2xImhL7SJmTyFslXWs626fdzJ6W98HONGCXcAr4g2JbHnifnM61kjh5mkuBML2gmczp7Th55HDZebZUY4zmjO7JLIPhv2LUGplRppKTUc37PbVxzBTwgr0GfP2dx2ij8R6jndyc5ts1cUkzgtVKD/9QMMQ+q0kFEhCzf+9QQhfvI2yxflQbTzbo6/aWAI+Ud6p79+bl9Wmblj0354J+byXx4SyLiMplPUFuYYjEn84LTNC1Wa7SQ2ePmfJ6UYbQd1NT3mS6sBSPi+RkLhOHuT22oi8RyZkeEN/w6HIOcDbzE0KAdE7e/Ps4nvfeTXOje7ZGmQqR/Arla+Dozuclye8lZHTo7f6RLizPu50CEd+KOjC4S1AjKVNMT43pSAppQ1cBHcUZXBm/NRrSkz7hJAYjfbb9+nN9X6D4duEwXWTfG+0xcFTZvDHO6piJACRqGw5t8SCre+xcUgq7ZvNlH4/VERtZLNhJ07giYTY40EJ1awUggzPjUrSSpagzKPL0Uc7whTCT2p1z42pxQP5HAUfB/1qf4IttoDN3220OpPR7bCyNL12eR0wBFDAars4wv/s9zhau78fwKrP4DGeHay0Xy/DzyyivYzjnuUffrB4qzID8pCpoAsifu7kZJ3RtN/344AI68R5Vt8OPMxeh4oW+1f+tGAUCTYwOAQ4KAsv1V2 XwjlSZLm osOr9lBnimPNy2SwYtQHH9mwJz1rMp38YUG5KTavrryMCryBKNiJCtYSi5W8rVWsWihRLP+Y6BZbOqaSllaQpnTO+p03WWcLtYRaMi1UttSf28zNLnkhgINr+UIEnXkJGcSgCNAX7fiNPj5WRkkcl48ZfoinbC/Qm7S6iyjvm6b6f+bI1uMq35eF6qQJBLTXFTX2cqdkMS4RrcWVrdomZeRfofkZW3/MRFixoo8enjM811Nd4Iu+DFR1xS9WoREUJFucsRvDPx5Dr1hwQGfYXPPPfKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/9/25 07:34, Maciej Wieczor-Retman wrote: > Yes, I like it more than just generating the addresses in the parenthesis. What > do you think about this naming? KASAN prefix and [k/u]addr since it's not really > the lowest/highest address in the whole LA, just in this KASAN compiler scheme. > And I changed 1<<56 to 2<<56 so it generates 0xFE00000000000000 instead of > 0xFF00000000000000. > > #define KASAN_HIGHEST_KADDR (void *)0xFFFFFFFFFFFFFFFF > #define KASAN_LOWEST_KADDR (void *)(KASAN_HIGHEST_KADDR - \ > (2<<56) + 1) > #define KASAN_HIGHEST_UADDR (void *)0x7FFFFFFFFFFFFFFF > #define KASAN_LOWEST_UADDR (void *)(KASAN_HIGHEST_UADDR - \ > (2<<56) + 1) Yes, that is much better.