* [PATCH v2] mm/memory_hotplug: use pgprot_val to get value of pgprot
@ 2022-04-26 7:13 liusongtang
2022-04-29 3:27 ` Anshuman Khandual
0 siblings, 1 reply; 2+ messages in thread
From: liusongtang @ 2022-04-26 7:13 UTC (permalink / raw)
To: akpm, anshuman.khandual
Cc: liusongtang, linux-mm, linux-kernel, nixiaoming, young.liuyang,
trivial, wangkefeng
pgprot.pgprot is a non-portable code, it should be replaced by
portable macro pgprot_val.
Signed-off-by: liusongtang <liusongtang@huawei.com>
---
v2: add 'memory_hotplug' in the subject line
v1: https://lore.kernel.org/all/a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com/
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 416b38c..bf7d181 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
int err;
struct vmem_altmap *altmap = params->altmap;
- if (WARN_ON_ONCE(!params->pgprot.pgprot))
+ if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
return -EINVAL;
VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
--
2.12.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm/memory_hotplug: use pgprot_val to get value of pgprot
2022-04-26 7:13 [PATCH v2] mm/memory_hotplug: use pgprot_val to get value of pgprot liusongtang
@ 2022-04-29 3:27 ` Anshuman Khandual
0 siblings, 0 replies; 2+ messages in thread
From: Anshuman Khandual @ 2022-04-29 3:27 UTC (permalink / raw)
To: liusongtang, akpm
Cc: linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial, wangkefeng
On 4/26/22 12:43, liusongtang wrote:
> pgprot.pgprot is a non-portable code, it should be replaced by
> portable macro pgprot_val.
>
> Signed-off-by: liusongtang <liusongtang@huawei.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>
> ---
> v2: add 'memory_hotplug' in the subject line
> v1: https://lore.kernel.org/all/a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com/
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 416b38c..bf7d181 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> int err;
> struct vmem_altmap *altmap = params->altmap;
>
> - if (WARN_ON_ONCE(!params->pgprot.pgprot))
> + if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
> return -EINVAL;
>
> VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 7:13 [PATCH v2] mm/memory_hotplug: use pgprot_val to get value of pgprot liusongtang
2022-04-29 3:27 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox