linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joao Martins <joao.m.martins@oracle.com>
To: Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	Dan Williams <dan.j.williams@intel.com>,
	Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v2 2/2] m/hugetlb: Rename ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
Date: Tue, 11 Apr 2023 18:34:32 +0100	[thread overview]
Message-ID: <fe5ef8b2-f89f-3be0-c29a-2848442c8681@oracle.com> (raw)
In-Reply-To: <fc712c85-54ff-391e-ec22-a3968dcf24fc@linux.ibm.com>

On 11/04/2023 17:14, Aneesh Kumar K V wrote:
> On 4/11/23 9:22 PM, Joao Martins wrote:
>> [subject line should be mm/hugetlb as opposed to m/hugetlb]
>>
>> On 11/04/2023 15:18, Aneesh Kumar K.V wrote:
>>> Now we use ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP config option
>>> to indicate devdax and hugetlb vmemmap optimization support. Hence
>>> rename that to a generic ARCH_WANT_OPTIMIZE_VMEMMAP
>>>
>>> Cc: Joao Martins <joao.m.martins@oracle.com>
>>> Cc: Muchun Song <songmuchun@bytedance.com>
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>>
>> +Mike from hugetlb
>>
>>> ---
>>>  arch/arm64/Kconfig     | 2 +-
>>>  arch/loongarch/Kconfig | 2 +-
>>>  arch/s390/Kconfig      | 2 +-
>>>  arch/x86/Kconfig       | 2 +-
>>>  fs/Kconfig             | 9 +--------
>>>  include/linux/mm.h     | 2 +-
>>>  mm/Kconfig             | 6 ++++++
>>>  7 files changed, 12 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index 27b2592698b0..77d9713dcd9c 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -100,9 +100,9 @@ config ARM64
>>>  	select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT
>>>  	select ARCH_WANT_FRAME_POINTERS
>>>  	select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
>>> -	select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
>>>  	select ARCH_WANT_LD_ORPHAN_WARN
>>>  	select ARCH_WANTS_NO_INSTR
>>> +	select ARCH_WANT_OPTIMIZE_VMEMMAP
>>
>> Why don't you just change the line you just deleted?
>>
> 
> Those config select statements are sorted? 

/me facepalm

Totally missed that.


  reply	other threads:[~2023-04-11 17:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 14:18 [PATCH v2 1/2] mm/vmemmap/devdax: Fix kernel crash when probing devdax devices Aneesh Kumar K.V
2023-04-11 14:18 ` [PATCH v2 2/2] m/hugetlb: Rename ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP Aneesh Kumar K.V
2023-04-11 15:52   ` Joao Martins
2023-04-11 16:14     ` Aneesh Kumar K V
2023-04-11 17:34       ` Joao Martins [this message]
2023-04-12  3:43   ` [External] " Muchun Song
2023-04-11 14:35 ` [PATCH v2 1/2] mm/vmemmap/devdax: Fix kernel crash when probing devdax devices Joao Martins
2023-04-11 15:20   ` Aneesh Kumar K.V
2023-04-11 15:50     ` Joao Martins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe5ef8b2-f89f-3be0-c29a-2848442c8681@oracle.com \
    --to=joao.m.martins@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox