From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB61C433FE for ; Mon, 10 Oct 2022 03:48:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 916A06B0071; Sun, 9 Oct 2022 23:48:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C5D26B0073; Sun, 9 Oct 2022 23:48:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 766F66B0074; Sun, 9 Oct 2022 23:48:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 655DC6B0071 for ; Sun, 9 Oct 2022 23:48:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 33C4B1C62E2 for ; Mon, 10 Oct 2022 03:48:12 +0000 (UTC) X-FDA: 80003656824.20.A13CA83 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf30.hostedemail.com (Postfix) with ESMTP id C48988001F for ; Mon, 10 Oct 2022 03:48:11 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id n7so9325476plp.1 for ; Sun, 09 Oct 2022 20:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=BHae+p8OlAHp+V5lhftHxU9vRo8UGtSzWUWZi2uZEnk=; b=P7t0mqMCOuB5RvBoKMUGbz+MzOHE+IGp1gucnTKj1tV4clKyMILD90ZzH0HHUe+HBg jyHFRibs0rWZOQm891YZFCRDawzdORXxL2BWf0QY+FZd3HC2ouL0WBwFVGe6SVLneJT+ wTSe4hdw8bDqSGiMymGyy1VLRZqAE1KEZ0mH/MOIQ+1758iLP2zNCh8HKzpy3ygE78Z3 dKPRy13AyfIHxhGc0PLgBiaok4ewGk1uf9H2FjxtBFMl/DLg8C2JHzfyBy67K1OrNcDH usWTR5AdwX6Lgh9Py1UtgnDI16vKpTudE3KLZ64VkHtBXTJAGlFrS+COMiodTwY1VKgC h9tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BHae+p8OlAHp+V5lhftHxU9vRo8UGtSzWUWZi2uZEnk=; b=7cSes9eMB1Iu3kodoPNORzIBTWDYpDd4t7RKVo1n75MCoAMGMCcN6vlHhPBNCCW5yF r5lZkgK2ckZRS1vG10a5lLFsEbBwx2UUxGP4gCISdyIXltYcgJbIofVP9Lbl0UK9jEzN 2Kpv2hOxsoNJ5xOltxvyAI8UBwmXz6vYBp1ghLZj8RKPrkEndNViR4VhCkgSMKu588WX 0cxevhgU5KGxZSEwpdbTrCNHor8CduBpyRHcWLBiR/aRtsZkbHuYmJjVF5tchTViMb6s rYpzvveztk7OjRXMYsCj69EWkGFc4YbWtLMATYmr5tRAAxYsSSY9lprOhd6ImQiA9KoJ SJ2w== X-Gm-Message-State: ACrzQf09YArbXhxqiiMI8nZiQ8074y3G++MkCXPIMB47RxmrqkGYQrrv eqE15QJ0QtlrnTSy7T65hc2+Tw== X-Google-Smtp-Source: AMsMyM4MXwciU8DYG7uPa2SAOYMKJ8KEgCki82/BHRPDAigNEfSbvZ116To5uehaJ23f51x2THoeFQ== X-Received: by 2002:a17:903:1205:b0:178:ac4e:70b8 with SMTP id l5-20020a170903120500b00178ac4e70b8mr16920946plh.52.1665373690619; Sun, 09 Oct 2022 20:48:10 -0700 (PDT) Received: from [2620:15c:29:203:5c2c:f18c:2a4e:44d2] ([2620:15c:29:203:5c2c:f18c:2a4e:44d2]) by smtp.gmail.com with ESMTPSA id 65-20020a630244000000b0045913a96837sm5293845pgc.24.2022.10.09.20.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Oct 2022 20:48:09 -0700 (PDT) Date: Sun, 9 Oct 2022 20:48:08 -0700 (PDT) From: David Rientjes To: Alexander Aring cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH] mm: slab: comment __GFP_ZERO case for kmem_cache_alloc In-Reply-To: <20221008020312.1932347-1-aahringo@redhat.com> Message-ID: References: <20221008020312.1932347-1-aahringo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665373691; a=rsa-sha256; cv=none; b=WXUtS4qdT8TWl2E++bE/w+akIKj5SglI3XF9jDlgZHQWsFAat7DY+8ojzZKAKl3UVBzcIO 60OvKMoH/7nqUvhlsqu9WYR1hre3Oy+XjHWKgyKWoQMfkgdEIgJviNhzoo8ESgxJD0RH7K eAFOAOWu3/8YDyMAYQcy8o5hLRLn1R8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=P7t0mqMC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of rientjes@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665373691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BHae+p8OlAHp+V5lhftHxU9vRo8UGtSzWUWZi2uZEnk=; b=3MX/tB8YoErQ6FYKfTCxma8cRNeR0eVCwrDav59wklqqHzSjcFO0KpyLkxAmAx5ijMgK0T Q1R9dpABnd2UNIxWAz87gBWF51fPOyeYjZdKffvms1PtSKD9giktjgjIU63yW21HVUDPVM dRl8SYUnuluhjYp6f3KcSJIDJMsL/ok= X-Rspam-User: X-Stat-Signature: gkhq9wkhh6xx7gbmeu6jmkftqo6j74i1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C48988001F Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=P7t0mqMC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of rientjes@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=rientjes@google.com X-HE-Tag: 1665373691-101848 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Oct 2022, Alexander Aring wrote: > diff --git a/mm/slab.c b/mm/slab.c > index 10e96137b44f..7a84c2aae85a 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3482,7 +3482,8 @@ void *__kmem_cache_alloc_lru(struct kmem_cache *cachep, struct list_lru *lru, > * @flags: See kmalloc(). > * > * Allocate an object from this cache. The flags are only relevant > - * if the cache has no available objects. > + * if the cache has no available objects. Except flag __GFP_ZERO which > + * will zero the returned object. Minor nit: it's probably better to do "... has no available objects, except flag ..." and not seperate sentences. After that is done, feel free to add Acked-by: David Rientjes