From: David Rientjes <rientjes@google.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, vbabka@suse.cz,
roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [PATCH] mm: slab: comment __GFP_ZERO case for kmem_cache_alloc
Date: Sun, 9 Oct 2022 20:48:08 -0700 (PDT) [thread overview]
Message-ID: <fe5780fe-7d52-53e1-4572-38112c4f69e8@google.com> (raw)
In-Reply-To: <20221008020312.1932347-1-aahringo@redhat.com>
On Fri, 7 Oct 2022, Alexander Aring wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index 10e96137b44f..7a84c2aae85a 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3482,7 +3482,8 @@ void *__kmem_cache_alloc_lru(struct kmem_cache *cachep, struct list_lru *lru,
> * @flags: See kmalloc().
> *
> * Allocate an object from this cache. The flags are only relevant
> - * if the cache has no available objects.
> + * if the cache has no available objects. Except flag __GFP_ZERO which
> + * will zero the returned object.
Minor nit: it's probably better to do "... has no available objects,
except flag ..." and not seperate sentences. After that is done, feel
free to add
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2022-10-10 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 2:03 Alexander Aring
2022-10-08 4:38 ` Hyeonggon Yoo
2022-10-10 3:48 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5780fe-7d52-53e1-4572-38112c4f69e8@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=aahringo@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cluster-devel@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox