From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947A1C432BE for ; Wed, 11 Aug 2021 18:46:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B93C6109F for ; Wed, 11 Aug 2021 18:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B93C6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 852CE8D0001; Wed, 11 Aug 2021 14:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8026E6B0072; Wed, 11 Aug 2021 14:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F1238D0001; Wed, 11 Aug 2021 14:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 53F016B0071 for ; Wed, 11 Aug 2021 14:46:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F2D51183C77E1 for ; Wed, 11 Aug 2021 18:46:28 +0000 (UTC) X-FDA: 78463680456.05.37CDDF8 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf11.hostedemail.com (Postfix) with ESMTP id 6BAB8F0052FB for ; Wed, 11 Aug 2021 18:46:28 +0000 (UTC) Subject: Re: [PATCH 03/18] ARC: mm: move mmu/cache externs out to setup.h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1628707586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SK25dEcn466Z3Vi0DqLxIySdCp5Mv9jbvw0c3iJwG8U=; b=ErI1vkw1xnLMlIRzSuseZUPuXhb4a1szsgUdHWTiWa11I+f0/0hXcmuO8ezyEZFEr+Ug/B LQ2mc53++4EVYazWQ9RdU9yCcvWmN1NnHGek2T0hMrH8lGTiC1axkwon0TTjv6uR6jvYNA TgKsIEgUiph6Nmrwms/LjP5RJ6KlDkc= To: Mike Rapoport Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual , Vineet Gupta References: <20210811004258.138075-1-vgupta@kernel.org> <20210811004258.138075-4-vgupta@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vineet Gupta Message-ID: Date: Wed, 11 Aug 2021 11:46:21 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: vineet.gupta@linux.dev Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ErI1vkw1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of vineet.gupta@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=vineet.gupta@linux.dev X-Stat-Signature: ikafyifj77yy7i6mh3stfrwkxi4t1xht X-Rspamd-Queue-Id: 6BAB8F0052FB X-Rspamd-Server: rspam05 X-HE-Tag: 1628707588-534323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 8/10/21 10:10 PM, Mike Rapoport wrote: > Hi Vineet, > > On Tue, Aug 10, 2021 at 05:42:43PM -0700, Vineet Gupta wrote: >> Signed-off-by: Vineet Gupta > Hmm, this one seems odd. Try https://www.kernel.com/ ;-) Oops, last minute switch to my kernel.org address - this update was not atomic ;-) >> Signed-off-by: Vineet Gupta >> --- >> arch/arc/include/asm/cache.h | 4 ---- >> arch/arc/include/asm/mmu.h | 4 ---- >> arch/arc/include/asm/setup.h | 12 ++++++++++-- > A sentence about why these move would have been nice. Sure ----> "Don't pollute mmu.h and cache.h with some of ARC internal bootlog/setup related functions. move them aside to setup.h" Thx for taking the time to review ! -Vineet