From: Miaohe Lin <linmiaohe@huawei.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
Andrew Morton <akpm@linux-foundation.org>,
<zhengqi.arch@bytedance.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
David Rientjes <rientjes@google.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/page_table_check: fix accessing unmapped ptep
Date: Fri, 27 May 2022 09:10:53 +0800 [thread overview]
Message-ID: <fe21e0c9-50d3-0a4b-00b4-22a5dfd6711e@huawei.com> (raw)
In-Reply-To: <CA+CK2bBJ3baj2Qt+9Wy1r==_Uym_UZJ+S-HRwFAsspPamctk_Q@mail.gmail.com>
On 2022/5/27 2:31, Pasha Tatashin wrote:
>>> Miaohe, please store the ptep, or maybe drop this patch entirely.
>>
>> I think it's best to fix it. I rewrote the changelog as
>>
>> : ptep is unmapped too early, so ptep could theoretically be accessed while
>> : it's unmapped. This might become a problem if/when CONFIG_HIGHPTE becomes
>> : available on riscv.
>> :
>> : Fix it by deferring pte_unmap() until page table checking is done.
>>
>> I'll retain the Fixes:. This doesn't imply cc:stable in MM, and anyone
>> who backports the original patchset will want to know about this fixup.
> Makes sense.
>
>
>> And I queued a fixup for the thing Matthew noticed.
> Thank you Andrew.
>
Many thanks for all of your comments, review and fixup! :)
> Pasha
> .
>
prev parent reply other threads:[~2022-05-27 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:33 Miaohe Lin
2022-05-26 13:04 ` Qi Zheng
2022-05-26 13:11 ` Pasha Tatashin
2022-05-26 13:23 ` Qi Zheng
2022-05-26 13:17 ` Pasha Tatashin
2022-05-26 13:34 ` Matthew Wilcox
2022-05-26 13:37 ` Pasha Tatashin
2022-05-26 18:15 ` Andrew Morton
2022-05-26 18:31 ` Pasha Tatashin
2022-05-27 1:10 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe21e0c9-50d3-0a4b-00b4-22a5dfd6711e@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox