From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B986EC4345F for ; Thu, 25 Apr 2024 11:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A1BF6B008A; Thu, 25 Apr 2024 07:23:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451676B0092; Thu, 25 Apr 2024 07:23:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33FF76B0093; Thu, 25 Apr 2024 07:23:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 16A2F6B008A for ; Thu, 25 Apr 2024 07:23:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A295B80521 for ; Thu, 25 Apr 2024 11:23:19 +0000 (UTC) X-FDA: 82047818118.22.D59A5CA Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf18.hostedemail.com (Postfix) with ESMTP id BCB7D1C0006 for ; Thu, 25 Apr 2024 11:23:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714044197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QmP50gGXCxsu+FiVVlNNWrALfSyQwARmtPzVd76NU8w=; b=PpyoFmyZ3W1OD8Cbfbt/pqgWdzJVJdyf0PXEy4b2ZRV12WNqI8GRIy6quwW5WA3YTzBWzF BdRm0jnHafaRi2G1FTG/n7dN+byMCexlFuCIeYdN8a6Pf2PK3q5vXEiG5JylcGX7Qe3A+k Uc3491Z+3vwl1bhGhzSdB5YFxnhTxLw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714044197; a=rsa-sha256; cv=none; b=w444UeyjyrKnaCU27Cvm4o25QMFUvt+OEu18odZ5B50L978A+Nh/h7G5cbtRZPnicNK+a9 CIIL2PYFM+J/WOP2/w/E92FvXl19TSll4q5WiH2zr8QZERhV8S01dtVU4e+dwRJzi8WwZ/ hdLSI4DFu9dOFf1Zm2i5LjTvq3PmE1o= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VQD1N3HVFzNnRT; Thu, 25 Apr 2024 19:20:40 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 02F0D1800AA; Thu, 25 Apr 2024 19:23:13 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 19:23:12 +0800 Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function To: Andy Shevchenko CC: Rasmus Villemoes , Andrew Morton , , References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> From: Miaohe Lin Message-ID: Date: Thu, 25 Apr 2024 19:23:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Queue-Id: BCB7D1C0006 X-Stat-Signature: enfryjk6cdcf3mzetxahxohpf8ybc8kj X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1714044196-97456 X-HE-Meta: U2FsdGVkX1/BgN5JDLCw1rczQG1YPm1EmrmU8HIwKYTzFYdkqr7B4+MHLzXgCTaWrLfFJiUmobQMZQ6VFzPxyXJlIwRMFP7ZRuw6DoI/xKtI4PjeQHhATT5hlEVVXNTeEbQHBIKu+9fmiYG9HvkBE3d3DnJd9WyABIebs4TCtUCjyGBIW8CnYIgcgkLawLtCXBtc66togrIp8iP7d1/RnMKfDhNsMtGLH0VvNBcC0rwv28ZF7pqTcgUWO8Q1Gibvn+l5Rmpj+ORFMfSAneE/2gQXFNrz2hWx9T1oKLm1rPAMs0pASVzbyZykn42PO1NpsiP51rQqktaFPOsGqnBVZD/jmcWrzvCeOmAXONiFpWK4nmcJ5VyAIaURl9GPJyg9dhwGg+XZnIGe0fBapVvOFzkGqwJhI5JwiCWycP2kwpvw/jacJIkM/bQbJ6rRKJNjnUWVq34tdVqX8LKtvbcPn5jTE2vu0q5OiMRZZz1VYBgVXgy7IijgqFZbdeedJjm0DrREiVTQvJajPGHM0cMQ27j9oAJZ0nK2Ou1bMQ/V95OtCgiuWRnkda/k/+YD8hdfwj3D6b1eN6yip/tCEw3VYL6UZ+78VWlDiGq++jC/AHoOndjJByluFvSQq1j1OToHnBHInDVFCu9evD2SPXkI4DaL6MMIGnwhO23nbiXdB1qlOWdFdGdriNplj73wC/BEtOYW88SZaGVCiPf7a/+oKpSwpEtfNVfUmEYyONFP95MT+hWA3KyveBZB+qiahVm04q0tVkj3N7WSE7nB18Ual7Fgm3i9Wf9CKUEiKiT/eVoGZLp5nwEJFz00cZbgxOADvLMj+G2p5jj8/C1xZDWTlvdy/JU5jUDMGjWhqCxS3xxls+rNnRTaVV0VZblUIz3G5VYiZ6fJqsZ1hFFHqbdnmVbjW+SvwRNCKvMPGjwuHG98BB5B61cKlLL5kSqcI/DtGcv3nHGU8dCs2XWk5np J872Yt+t i2hsNmOZoZTyrZpSGUD0+RIU1b/JsFcZZHJWtFf86FlqnJVoO082vVJdSVzDLvCEESi4KxysWP3ZQg+8k7ENwdgr1R/qRMUAJAke+ZsMHu7HpMs7p4Po7VWOvDYZ2qp7EbEeF65b+q21Ojorfnunx9Q0PcT/8IzyKZ/LuWg9UpPR8pjNWEtlbtq+yOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001166, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/25 17:45, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 12:15:32PM +0300, Andy Shevchenko wrote: >> On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote: >>> On 2024/4/24 0:14, Andy Shevchenko wrote: > > ... > >>>> In some configurations I got >>>> mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] >>>> Becuase the only user is guarged with a certain ifdeffery, >>> >>> guarged? >> >> A typo, thanks! > > FWIW, Andrew fixed this along with "Because". Thank you, Andrew! Got it. Thanks both. . > >>> ifdeffery? >> >> Yes, this is established term. >> >>>> do the same for add_to_free_list(). >