From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B28DC47422 for ; Wed, 17 Jan 2024 05:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEA736B00C4; Wed, 17 Jan 2024 00:00:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A416B00C5; Wed, 17 Jan 2024 00:00:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D89366B00C6; Wed, 17 Jan 2024 00:00:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C8AC06B00C4 for ; Wed, 17 Jan 2024 00:00:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A2AE74060B for ; Wed, 17 Jan 2024 05:00:34 +0000 (UTC) X-FDA: 81687602388.22.3891786 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf16.hostedemail.com (Postfix) with ESMTP id B1F9118001E for ; Wed, 17 Jan 2024 05:00:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=j98ufzQX; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf16.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705467632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1zxNC559dfRs3YH8NYtW7aCgyNuEmvy1lh86IHQbS04=; b=aRipkifOzGDj0br4tmGZ339TprfgvV8D2pr0W/eleDw1ArUQAysfPFWxfpG9UIsRHfoHHf YWK7YVmflX6R3mSBkEKo45+aRy5HLaDZj1Ubul6MlCTbGfgYPvy4VP2aRJnyw5tK4yCSW/ jLYNWYU+obvFfg+ehFvZoVwticY9omk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=j98ufzQX; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf16.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705467632; a=rsa-sha256; cv=none; b=fofgTMYRiZNvRkjZxBeZsS9A53AXHMNwrR9hcjyGb2s6m02jMqwgPeGltbqeDci+62fKPh 6OMUoSlgibdpCyRngh5gMjn898GLbkTa6geYeQIXiM0denl1BOuG2h5Dj6IvlKuZjJ67AF qAGgHdMr3eZOd5QSbapf9eiQV2d7NjQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705467631; bh=zULSsRwTQq8k5rydVDaY+DT96t5URjDNTyZA/KomP58=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=j98ufzQX43Ks4+QXuqTCA+FMbw1Gr0KuHxDORHQ0W1A/xDete07+1DgDqrKcywrzJ Oep/Az7gugCKeEYMTIv5UyT0X3h1xwfmbuAuqKy+kCxe4QP3Ut9qrZ7r6i5isF2wcO xCzGxSxCvp4F5CpeSwBFviaT+j23PhyNNJrobi9pPqasRbxoAjeFPlJ12KX79Hqm5F GOwe+Hg53vBxIWIKO1Vb5nthbc80SYi4qo2ieYsnlHrMQdV2AlpKFxrVgqjKDVq6zx MoyRYXsfGNKPiay9lk+NdD0E8P7D4dLfKDvL9cN+nNOrH5fEQfEKgbZr6O6zAPht0w QmOZfmUxbAe0g== Received: from [100.96.234.34] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 79914378206D; Wed, 17 Jan 2024 05:00:29 +0000 (UTC) Message-ID: Date: Wed, 17 Jan 2024 10:00:38 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , "kernel@collabora.com" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] selftests/mm: switch to bash from sh Content-Language: en-US To: David Laight , Andrew Morton , Shuah Khan References: <20240116090455.3407378-1-usama.anjum@collabora.com> <0d5811eafd00496d98e88afe847fb8be@AcuMS.aculab.com> From: Muhammad Usama Anjum In-Reply-To: <0d5811eafd00496d98e88afe847fb8be@AcuMS.aculab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B1F9118001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: eu9sqhjpf9iqpuoxbx4xngiocpbzuc16 X-HE-Tag: 1705467632-3153 X-HE-Meta: U2FsdGVkX18yZ4G7QBZOBExuuibkxpcsAuAokWAQXoQWPS7RuI0PunyKCwoQ6XPmvWcWh+sOKnOJdy9V2z+JB6YWpYuJjEjbSszw5WtspQeZpHubCBP7Q3s53GysnLlNyH6U44NhKLrzj+PqlYtJokyQWoSiARUSSun1YpNE07xCJBzoeXUTUOoZxPIpZHWVEJwViOni/4CScrDmcnzmhD0UjoO7dn5b9SqT0yyomGrj/uh22ungxWBe8hHugwsR0LGaVCAFjOpCF10poLsTaEinDmKsI21erLbEyjPjU7G7qGHBaFisagK4BR4WvO01MzktacWMHPsWzJDiqx6h2zc/6Kpgq5njhhPBxiIjnvV8D5Y12W1Cd6fhhS442I6CvGqLxbC56GcYbsmR1w/E9UvxcGjY3PQBX0mCZAWCxYHx+irhXrgRR7UwZSz3MnYmtKq0wUCCOPE5t9MDzY0YSuVVQjLqRZwMmWZSfvS75yd6vKzDO/b0ZQ4OML+DathjSu7mm1sr+K7XdmNVvRqR73tFoA5Zn9enZEUfjieKwgho+zO/iqvqtzxrkRRcZfidvIGZMm7RLqQddamAENhDbh4gGURbsjXiU1ywEsHr5FrLhFn92/t8+3ADrDzpliwSIv3NeS+vaDsSDeknmfzHtZ3LI1CgsoJano+qvAl38JPiuLVnHHL6cGYBXpm2BtAK/0bMQjk+TyWY2ZIY1CiUN1M00gWkZIq6QU7uAspgZyIqQbA8FLJU2A0T4zBmyhrO+tTcYQx5tVGjP3O/VmUjIDtGp5ug7f/VSynb3tAKnJjG/ksx44V5ih5eITkWKut9NsI12RLKUaac0VosOzRBG/MmX5BYMBv/x+zTSS5cZ8BWqD5l6piRRGrRmMzgHhzUQ74/nVq2RZ8D/CsHoGnGKz8IKr22vgIhplkhLLOQk8dr/cb7h9oorfFlJvZk+YxXFD9ROmolaKGNjAAPzAW mHm0lDZp W2X2oYi+fbpGDBYhb4jP0wzDppSGKy6eJfvvLX7G6hoblBu6n+dQrBEOendUs2bCKKVjmtBGiFC3Fu8kjVo82L2gKnyl0AzaYhQ0oQJ/aEjUCVVs2TQEuuAHQZa+Vb/UIHH41F4AtsqvaNcTQdjdp+kv+cJkXJnH/NohT7Zhd0x2rl1918DXspEfokqFj6KIv3cDaeXjptswPXpvOSdDyJWADJf/HF8D+mDQvBtO9A1BrR8rYRNXVA9FkVemm9VmEVkugL8zHrO3TnVejXsGobT0Gy0GRFtaFODSZ26jXz1Iri4BbeUoH3EgJ5lfbQXRWAMbio8eeoPozx5XblAX0q2aPlHWkiemL7HgNJ1a+GqTKXVchRNFYpZGMQ30YPbWZGMaA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/16/24 9:52 PM, David Laight wrote: > From: Muhammad Usama Anjum >> Sent: 16 January 2024 09:05 >> >> Running charge_reserved_hugetlb.sh generates errors if sh is set to >> dash: >> >> /charge_reserved_hugetlb.sh: 9: [[: not found >> /charge_reserved_hugetlb.sh: 19: [[: not found >> /charge_reserved_hugetlb.sh: 27: [[: not found >> /charge_reserved_hugetlb.sh: 37: [[: not found >> /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected >> >> Switch to using /bin/bash instead of /bin/sh. Make the switch for >> write_hugetlb_memory.sh as well which is called from >> charge_reserved_hugetlb.sh. > > Why not just fix the script? The Bash is being used in all or most of the selftests. I'd seen other similar [1][2] patches floating around which are converting /bin/sh (pointing to dash) to /bin/bash. [1] https://lore.kernel.org/linux-kselftest/20240110141436.157419-2-bpoirier@nvidia.com/ [2] https://lore.kernel.org/linux-kselftest/20231229131931.3961150-1-yujie.liu@intel.com/ > Looks like most of the [[ ... ]] could be [ ... ] > although some might need to be [ -n "$cgroup2" ]. > The delete the 'function' keyword another bash-ism. > > It's not as though you are trying to run on a system > when /bin/sh is a traditional (aka non-posix) bourne shell. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > > -- BR, Muhammad Usama Anjum