From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351CCCD128A for ; Mon, 8 Apr 2024 08:32:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5C56B0092; Mon, 8 Apr 2024 04:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8E366B0095; Mon, 8 Apr 2024 04:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94CC76B0096; Mon, 8 Apr 2024 04:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7608B6B0092 for ; Mon, 8 Apr 2024 04:32:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 346CDA0800 for ; Mon, 8 Apr 2024 08:32:07 +0000 (UTC) X-FDA: 81985697094.14.132BF24 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf15.hostedemail.com (Postfix) with ESMTP id 44C1DA0006 for ; Mon, 8 Apr 2024 08:32:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712565125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2pY8oWkHbDSd61fhfHuDufnTCsO5ZnIy9x1GrwC8r14=; b=QJSrmCE/OVCRudAYEuzQIf+dM9YGwK4DsfKRo3cySMs3x5ij1Uh8Vi7hf1PsfMdbQrmXzi yJba65Hj5OgJnP6+KmF2963UWRc8HlXqsWMDQw6JqK/q4VyxCN8Vlu9pPbq/NmwLPEuLB1 w85/vhh37gp7POYlJOjDehmUhhtqQhs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712565125; a=rsa-sha256; cv=none; b=oQ/Tn9iAp5pOIVpfCLIBQinjvpLBDvoBotv7WXjKznZWGo3BRT2Q14AnRiY0HcTXJPdfaW dprkCVsXDkdcgrCcrUGDu0yTgNKnLk/kWFOSq7D4LD3SjrMUQuggNPUMrbqlhetkulD5od Vj3MFYMJlomJprRQvvuzewTUvPWl7AQ= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4VCj3Y0W4Cz21kdL; Mon, 8 Apr 2024 16:31:05 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 95CA918002D; Mon, 8 Apr 2024 16:31:59 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 16:31:59 +0800 Subject: Re: [PATCH] mm,swapops: Update check in is_pfn_swap_entry for hwpoison entries To: Oscar Salvador CC: , , David Hildenbrand , Peter Xu , , Tony Luck , Andrew Morton References: <20240407130537.16977-1-osalvador@suse.de> From: Miaohe Lin Message-ID: Date: Mon, 8 Apr 2024 16:31:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240407130537.16977-1-osalvador@suse.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Queue-Id: 44C1DA0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: aatfhmea45hzqn4igcdbexsjhyjfj9s5 X-HE-Tag: 1712565123-966786 X-HE-Meta: U2FsdGVkX18yRO1YerA/ISNnYlRujih3UvGXi6zYHZm+tgu+6687CZ08aomfjj43Z+GO0WD7G1gcfX/F4uHZWSUuonQsLKU7W29fzBaB279l0lH9L33XPoCkxptmFTL3m3dvSbZY0N0vuP8bJxQlwZNCuUeIgVm1Z+wtMRy7iZddNMN+KXAs8EdOv2P/q/Fpn7RUjC3svQrjQWmQyQ5Bf1P0C86JAy1lJMALfi9mUn8feInkySW8ghgfirXWzT0Y35XQ7h8UZICroJC9DtrSFKcJv2g6CPB04DcjjOgG4/slyYqXkN2klPwyGnyiYOu4HmRpOzQP3ORj7g2wF92Xm3Gyv6U2d4v20rK2SUOj8wUjo2HFrcwNZFmeenUTxbR9HaKYQCiOBQzu1vLDFHiR2T1DzXrYHuiliqgrvsMOwxQ2DnIbCJCdacp4EQY1J9C33tYRl8PImQ+d4xGgtxJnBFPS4n2JPrsLH4yStTBpOK/obEww2WvvMLR5c/sFPIkti5/nBiN+M2KFywM6uimCgZ5wjckur/Hw0lpKCwTw9w2qr/f49MHadQYlr1f1OpJN3NgN30RpZ3HRUnWL8SgUswjZgcsIdjAiP1u0y5nPgqv2WXwMWm+iY40evX07Y2Vd1Z7VdnPCmSEo7GFnkfZYWsoqUJPVABlQ26i/WueXowiNxGD+2K4oX7WGl8q90+UGfPtAlomdpvoTBzvjdituwRHoAv9Q17e+Q5l4KTSWzCAtxkR+EcSLGL49nTG2bprdFyDXe4/JVkSk96QEAimCKBEhUodZw2SMdR5owbDjI3Z73T74phh9f1wP9uD+gy9GooBrvLrOmOOZMD46BIml70I3SPcuXfFLPyiE9pGcR1aZyQRWzfVXp8v1H/IXjyJ/vxCGMqoqgb1B1cHj/UuqZWFTKg2bEKmoi6j9WBOY1qDr+cbv2E61jYFL2weLzBvBcxd/rvNKjaEiOnBcjv+ ADTL5NGY E1QE26dAgzVwt2Kom3RU8P7Z4bmL+H1P8+qLezpcKpH0ZHqrXpjajYNrB8rWHaP3ubKsbrskNxYZGthZ8Ggfl3Mo6kCrjYaXah1kXhtCbcTJzs0RTR7POiyxNXITxaary04W5K8s81njb81gDa8g0e1J5vwtDnPiUTiJ5vfJ0Irp7tMxtxACHo4edCD1ZpsgNfJQBh1f7KSsEbXS4nGyHoyG5q0Nk4ezPeLCLIU33Fz6bfKnRRrtHeVVoqyDSzg7x6avoFlJqm79ln36TiLk7Uz5+Sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/7 21:05, Oscar Salvador wrote: > Tony reported that the Machine check recovery was broken in v6.9-rc1, > as he was hitting a VM_BUG_ON when injecting uncorrectable memory errors > to DRAM. > After some more digging and debugging on his side, he realized that this > went back to v6.1, with the introduction of 'commit 0d206b5d2e0d ("mm/swap: add > swp_offset_pfn() to fetch PFN from swap entry")'. > That commit, among other things, introduced swp_offset_pfn(), replacing > hwpoison_entry_to_pfn() in its favour. > > The patch also introduced a VM_BUG_ON() check for is_pfn_swap_entry(), > but is_pfn_swap_entry() never got updated to cover hwpoison entries, which > means that we would hit the VM_BUG_ON whenever we would call > swp_offset_pfn() for such entries on environments with CONFIG_DEBUG_VM set. > Fix this by updating the check to cover hwpoison entries as well, and update > the comment while we are it. > > Reported-by: Tony Luck > Closes: https://lore.kernel.org/all/Zg8kLSl2yAlA3o5D@agluck-desk3/ > Tested-by: Tony Luck > Fixes: 0d206b5d2e0d ("mm/swap: add swp_offset_pfn() to fetch PFN from swap entry") > Cc: # 6.1.x > Signed-off-by: Oscar Salvador Acked-by: Miaohe Lin Thanks.