From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A99C021B1 for ; Thu, 20 Feb 2025 11:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43BBA2802CB; Thu, 20 Feb 2025 06:05:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EBD92802CA; Thu, 20 Feb 2025 06:05:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265252802CB; Thu, 20 Feb 2025 06:05:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 090132802CA for ; Thu, 20 Feb 2025 06:05:33 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 802901410F1 for ; Thu, 20 Feb 2025 11:05:32 +0000 (UTC) X-FDA: 83140042104.03.5E821A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id D4B70120016 for ; Thu, 20 Feb 2025 11:05:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCYBGa3e; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740049530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lH8hZRovfEp/BEP5acQntlzmBgzDcs2Zn+aYw126Mlc=; b=bEfU1gWSNT/bAKUKuBpBvub6WCP2E36mcUUl/yFPBxoOEBwHokwjoVu/mRwEnaCSPOORNt NKj6yzyBCNH0ahALnLpVaZcCUGnqitUcBFmjsFtvglJRucJdYl2jGLIahAbTzyTCZvA3LG e8YvwMWazEUzql7yXNi6OV079cvOrSc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCYBGa3e; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740049530; a=rsa-sha256; cv=none; b=jHFW8Cvg/ClB7SBOnkx8FtyRkQ5HCfVxQM+7x/9QCpyBU6Yw3qf/raYLNYRjiQMmPMbtvr 7aiAdXG/tbDg5yOrGBjf9C7xzwaJ+je6uK8MJncX8vn9sv3P6NDZiuQSwZdFitQKzr/iDJ OYrU77c+7ZGfk6TND8RGwQwDWz9U3AY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740049529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lH8hZRovfEp/BEP5acQntlzmBgzDcs2Zn+aYw126Mlc=; b=cCYBGa3e9hFRjUVp2WHECuoWt6HyIxjXJq9OZJSftEeDa2sB4N6v0K0ECMm+p84QoTUOe5 sbSffHH3Ihoa6YzzREEfhJiFRAI8LjDMaTh5hqfdi5iYS04FOgWFFGQXgVPlHBgcTala5W enf2wF7+TV4Mf1XV4to9ki91zS2TqG8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-KQQSZ8p3NJWYvplaUB-KDA-1; Thu, 20 Feb 2025 06:05:27 -0500 X-MC-Unique: KQQSZ8p3NJWYvplaUB-KDA-1 X-Mimecast-MFC-AGG-ID: KQQSZ8p3NJWYvplaUB-KDA_1740049527 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f4e47d0b2so336300f8f.2 for ; Thu, 20 Feb 2025 03:05:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740049526; x=1740654326; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lH8hZRovfEp/BEP5acQntlzmBgzDcs2Zn+aYw126Mlc=; b=hveKb7IPni89d+73uJVBu8s7OL3UCKRihYdKIG+RmEcBzARYZi1ktP/ZPswP1mb+32 4zWABADGb5h9i37uVSA4FatIBRloqpJKcLFGAj8yj0j7aBwBu4JTJsz4SsBC8uAUzJKY W5r3xtK8Ztzsj16AEeds5WnXv0T5NfdpAN9GFQOO8MRdLD9wY7hk1AOlH6wUkZTFAhAG ZmpESpPR8lsdxlle803wH9ArttZS70UKkVyXUPMTLfqi1EXC5Y9NN9Rgd3tWpyxHJPER 5U3f/3FS/TgqO8MOSR3hnWaJDy8EMPCd5ECH0z1qlAUHS6IF+fcNx7lR5Ej3QlGibar8 ry0Q== X-Forwarded-Encrypted: i=1; AJvYcCWgBUMiTPwVbBugm6+kr7LO5rObVuX8Sv1XbeLgTU1BBv5ygP3QfpcqHnn+aRqdENBSyi9tcVfquw==@kvack.org X-Gm-Message-State: AOJu0Yw5SYsPJC/dYxkXCa0UNembXkqkKd5f6BKDGd0oSBTzDDhbDosJ X6UZbzBJrHWFVzipjqyNE3XS3AMamuhQOGRQv1IrN3xl4mogtQezlf0rMiUjBJEs7o0bfaGrkSg PivGzxFyieVQVogbARDkTYSqHAvkDVfI9J2jjOJWcv+dub26s X-Gm-Gg: ASbGncsfRQrHz8tZwJUEqw9IoZnzwcT0pMoUdpDZBmRBIN7uwWUeYRBmJCnZERmCXBx f1iQqayPOk2tWOe6fAhptkH7bfSyvPjeWWWktG5gllx0gPJyEm5yNHwNHFEinR9ZkU9cFq887zV YsLA5+ZglwF2s/fe1r1g7SbmKYHE386GdrYDpeLM6XrSahEl35VX5/GD7vGV3yodz8B3sPirRm4 4C0Y6QTV7aCQUFh+irbMeSsOr+wlkPXphpdBKYU/j+cxliX/QALcCZiPcTryM56uiJALrJJjGD0 QZgj29ugAvtMnLYLYP1zcaFHLziNC94YeWuTpgaMUe2LRttytx5keKL1PIyaTZjvFjdnNp2DOrO yBYTqedn3RlC//3P7saV+FWUW/yNaeA== X-Received: by 2002:a5d:64a3:0:b0:38f:4916:fc21 with SMTP id ffacd0b85a97d-38f587f3e7fmr7315433f8f.52.1740049526593; Thu, 20 Feb 2025 03:05:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyqNwGnJeS629h8BeaF+V2uQxC2fzEIpWbl8MMAGczpDyT/SRmr5r1FPPe2KdS3mTLTlXunQ== X-Received: by 2002:a5d:64a3:0:b0:38f:4916:fc21 with SMTP id ffacd0b85a97d-38f587f3e7fmr7315404f8f.52.1740049526224; Thu, 20 Feb 2025 03:05:26 -0800 (PST) Received: from ?IPV6:2003:cb:c706:2000:e44c:bc46:d8d3:be5? (p200300cbc7062000e44cbc46d8d30be5.dip0.t-ipconnect.de. [2003:cb:c706:2000:e44c:bc46:d8d3:be5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b4423sm20653252f8f.11.2025.02.20.03.05.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 03:05:25 -0800 (PST) Message-ID: Date: Thu, 20 Feb 2025 12:05:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: page_table_check: use new iteration API To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, pasha.tatashin@soleen.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev References: <85f11743d259d5e4a1f47456fbcda82ff6db9ab3.1739931468.git.luizcap@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <85f11743d259d5e4a1f47456fbcda82ff6db9ab3.1739931468.git.luizcap@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TovrLwmVRs2nMkDfo1uIpOEIE2AknDGqE4PLy4rpPu8_1740049527 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D4B70120016 X-Stat-Signature: 57gy8bxasjhfth6nyryn9kisqrjohsn8 X-HE-Tag: 1740049529-472920 X-HE-Meta: U2FsdGVkX19xxEdZWVNbH965okOKSrijfvgen6TBtNNx51bb778hZkvEptUlDmV8XMe9ctVMMyhVZ3al0KIr8Y6zLErXpmhySl45dbdFsejRjcPlBAfadvAg3hIdzjdD0sRXRlq8q7fwuHW/4/LgrwTi48GKflCh6osOtC1Krv65ceEdCSbjG+ZMVBry/GoH+utbsRkFYljxLg/XKAdcgDt4790BZjRFE7G5V8hmaDjBn4rDi5miEYfHC1t/jRJ35IRpELCFFN+SC6Ag4x36ahDoXpRPUt8l6fel1Y0nl4Hxw6jVWMcmV7XOu/pv244x5NYuKQReYdQFXAn3kSQ27PeWPaUpS6NzsLUSEULfHkLWcc2Ps3E5OEr328LwtwChb/rL6UXlkR+VSOZIPyXMLvw4zikVHN4YD9FAaciqXA3/is08WBzCo/XesVHm9syxI0+HZwM/4ZsP+0hR4cQ8cuLM4E7GFYmP14Ssd7Lv/KgTgglJIajwnb3+cOMSkQReh/7ucOBlVm3twrEqofKAxlPJszrG1OLfAic/aN553eH2tO7XoLJWtPsZ2E+iCqQKIgTtYIXA7ef5MuRBsl0f4bedU8a+i4BxrMf9Dw3YLnbIIEZJdslEvLTGA8DN6U/V5J4VeH3uNQNC0H4Dk+CQDmd4dHYwPAcOCAmnx8uzUFQZ2RFO+Vw80JfwId52VP9GrLrsED3cTDWu5W9M00aLrfvbv3wijoLGVJe+ASnuVSKSJMCdD3ywQasTqklEP8ZOnajiIYu57XUCCGk8ZFjnojRceCjts0/qErFixdWlovDn13TY8yR7A9xyhwHdLUpT0ilI2U9EDiIroqHRtPeBoAmlzBC9R6pNA2GB0QN2IfeQdcpP7c0u/KeENwL4gQ2JBEja5igt7EMeTjR2FMWK/tOj4zjSbar0t1pC5eiPX7t6U/cldoP9JrBA3YrQm3tHXUhxRdmjvfdL3UYCoCZ Oi4bKf9M SogfRqaPnjA+v3zOFqzmw8IVvJkda3OkwG0lw9x+ZPymn1XWE9xM09kn/HzypbrU+hHknM/HZpR6ZgJjCKICX9l2HQylrm3yZD/Dx91KLM0xJtUVkKWlCFVE3XRQi3b05gemFMrx/9tOKmE3elEMiuZwDe97UnrVrxfSyS+i9WGvwfKU2USG/6n7IvdQ9woWVJG+9iU1S/BoBbxvyNS1B9LJA03Dg16tUM5CSlnjCXDQZBPX3Jq84wN8q3xbBIvQBUGcgYRU0J4GN7KlIbx+KmzRjx78T+HPkOMCaxHTG0s7G6Bb7QhNp8yPeEFrO2aV4lgS8N0tZ3Ya/53z5JWRpqDvXMqEIrUAxAat1AMaHxk8+vtBasdg44KTH6hFQLD6nPc6PC75rmTZqbVC7lhEBNlID85CqPElGLWDP6i5daOk22oZwTsMk9AHFY+wIlp/FfjM3hacFng1qmLcsLtzoSJZBOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.02.25 03:17, Luiz Capitulino wrote: > The page_ext_next() function assumes that page extension objects for a > page order allocation always reside in the same memory section, which > may not be true and could lead to crashes. Use the new page_ext > iteration API instead. > > Fixes: cf54f310d0d3 ("mm/hugetlb: use __GFP_COMP for gigantic folios") > Signed-off-by: Luiz Capitulino > --- > mm/page_table_check.c | 39 ++++++++++++--------------------------- > 1 file changed, 12 insertions(+), 27 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 509c6ef8de400..b52e04d31c809 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -62,24 +62,20 @@ static struct page_table_check *get_page_table_check(struct page_ext *page_ext) > */ > static void page_table_check_clear(unsigned long pfn, unsigned long pgcnt) > { > + struct page_ext_iter iter; > struct page_ext *page_ext; > struct page *page; > - unsigned long i; > bool anon; > > if (!pfn_valid(pfn)) > return; > > page = pfn_to_page(pfn); > - page_ext = page_ext_get(page); > - > - if (!page_ext) > - return; > - > BUG_ON(PageSlab(page)); > anon = PageAnon(page); > > - for (i = 0; i < pgcnt; i++) { > + rcu_read_lock(); > + for_each_page_ext(page, pgcnt, page_ext, iter) { > struct page_table_check *ptc = get_page_table_check(page_ext); > > if (anon) { > @@ -89,9 +85,8 @@ static void page_table_check_clear(unsigned long pfn, unsigned long pgcnt) > BUG_ON(atomic_read(&ptc->anon_map_count)); > BUG_ON(atomic_dec_return(&ptc->file_map_count) < 0); > } > - page_ext = page_ext_next(page_ext); > } > - page_ext_put(page_ext); > + rcu_read_unlock(); > } [...] > > /* > @@ -140,24 +130,19 @@ static void page_table_check_set(unsigned long pfn, unsigned long pgcnt, > */ > void __page_table_check_zero(struct page *page, unsigned int order) > { > + struct page_ext_iter iter; > struct page_ext *page_ext; > - unsigned long i; > > BUG_ON(PageSlab(page)); > > - page_ext = page_ext_get(page); > - > - if (!page_ext) > - return; > - > - for (i = 0; i < (1ul << order); i++) { > + rcu_read_lock(); > + for_each_page_ext_order(page, order, page_ext, iter) { I would avoid introducing for_each_page_ext_order() and just pass "1 << order" as the page count. > struct page_table_check *ptc = get_page_table_check(page_ext); > > BUG_ON(atomic_read(&ptc->anon_map_count)); > BUG_ON(atomic_read(&ptc->file_map_count)); > - page_ext = page_ext_next(page_ext); > } > - page_ext_put(page_ext); > + rcu_read_unlock(); > } > > void __page_table_check_pte_clear(struct mm_struct *mm, pte_t pte) Apart from that, this looks very nice to me Acked-by: David Hildenbrand -- Cheers, David / dhildenb