From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213C5C7EE31 for ; Wed, 24 May 2023 08:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A0FF6B0074; Wed, 24 May 2023 04:27:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 529E6900003; Wed, 24 May 2023 04:27:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA05900002; Wed, 24 May 2023 04:27:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 293366B0074 for ; Wed, 24 May 2023 04:27:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 753671A08C8 for ; Wed, 24 May 2023 08:27:55 +0000 (UTC) X-FDA: 80824470510.30.0FB748C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 3D2E718000D for ; Wed, 24 May 2023 08:27:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PUY/kadh"; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684916873; a=rsa-sha256; cv=none; b=iIn1j3RvUgQILFCGfKFzQv48VG8zfwD3aA4jcWDAXzHsVQvPEzk/yeKQ+p7JMEz1Uqqb1q rstNgOXcUeWo/Ei6rraq9/JMn/5fponxZCfxpQoKjajpdwvfoz1Jn6IJ3CNVgyTqe+h+O2 11iWD6QWDHHIu3FIXBpiP+AaCQQzdw0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PUY/kadh"; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684916873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JCUhbhPUddxH1BlYMFRizRq/b/BxS31k/TQkz/sL1sw=; b=v7Ok+YoqH2jFIL3P3pjWp4QZR3/Vp2vtm1f1siRL/wI+k5wi+740u2Gx8A0emPkwuprcPx a3fW2ANXEU9K6Jaoz19mFdIF/WvDjZQUm6m08IYQhjyu5QureOncZXcqFeufcx4oNiVNC/ dFWBpToSFBjXQRJQUQgI+Fh1GEkIoms= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684916872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JCUhbhPUddxH1BlYMFRizRq/b/BxS31k/TQkz/sL1sw=; b=PUY/kadhqSawLXIlE6fML+UDtcWA7keEPkJzLfOBRQv0sQPTou8VPJRtLqJlh+eg25RGxT CXmy6nwd32A/0/jI1XIKsvg3XOVkvT7sfmtyR5TwPQNEKRgTb2bWPNBcyuKua8a70QG/NS y5fHV1owAtvsOqNIpFAkQtLvjMBKMjk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Sml_mS2qP6iIkoZdEtsZzQ-1; Wed, 24 May 2023 04:27:50 -0400 X-MC-Unique: Sml_mS2qP6iIkoZdEtsZzQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f42bcef2acso2940925e9.2 for ; Wed, 24 May 2023 01:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684916869; x=1687508869; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JCUhbhPUddxH1BlYMFRizRq/b/BxS31k/TQkz/sL1sw=; b=bohYkub6HEuJ/SOD3JwC9WsRuifFuFg3oD/r53MXeQ++x8RB5gVda5AykNAM00SGic mCFgjxz8b+sUoCEJAm9McnHhJ+E7nJU0bdJAwo5DPY4qnegAo/FMh6Cmrbp4yCVFTpje f95SyipM+TlKzd/l7TXvoPMu+KHYb3+okqoaItTjax6+GYqPrU9HP0KD+zGQYDm5s2d4 yg4UMG4hEd79PxzKBFwU7NZBswyegMMr/Hmm54fDQ0xuALPoePAn6NzYPwOTwFrmp+5F whjbaaesfDC9r23f+ROvyHbOxmGAHfq8xTAkkVLQpJtv71Hvvg6q8tTU/4kfiL092KJQ DkcA== X-Gm-Message-State: AC+VfDx9Hdmf8IeV1pd+gp9griYxYUlssEnTsyM/Q5Ldft5qZ6m33rsM q+1UxvKivUue6WRHjrMraPm4N0ifOj0O3s9LYSQSN6Br1JsW853/n9aFk71sdprO9S+aP1yMr4D PwyXPM2U9EBE= X-Received: by 2002:a05:600c:3784:b0:3f6:69f:75e0 with SMTP id o4-20020a05600c378400b003f6069f75e0mr6620910wmr.25.1684916869359; Wed, 24 May 2023 01:27:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4JFA+fH2aWyXjI6Gs6rgwh5oSGz4/rU3bsQD2lOaBmsNolDtwJUhRU4/5+OKCrVu5XZ/Cddg== X-Received: by 2002:a05:600c:3784:b0:3f6:69f:75e0 with SMTP id o4-20020a05600c378400b003f6069f75e0mr6620897wmr.25.1684916869005; Wed, 24 May 2023 01:27:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:f700:24cd:855:1c60:1ff4? (p200300cbc70df70024cd08551c601ff4.dip0.t-ipconnect.de. [2003:cb:c70d:f700:24cd:855:1c60:1ff4]) by smtp.gmail.com with ESMTPSA id e21-20020a05600c219500b003f50876905dsm1544885wme.6.2023.05.24.01.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 01:27:48 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 10:27:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v9 2/5] ksm: count all zero pages placed by KSM To: xu xin Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn References: <52bfd744-3086-a22a-e2e7-8b64d5fccfcc@redhat.com> <20230524075539.20844-1-xu.xin16@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230524075539.20844-1-xu.xin16@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3D2E718000D X-Stat-Signature: 4kuigiqmf6dsgmt3knpa9rewjsh8c7wr X-Rspam-User: X-HE-Tag: 1684916872-497433 X-HE-Meta: U2FsdGVkX193CRaD5z+QuymfOchNosZFilKNIa5cH/aIkS5njciROdT9TulYKNK5Ugf7fYxKy4+lFSiXr74/VZKup745JCtTVdzNFRyiFag2Evx/oAgm8ODWPBOiNA9/z6CpTVBG1UNu1b9AVbfjrU7kW/WDFL2Ezls/Th1o0uAJWY+euuv9uNrY4sqZAIrFhxOFhOYBfo2JfOJoJhGkOtEbQfhVPEToH65QQpmknNxsqsqPNXFrUmAfjibzGmyMeSOsO+iWnAgA/KJyfmbwRn11mRVLT++pbK72NdsWVMLelWGjrvvDveGUM/he50SNVSoZDGD91Ox0zlogwdHJ4yb0sY9Ju9gWRYbJl+RbBrClNM0csQzTzTF7D9iheYub+hOegR0mgM0TrFcgK2ytwJNbBFLxtmo1xO8m15n0/xQMWnIDRab9ZL4rdBzGJtWC4y2TiYHP1hT3sCNZCeUj4RJpP2xim9D36cxFZWV0y49SBxiaoY3JJDHs4SacMN2je+ahhksOBaUou3sakhdbyG/0dwin5BqCPSaOh5onBgiTe9IvPI0aY/cAjdkOqxVycw5yLM2Xd/ltMPxM1wp7+WKwd7Eym0vfIj5OPOwJSaHUypyZ0eOKm0KbMbmyoWn9kvibgX/5e0vn6WgfBu5aEdTUsDUPLou1RJd2cTvoCRqyyBsgQ+s0x6RF6VN3c5FtUUS550LelcK7L7UEFCE+X9K1GWqwJSaQ+YdgwRtc1C+afcTibTTD1aX2BwVnK16yd7XsXDhzXH7xfQZrUzXaxo94NmGH2fQzh02R66593zhFJavzvhRpgSdGsCYmJCedCXXz/OYM3LpeMKFXfkL5GdWOyxsp4Ok1FIu8OaqXF1X8fY2OKFDOAmq6vwnxvaw4BlBWlugiRmS/5fdml3nBLTrebKUNkbKf20QiundeaQLTp/4EMigoX/lPEiKG36WECvKnoHJHZIRwCN0eL8u dg6FiP+r 29XEjQAb9fh4u7HFrOs9gK+E6O33N7BzvghLTnMQ7TqotMP/uVqb6IbWGebG8uvVkqn+RBN4dgoLKjfo2ZXkQN9C6mYkZGfXRC2f8VPlvm9/VMhz4storfCaFuPovM2qGsg0LXXv2k+omM8JCUIxoSiQFl2KkWYuQPLDWDN5Vhu0kbpWbF/rKHwgQzNMB3795OP5XrSK1gQ1N8JP04NQDEx9RAtzfKkred31Pbuplf4r9m6bRxqsQlunreNBuOTSOKc1ytjAFZXM6BG2Hp+nGANqjyImGbc7MT7Vw2o2pbJEJbMRJ4V/9vZzDgoh4JOaQo8MjAEgFwCuVpw0qeIJ5oWDf3fMYxkV0oAk4Sj9g6ZwQ+nUhWahewUm3BUQxvf6+dLMu/WmfFwsklG74jLi6WTrXIr0YFWVUFhvQ4jl35bQD+WmGoXn3DmQwBV3bEYLg1C4xwFS4q9PKwUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.05.23 09:55, xu xin wrote: >>> +extern unsigned long ksm_zero_pages; >>> + >>> +static inline void ksm_notify_unmap_zero_page(pte_t pte) >>> +{ >>> + if (is_ksm_zero_pte(pte)) >>> + ksm_zero_pages--; >>> +} >>> + >>> static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm) >>> { >>> int ret; >>> @@ -103,6 +111,10 @@ static inline void ksm_exit(struct mm_struct *mm) >>> >>> #define is_ksm_zero_pte(pte) 0 >>> >>> +static inline void ksm_notify_unmap_zero_page(pte_t pte) >>> +{ >>> +} >>> + >> >> Having proposed that name ... I realize that we call this function >> whenever there might be a zeropage mapped (when we have !page after >> vm_normal_page()) -- but it could also not be the zeropage. >> >> Not really able to come up with a better name :) >> >> ksm_notify_maybe_unmap_zero_page ? >> >> ksm_maybe_unmap_zero_page ? >> > > Analogous to the existing name of ksm_might_need_to_copy, so maybe we can use > 'ksm_might_unmap_zero_page', Yes, that should work :) -- Thanks, David / dhildenb