From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B04AC3DA4A for ; Fri, 16 Aug 2024 19:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D97A88D00B0; Fri, 16 Aug 2024 15:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D482F8D0066; Fri, 16 Aug 2024 15:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE8D18D00B0; Fri, 16 Aug 2024 15:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E0488D0066 for ; Fri, 16 Aug 2024 15:45:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5B9B11A0295 for ; Fri, 16 Aug 2024 19:45:24 +0000 (UTC) X-FDA: 82459137768.21.DAFF844 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 17AC640019 for ; Fri, 16 Aug 2024 19:45:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iW5wmLOx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723837461; a=rsa-sha256; cv=none; b=WftjyEi5pVFIuGTFDGDvfB/0tg8NNHomjWyr5ML5jQ3TT3Yu3rQHS0su3krP2LXlW3TDj1 W6Es2xKwTzDBY/8x1EwthMmgaT21+qeYxu3EkcKzciiOaD+0+QFyRgfr9yvItOIsYBNVfE 390Bxy3Pk/CsFBrMZZvCqM1Zg86+M2E= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iW5wmLOx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723837461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X43+SWRO6ZaKw4cvWFhA7isU3RgZjdLc8ynwfTZAaKM=; b=QoAxufppy4Z+BUEIXgWMjbhwyqMlH7NH+CTn7T5NwLbxDHregW8P2RPANUVl12tSrXi9Co HD/3rNQY1qOsj83s4AHaYeRk/XkUTES43E+JfCRf1GkGXMDoziZ4VwXPeCiKFk1WhE11AZ 5YK/u8YDPJVYkTj2m21ESNnOJ2jvJIo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723837521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X43+SWRO6ZaKw4cvWFhA7isU3RgZjdLc8ynwfTZAaKM=; b=iW5wmLOxqXfTtkwEknSs2CdOl7MazNJSbL0IKFJJ0Q6ZVoRRXyZPR5n2UtS2ZFo26+M73Z k+kwAY4bGO48Q317xexW72efYeNiEJAi7FKmCQpaOF4x/nMSQXWB1cfP7JMc1ptUOKVADr uMptqJJ/UfiJM64rd59VCBLBwwm/Ga0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-Hk-MmJjJMqCRI5IzSFyHpg-1; Fri, 16 Aug 2024 15:45:20 -0400 X-MC-Unique: Hk-MmJjJMqCRI5IzSFyHpg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-371a82ceaa7so22404f8f.1 for ; Fri, 16 Aug 2024 12:45:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723837519; x=1724442319; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X43+SWRO6ZaKw4cvWFhA7isU3RgZjdLc8ynwfTZAaKM=; b=POA0rgwEVSAC3yzmLcE44higGeTD9HrPAqXTqwcgptiHHaW0tzoOqLtktcEPWbM7tS G0fFYA4kL9It/Mc6n60EbNy/mMUdoCyAumtlghqBsCi4UZpyW5BgmPlVLsfHj5f5Rz2Q 0p5YJBvOCEz/QXofcAPxoGukC+M2YByprOPKgD9pvSe0MAN2oMEmXrOs+TTIUqhigRpB YYPVENlVbKnsfQPPL+jR5LJhq/lGIzIaChlVY//HNrmoqVvZXB+PKMP80Sq35q2RTmEA H96F54jnFuLX4tRrSKwi8+0rzMP7TPUNhKdLKDGiH/n3D+eCROjg7O7xlwGME6yRQW0r GNfQ== X-Gm-Message-State: AOJu0YwOIqVL8GYaEIYv6Wb6PCS4Qu7snmXO8ctncD7EF3KGGLlmoV4J a1+CAeA8Ni6DnqVg818bIDEYp2j4BxNZyM75ZdtXG1c1IxNkBpRPolZY8HcxMj0vh6eKhTkrtAX o0CMHlOC3l0/c1kuHEgm9T8qWf0p7DvFuyXLaqrZeFGIaMgXs X-Received: by 2002:a05:600c:4fd1:b0:426:6353:4b7c with SMTP id 5b1f17b1804b1-429ed7855f7mr27002445e9.8.1723837518778; Fri, 16 Aug 2024 12:45:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTM34Zx9qF6zIi9oQVh6gTSrTnvNHInfhDWtMPXeJVnopqOag53yQZWADaverN5hEit7XYwQ== X-Received: by 2002:a05:600c:4fd1:b0:426:6353:4b7c with SMTP id 5b1f17b1804b1-429ed7855f7mr27002265e9.8.1723837518288; Fri, 16 Aug 2024 12:45:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c721:b900:4f34:b2b7:739d:a650? (p200300cbc721b9004f34b2b7739da650.dip0.t-ipconnect.de. [2003:cb:c721:b900:4f34:b2b7:739d:a650]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded7ead3sm85456865e9.47.2024.08.16.12.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 12:45:17 -0700 (PDT) Message-ID: Date: Fri, 16 Aug 2024 21:45:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() To: Kefeng Wang , Andrew Morton , Oscar Salvador , Zi Yan Cc: linux-mm@kvack.org, Matthew Wilcox References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17AC640019 X-Stat-Signature: euwrsr6aa6h1bkhqpj7zgkfcdb77jhkt X-Rspam-User: X-HE-Tag: 1723837521-733072 X-HE-Meta: U2FsdGVkX1/BB4wvEyb6SJJMxbQrF6BciY2rpxxiahE57p3ovPWjBOIYyzJFYsai2cin3gb9AIoq8Bou3vC9nzMWlrkEeWRD66rD58aD3UHE3/ghcHUddF+RbKhQjiQaSKyzRbirZp2tdSDyt4NRTZk8q0S92eID/g5FFokGIZJF/VQmdxwlTW/k4JcotZFoCejPxTPtPXD45KoYcKePlO9sGMckPnRe+V7x8t2/RYskKkX0yfC4CZcUqbdju7A/TF6FjVQ1kdPx0UpE551dXNkgFzKpApK/jtA8SapyY9MW7U/qFqws6xGE2wel2L6T3KwPH8nUTHJ/7AZyheA/74M1V/hti61dlN1xw5mMi8XIWuDDU6S2sz8n1HP0GzC/uf8N3OrZ2v7r55bKUmyQXeFvTehXQpDwBuQSFisuQSbqNVIDL+diDqt3Xpyf3GvwEcNfkpM47Ju2dyHcBBjV47glClLIlbzoYvu51G5AbxcJny0VJSryTJoF1qv0MqzZpmbE6zCFnTis61Vk/NwUImBRVsXbKEEQkxOFIW2SOm2nIBae4WT99eFOEHpj7wcyuPRKpy45BnyXVIFnswiiVlFp5Qf4Uw6Qq9d5QjvDK/o+pm+cFCaNj7JUU8U2aTneScaYXSmTKtELcMQPQkC6omzL7Bx9+sYwVzrKjgsYMssBOre9E3f/LIpaC0j6lRDGZIM85b2a7xt/oXsw1rcCUDrDOAK/W53HGSehib7VxklYxzJkPbphgPT3TNKrt+3qQjjft9N4j/ZvZO1XNnxhFD3RJtJQejrkkGFdMjtZAbA9/TTrM+xpsVOKX+GdVHrrGjnHYgH/s6IXnqKddM5YmVKG7Q/cyqge7Rk15nBVttHlTIvxVK0lT3zhPvqEJkP9ZbcmAvwzexNMkCEIx6h3LYVGtw+rTeJniuooGctl561RdFexKg+4LDLgfMVAHkB4F3pXniQm6wggWgv9y1b hHMesuKL oXIEu8iCyGjLCgFMl6BCKZv6IvNKTTJ3FR8vXR61F4fuQzZrDglp8HpJNL9x2BpgC6toXhnvKhD9jiXfc80IE9JbylEEbLk6cxvcQgedOTed2QncCAsxm3tsTM7RO0ttScuWUw7Vnwk1BBb7nWHSGNkdrtiUwCEiZYe1SY47MRuP6eCA1ACyDzSpG14nBCCatIJ64ktbxy62DbvlUU9S8EgtVKyDeS/WGqYwenBYPBkGmkx9+FCgMrP1bYAT2BpbUzBb/QhhlLa/HXDgMBhmQ+GSKdt/HsrGWf1cJRb/wLsP5PJJxeeTIy7+ZY+6HmQreGR9qlV9OYBdGVBe0Mz8Ba1ReQb9XytfYcbC0TluOdZdDWB5uWtzxN/1d+nlpMDtHQKMmLPd5K3tSnjsgxd3SUtoFMsgTV7O2nXg1ql8899z2T7Rv3qw/ESySC0yopFEW+VuGakKt3Tmhq/OUaZByzNahZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 13:30, Kefeng Wang wrote: > > > On 2024/8/16 18:11, David Hildenbrand wrote: >> On 16.08.24 06:06, Kefeng Wang wrote: >>> The gigantic page size may larger than memory block size, so memory >>> offline always fails in this case after commit b2c9e2fbba32 ("mm: make >>> alloc_contig_range work at pageblock granularity"), >>> >>> offline_pages >>>    start_isolate_page_range >>>      start_isolate_page_range(isolate_before=true) >>>        isolate [isolate_start, isolate_start + pageblock_nr_pages) >>>      start_isolate_page_range(isolate_before=false) >>>        isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock >>>             __alloc_contig_migrate_range >>>            isolate_migratepages_range >>>              isolate_migratepages_block >>>                isolate_or_dissolve_huge_page >>>                  if (hstate_is_gigantic(h)) >>>                      return -ENOMEM; >>> >>> In fact, we don't need to migrate page in page range isolation, for >>> memory offline path, there is do_migrate_range() to move the pages. >>> For contig allocation, there is another __alloc_contig_migrate_range() >>> after isolation to migrate the pages. So fix issue by skipping the >>> __alloc_contig_migrate_range() in isolate_single_pageblock(). >>> >>> Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock >>> granularity") >>> Signed-off-by: Kefeng Wang >>> --- >>>   mm/page_isolation.c | 28 +++------------------------- >>>   1 file changed, 3 insertions(+), 25 deletions(-) >>> >>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >>> index 39fb8c07aeb7..7e04047977cf 100644 >>> --- a/mm/page_isolation.c >>> +++ b/mm/page_isolation.c >>> @@ -403,30 +403,8 @@ static int isolate_single_pageblock(unsigned long >>> boundary_pfn, int flags, >>>               unsigned long head_pfn = page_to_pfn(head); >>>               unsigned long nr_pages = compound_nr(head); >>> -            if (head_pfn + nr_pages <= boundary_pfn) { >>> -                pfn = head_pfn + nr_pages; >>> -                continue; >>> -            } >>> - >>> -#if defined CONFIG_COMPACTION || defined CONFIG_CMA >>> -            if (PageHuge(page)) { >>> -                int page_mt = get_pageblock_migratetype(page); >>> -                struct compact_control cc = { >>> -                    .nr_migratepages = 0, >>> -                    .order = -1, >>> -                    .zone = page_zone(pfn_to_page(head_pfn)), >>> -                    .mode = MIGRATE_SYNC, >>> -                    .ignore_skip_hint = true, >>> -                    .no_set_skip_hint = true, >>> -                    .gfp_mask = gfp_flags, >>> -                    .alloc_contig = true, >>> -                }; >>> -                INIT_LIST_HEAD(&cc.migratepages); >>> - >>> -                ret = __alloc_contig_migrate_range(&cc, head_pfn, >>> -                            head_pfn + nr_pages, page_mt); >>> -                if (ret) >>> -                    goto failed; >> >> But won't this break alloc_contig_range() then? I would have expected >> that you have to special-case here on the migration reason >> (MEMORY_OFFLINE). >> > > Yes, this is what I did in rfc, only skip migration for offline path. > but Zi Yan suggested to remove migration totally[1] Please distill some of that in the patch description. Right now you only talk about memory offlining and don't cover why alloc_contig_range() is fine as well with this change. Let me explore the details in the meantime ... :) -- Cheers, David / dhildenb