From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EAFC369AB for ; Thu, 24 Apr 2025 15:21:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 220566B002C; Thu, 24 Apr 2025 11:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CDCB6B00B9; Thu, 24 Apr 2025 11:21:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F155B6B00C1; Thu, 24 Apr 2025 11:21:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC7FE6B002C for ; Thu, 24 Apr 2025 11:21:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F23D1C0DE0 for ; Thu, 24 Apr 2025 15:21:23 +0000 (UTC) X-FDA: 83369301246.08.495741F Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf13.hostedemail.com (Postfix) with ESMTP id CF56D20019 for ; Thu, 24 Apr 2025 15:21:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=xMazgm8T; dmarc=none; spf=pass (imf13.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745508082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=49tEuZJbApWmoJu7HSg51xfF3TH4o2He6H3h4M5pJC0=; b=8kEzX3vA+FHcbVqT4QvMhJlnpI6TJHql3wnn7cSzdbgpdUng/4vLq1wTXCwJTh+75atAPJ kdkDlfPNeot5DdMcFbJ40beTAaPHnSWKjDwPY/Y4MyW3jJt7VJoBW84zPygdVZYlHmE5iI EGkWLFfs5D4ywrn38Whk6Ujg69W2xk4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745508082; a=rsa-sha256; cv=none; b=QJp917VFXM02EMh78QSfETQq7Tgv2Yp2B8XdoJdAlWJKtNxZZfVAEnUCm5B4rpba0CFNh+ gevCIvduQiEB+Uy+JC4K8WrcR/V+4MYpr4ABblfoLbp6k9HJYbIGzCqd7YhKKxrlNINMCd iHYbrXFwlazZIYFzYDBHn43nDjLyAl4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=xMazgm8T; dmarc=none; spf=pass (imf13.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-861525e9b0aso102411139f.3 for ; Thu, 24 Apr 2025 08:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1745508081; x=1746112881; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=49tEuZJbApWmoJu7HSg51xfF3TH4o2He6H3h4M5pJC0=; b=xMazgm8TLrfS3aSnlEjLh2JnpMa0wZUnpDrddkP7WHT22/k4fiu/HzkJfzF1j9A3Ui u/gxPHW4EF+b7E6vIsisl0LLcnTRaGT/KUmdK+eWvUN8xuEjP4fPVycDTZ43sfS8L0xY qfz++tGx+eQafPqGLCc4qumPOzdTJMxSAgA2Lk0kvYEy5P/ywYuUeBO3gajFHIuobEFu 28Oj2kP3cVT8e46FJQdacnmFc9FA5JMSVXynNaSIVyJ1p5AI9ifDavZKg3eX4aJXYd+s GQAa8r8k60xaVQ9m98PiX6Vf5TJJvEG5mCxGLIDnqFkJxaJloaLyvu2NAkGgmPmmCwiA afzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745508081; x=1746112881; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=49tEuZJbApWmoJu7HSg51xfF3TH4o2He6H3h4M5pJC0=; b=qlJtmgiLmVClBEgZ7mOsmRi/SsSoXrtAvQ4VnL2uyOHDVMYRuuTRmiZzHg3celC/Ga eXAPA5f7rB43kNcLalxLEj92QwMmsd8z7QOIW/WQG5KF+mp94SAmZNRH8mtmAs1MlId+ 2W4TabutC2MNbOB1NdC2by+ZQYlDYfX+Rx6QEMyjcKzMGwedjTVhGwhgiyhPhPbyEhhQ Kav5dOuCpinO7sLwbm9di865v6RCC8oJPs/IgIxGJXWWY7M8iEanxZ4QGB+rRsVtXsRL thX9QDSIAd9rd+V8t7lKzMHxLlJEnikZFiD6A26H23NzTHnPY2mjwZtze6Hqs3KGQqS9 Mw1Q== X-Forwarded-Encrypted: i=1; AJvYcCXIjZhbKHftahhVYJJMQKb7zZmuYPQNGdNrHpo36uhLKFLCNjSDkigXwNvSdRTEUplzUmCNHr5tvA==@kvack.org X-Gm-Message-State: AOJu0YxrPS2XPX+5rE9u1J/o4uRTmpnHh8++xol+N9m2blqS38PY3AK6 2zEZ3m+AQRb3UvcE6IF3mw5myU7XEsgOAXIgAKXs+IYC7x2GI3rmxzIV48hnK+Y= X-Gm-Gg: ASbGncsaohLtKlCp+ZOPtCL/4LDTsa960xEaAfn8eXnpRGJGyNNqWf1CSOc7L09d2WQ hJRE5mlaN0gOuAeKGpAVbg7lULduabGbfA9PfNWmCCmiwY0GRgklpbuQxKPOYgBDdqw9CxgYTAW AlBD7WFEQcluKhacLJp5KvvGc1bAb53BCH2X0tmeAIJPIJwlwupMTYc02FqLsOFdHVC0rS2dYPA ZzT12fYRmbeHm+2J0W+arxYlRPmQ7fffjiaGsiTLojwo2TQX4vVUTZ2a3MDOH5L8T6a5+fvVFNj wK3W/7LKBxk5+vPo4dp01MLTR32AQPyVQYmqAl4xdIQ4qrw= X-Google-Smtp-Source: AGHT+IHQTmXyzHLQOzgo/eMfvMWKyYK0kJgCkK9vX/4gp7A9xRnuKW3wH9ylm4KUyuaAHW/QcXl6pw== X-Received: by 2002:a05:6602:150b:b0:864:4812:ca54 with SMTP id ca18e2360f4ac-8644f993375mr399979539f.6.1745508080808; Thu, 24 Apr 2025 08:21:20 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-864519f6330sm23332139f.46.2025.04.24.08.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 08:21:19 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 09:21:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] io_uring: Add new functions to handle user fault scenarios To: =?UTF-8?B?5aec5pm65Lyf?= Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, akpm@linux-foundation.org, peterx@redhat.com, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20250422162913.1242057-1-qq282012236@gmail.com> <20250422162913.1242057-2-qq282012236@gmail.com> <14195206-47b1-4483-996d-3315aa7c33aa@kernel.dk> <7bea9c74-7551-4312-bece-86c4ad5c982f@kernel.dk> <52d55891-36e3-43e7-9726-a2cd113f5327@kernel.dk> <5c20b5ca-ce41-43c4-870a-c50206ab058d@kernel.dk> <1ed67bb5-5d3d-4af8-b5a7-4f644186708b@kernel.dk> From: Jens Axboe Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF56D20019 X-Rspam-User: X-Stat-Signature: 9o711cpo1jzyewwfeg3whdb7u6wyz33t X-HE-Tag: 1745508081-206376 X-HE-Meta: U2FsdGVkX1+IeEJ0s5AY6aD99CgoB4EW1v1O6oRzh4Ur+xacEfMsHOKmcJy+tdzt1B9WJNyuDGpY8dB3/nRCQWeFGuDflsT78kJHZyV/DLKmdCsa8cQqs6HA6rU+lqSFKROnZHIrlu7HypGOSUZ6FZD9kUmpNafV0OwuqauTnT8ZpgOnaneWGKqFTOPvxx0pmfhlnRURrCIQ7g3rTllLlmiV7PLWPQF/ZI9QQ7+UT9Xkg6vdECh/UHb649Votek7b+22Vm/ZgSAr7AtL/cYdn/zq7EAXHAw8vyLhA0IpAJaE/VrYaLM8guhJTCrFBpsj1CcmlPzarOum3zMwShaAEHwExl5dujj2C6CVgY6cRy0i4LQMQvlLTUyHs5bIUXOXTFgwTG2QZivpWUKuiHkgeNdYAk/uwwRSxhJ/6wI5jrwiegWeN64MDZeczKKNqsNJRnUzFYzTKzL0hYYba4OVH71CazhX/gD2j3FD1+YNEdHv2MF7Wkb+jdGiKR6VjZfaAJ5+zHhHkcf1LHRgqaFCTP4yI50xIFiZVPgQk9W0Vk+q1S0+R44PQ0lihnxAiO+cpQsPGmSuCb0bPb34b4/0PtsSIJITVmjgbbZFE/5s/OmBbCOZzQTZtr6jS3760snjmHVFH6oJESBWfdDcd74vfHoKUHlv/+NqwaHe9NlXUHxJcrEQlLbjzeounICTrYw+5wBbHLwID4oSm8lYO8Ejp3EdqfJh7uFPI15a3GgMVPEK61Qogi1AYhpmU5W9E7uxjZSlk4xKAPFkQ+tpzDgT2q1jjaIM73i/BMlB2izeqeGnpQdQMQ0g5Z7tid5xPp/oZj7e+BtUxIJlSf6MG4fVM39ctD3QzlG+bgiq19A5GZKqg2RgT/VYzTA2qS48LU3zk9Xp+Nu/Uk5johj2hztz3wd4rVUE6l+zWL/JnxkPavCHe/T7qsVhA1YsAlGe+LPS8C8JgQTNH7t6CILvUNc VTXalF7L izPedye6SbHZVa8zk7DlwxdCWW28nA2YzpSix9LCJ/rEed5+dnz7BELTTusJOw9ASdjyWN+zm4+mMI8G+knjXa+4uLU1W6HqSL6SPCsjzsm9+2K1+YMmrhSf2GotdSEugu79I7CF1KwF7ML2lcNkvM2jc6I0/dlSZg+s4j1GRlFzytbOp9K9VIfesRunwh9JpoOMYiishsG2TKWlQzs890BERWXBzKZ9iDykoGMZoEqAe847FUqedBSC3e8/buA7JMKJcrHk3+NVzI78xPF8dhuO21of1ISbc7pt4eadn84/ImvmuZnn/V2V8RWuScjQyvPPKgej7qDzC0i9ZBpv3QJsnxk+EGEc45EfMCZw9qRlxnNj3V/SQvjmrj3c847om68Ee9MVIDpU/iwiHLbyX02Y+OzFurw08vgKUl0GXIYTNP5GJobsdeJNiz9sGA/Tjv+7gaazG7+Ad/U157DAAW+obi+yBLKc+8H/4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/24/25 9:12 AM, ??? wrote: > Jens Axboe ?2025?4?24??? 22:53??? >> >> On 4/24/25 8:45 AM, ??? wrote: >>> Jens Axboe ?2025?4?24??? 22:13??? >>>> >>>> On 4/24/25 8:08 AM, ??? wrote: >>>>> Jens Axboe ?2025?4?24??? 06:58??? >>>>>> >>>>>> On 4/23/25 9:55 AM, Jens Axboe wrote: >>>>>>> Something like this, perhaps - it'll ensure that io-wq workers get a >>>>>>> chance to flush out pending work, which should prevent the looping. I've >>>>>>> attached a basic test case. It'll issue a write that will fault, and >>>>>>> then try and cancel that as a way to trigger the TIF_NOTIFY_SIGNAL based >>>>>>> looping. >>>>>> >>>>>> Something that may actually work - use TASK_UNINTERRUPTIBLE IFF >>>>>> signal_pending() is true AND the fault has already been tried once >>>>>> before. If that's the case, rather than just call schedule() with >>>>>> TASK_INTERRUPTIBLE, use TASK_UNINTERRUPTIBLE and schedule_timeout() with >>>>>> a suitable timeout length that prevents the annoying parts busy looping. >>>>>> I used HZ / 10. >>>>>> >>>>>> I don't see how to fix userfaultfd for this case, either using io_uring >>>>>> or normal write(2). Normal syscalls can pass back -ERESTARTSYS and get >>>>>> it retried, but there's no way to do that from inside fault handling. So >>>>>> I think we just have to be nicer about it. >>>>>> >>>>>> Andrew, as the userfaultfd maintainer, what do you think? >>>>>> >>>>>> diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c >>>>>> index d80f94346199..1016268c7b51 100644 >>>>>> --- a/fs/userfaultfd.c >>>>>> +++ b/fs/userfaultfd.c >>>>>> @@ -334,15 +334,29 @@ static inline bool userfaultfd_must_wait(struct userfaultfd_ctx *ctx, >>>>>> return ret; >>>>>> } >>>>>> >>>>>> -static inline unsigned int userfaultfd_get_blocking_state(unsigned int flags) >>>>>> +struct userfault_wait { >>>>>> + unsigned int task_state; >>>>>> + bool timeout; >>>>>> +}; >>>>>> + >>>>>> +static struct userfault_wait userfaultfd_get_blocking_state(unsigned int flags) >>>>>> { >>>>>> + /* >>>>>> + * If the fault has already been tried AND there's a signal pending >>>>>> + * for this task, use TASK_UNINTERRUPTIBLE with a small timeout. >>>>>> + * This prevents busy looping where schedule() otherwise does nothing >>>>>> + * for TASK_INTERRUPTIBLE when the task has a signal pending. >>>>>> + */ >>>>>> + if ((flags & FAULT_FLAG_TRIED) && signal_pending(current)) >>>>>> + return (struct userfault_wait) { TASK_UNINTERRUPTIBLE, true }; >>>>>> + >>>>>> if (flags & FAULT_FLAG_INTERRUPTIBLE) >>>>>> - return TASK_INTERRUPTIBLE; >>>>>> + return (struct userfault_wait) { TASK_INTERRUPTIBLE, false }; >>>>>> >>>>>> if (flags & FAULT_FLAG_KILLABLE) >>>>>> - return TASK_KILLABLE; >>>>>> + return (struct userfault_wait) { TASK_KILLABLE, false }; >>>>>> >>>>>> - return TASK_UNINTERRUPTIBLE; >>>>>> + return (struct userfault_wait) { TASK_UNINTERRUPTIBLE, false }; >>>>>> } >>>>>> >>>>>> /* >>>>>> @@ -368,7 +382,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) >>>>>> struct userfaultfd_wait_queue uwq; >>>>>> vm_fault_t ret = VM_FAULT_SIGBUS; >>>>>> bool must_wait; >>>>>> - unsigned int blocking_state; >>>>>> + struct userfault_wait wait_mode; >>>>>> >>>>>> /* >>>>>> * We don't do userfault handling for the final child pid update >>>>>> @@ -466,7 +480,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) >>>>>> uwq.ctx = ctx; >>>>>> uwq.waken = false; >>>>>> >>>>>> - blocking_state = userfaultfd_get_blocking_state(vmf->flags); >>>>>> + wait_mode = userfaultfd_get_blocking_state(vmf->flags); >>>>>> >>>>>> /* >>>>>> * Take the vma lock now, in order to safely call >>>>>> @@ -488,7 +502,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) >>>>>> * following the spin_unlock to happen before the list_add in >>>>>> * __add_wait_queue. >>>>>> */ >>>>>> - set_current_state(blocking_state); >>>>>> + set_current_state(wait_mode.task_state); >>>>>> spin_unlock_irq(&ctx->fault_pending_wqh.lock); >>>>>> >>>>>> if (!is_vm_hugetlb_page(vma)) >>>>>> @@ -501,7 +515,11 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) >>>>>> >>>>>> if (likely(must_wait && !READ_ONCE(ctx->released))) { >>>>>> wake_up_poll(&ctx->fd_wqh, EPOLLIN); >>>>>> - schedule(); >>>>>> + /* See comment in userfaultfd_get_blocking_state() */ >>>>>> + if (!wait_mode.timeout) >>>>>> + schedule(); >>>>>> + else >>>>>> + schedule_timeout(HZ / 10); >>>>>> } >>>>>> >>>>>> __set_current_state(TASK_RUNNING); >>>>>> >>>>>> -- >>>>>> Jens Axboe >>>>> I guess the previous io_work_fault patch might have already addressed >>>>> the issue sufficiently. The later patch that adds a timeout for >>>>> userfaultfd might >>>> >>>> That one isn't guaranteed to be safe, as it's not necessarily a safe >>>> context to prune the conditions that lead to a busy loop rather than the >>>> normal "schedule until the condition is resolved". Running task_work >>>> should only be done at the outermost point in the kernel, where the task >>>> state is known sane in terms of what locks etc are being held. For some >>>> conditions the patch will work just fine, but it's not guaranteed to be >>>> the case. >>>> >>>>> not be necessary wouldn?t returning after a timeout just cause the >>>>> same fault to repeat indefinitely again? Regardless of whether the >>>>> thread is in UN or IN state, the expected behavior should be to wait >>>>> until the page is filled or the uffd resource is released to be woken >>>>> up, which seems like the correct logic. >>>> >>>> Right, it'll just sleep timeout for a bit as not to be a 100% busy loop. >>>> That's unfortunately the best we can do for this case... The expected >>>> behavior is indeed to schedule until we get woken, however that just >>>> doesn't work if there are signals pending, or other conditions that lead >>>> to TASK_INTERRUPTIBLE + schedule() being a no-op. >>>> >>>> -- >>>> Jens Axboe >>> In my testing, clearing the NOTIFY flag in the original io_work_fault >>> ensures that the next schedule correctly waits. However, adding a >> >> That's symptom fixing again - the NOTIFY flag is the thing that triggers >> for io_uring, but any legitimate signal (or task_work added with >> signaling) will cause the same issue. >> >>> timeout causes the issue to return to multiple faults again. >>> Also, after clearing the NOTIFY flag in handle_userfault, >>> it?s possible that some task work hasn?t been executed. >>> But if task_work_run isn?t added back, tasks might get lost? >>> It seems like there isn?t an appropriate place to add it back. >>> So, do you suggest adjusting the fault frequency in userfaultfd >>> to make it more rhythmic to alleviate the issue? >> >> The task_work is still there, you just removed the notification >> mechanism that tells the kernel that there's task_work there. For this >> particular case, you could re-set TIF_NOTIFY_SIGNAL at the end after >> schedule(), but again it'd only fix that specific one case, not the >> generic issue. >> >> What's the objection to the sleep approach? If the task is woken by the >> fault being filled, it'll still wake on time, no delay. If not, then it >> prevents a busy loop, which is counterproductive. >> >> -- >> Jens Axboe > OK Thanks .and i?m curious about what exactly is meant by a > 'specific one case 'and what qualifies as a 'generic issue' with re-set > TIF_NOTIFY_SIGNAL. I already outlined that in earlier replies, find the email that states the various conditions that can lead to schedule() w/TASK_INTERRUPTIBLE to return immediately rather than sleeping. TIF_NOTIFY_SIGNAL is _one_ such condition, it's not _all_ conditions. > So, in your final opinion, do you think the code in io_uring is not > suitable for modification, should focus on making adjustments in > userfaultfd to mitigate the issue? The problem isn't in io_uring in the first place, you just happened to trip over it via that path. I even sent out a test case that demonstrates how to trigger this without io_uring as well. I'm a bit puzzled as to why all of this isn't clear already. -- Jens Axboe