From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A9DC71155 for ; Mon, 16 Jun 2025 13:57:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55AF96B00C5; Mon, 16 Jun 2025 09:57:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B3B6B00C6; Mon, 16 Jun 2025 09:57:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA146B00C7; Mon, 16 Jun 2025 09:57:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2F9FB6B00C5 for ; Mon, 16 Jun 2025 09:57:12 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C03F59007 for ; Mon, 16 Jun 2025 13:57:11 +0000 (UTC) X-FDA: 83561415462.11.90EAC55 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf07.hostedemail.com (Postfix) with ESMTP id CB06440006 for ; Mon, 16 Jun 2025 13:57:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=q2lEzIrK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=UlemC1XM; spf=pass (imf07.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750082227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4lAhJC3muvon9jedgbAaCqyqhjxND1rEXpFBomEcTyk=; b=f+rWfimINXVHWgIlf3Xyed62xQv8UxHoMYyF7zcrUkr+IWGZaHYJjQLAbMrm1qwKeB/wLG HnyBDCyW0IHXxxHmvdKd4aHaYwZz3LYfZXH90gxHKdzpNN2V/wk9w4fqUfauMD6VarqT2l R/FNLyYn+SJ0XhQOUlSN64xtcbhfT1I= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=q2lEzIrK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=UlemC1XM; spf=pass (imf07.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750082228; a=rsa-sha256; cv=pass; b=5idN54bJg8vP7OoWOglZunjIkNGR39kzEnfLxUKm7taGLICP5Kvif2LHQE9bTzYohurt2w zsQJXLSgujdjLQeW+79BBILrFQjZOZhAK9LklQqo8ERVfAyyFmesSKAKSn2bM171Yp6oOl mVkeH+y7GwImB72+/Mwh9HutjqX6IVI= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G7iQsT019264; Mon, 16 Jun 2025 13:56:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=4lAhJC3muvon9jedgb AaCqyqhjxND1rEXpFBomEcTyk=; b=q2lEzIrK2b+an7DtXyoyp9wReXwfRGpvrA RzaqcS0pBPwTT/WP3vHdcAJiZIfDZr4htLPsw15I+UqF9fuFW1DEeObneZaUfnH9 BebHeaPdppeAn2zrIx0lOLz3H/YuNb+qmRv99udQK3ZjcJeSnIKMCjGuy7rrf1A3 sQqSlkzq8MKUFFjc/hMMlI7Uz+jEWsNMcAm4fB/rYlcaBDU/tDhOjcK9TAkFtJjz NvfQgpPGhHPr3w06ZbUYfpkrtgwUjPZaY0xt1nNieM6iLoGIxir8iMSdtcnUBdK6 HWko+gd+uAToM8dPLZD8CFbj1zv5WBoCJCq9gH/tgyydfCdcOJ0w== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47914ejjr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jun 2025 13:56:58 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55GD5gLP031109; Mon, 16 Jun 2025 13:56:57 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10on2085.outbound.protection.outlook.com [40.107.93.85]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 478yh7xq35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jun 2025 13:56:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kkYq6gxPgiGlEV0k8JVAPNGLBElKIbUU9Oe07sCbI6Pyb77jGZmmEdeI2xBx6aK8TLRc5azUiyL6PSAsvAkclDz9f4I4FbetRjrfvhSTIfe5rnuiRxBPKnYOl07yQbwsMezQHR2O03ojaH6b9gn+SmNUmVGAAEcIQTkrjd86mW0ILO+B8XnzxJoEtWJgKa5YMhppMQPWY4eGrqm+Mun+q/dm5bp0Rx+nos0rffBAsE6zF/INgC61HrMFYv5YK0/EeXHjX370czVVQoil1fEbpX4Gfo1Tjd0lgTWZESak0DGh4DIefqm0zPcrvA0cTKpRE94jWW3a9V5wasoY0hW8tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lAhJC3muvon9jedgbAaCqyqhjxND1rEXpFBomEcTyk=; b=Dz6QQ/Ieqo9H7tVWJUBGr+Rw1SixzhpSxB5nDl3p2o/iNJuuf/4ihKmDstgV5kiE6s1vKG3FliBxQfy17kD3FxARcvZGCBzPq1GhEpnTJ3szShiOqgDme7VlV3ib8qE/tRlZal9fpFH/EtHllRVHa+XrvesC4eq3WQ6IEtffNyAdw+ofv8TqK/SWrQncIEMNiwO8HvTeEoOmz0WEplz4jbO77CSv0eWCh1yoptQ57BbbwhxQh1rADepx42+adWzaKfbqS7DPaNnyB+nYd1BHWQf7WDOy9WHYqHJcSAcKUakkwjtEGl1uye1OCmpXkV+LqPqJ6F6eJi20k3iQd0wjvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lAhJC3muvon9jedgbAaCqyqhjxND1rEXpFBomEcTyk=; b=UlemC1XMJ8yT59qgWIymAGtWAw7mF63ovWW8S/oPlTXP6sXqRFymYsCzmf3m5bP5LOokROSiBtM6/7bZKo6cxyOy8NYETf+kBDTT3YAzaL/XcN7HrpfdJn0q79TVbp1/M/RVWEpKReW6bjg1aAJU7Fjjpal2DWBabGTQyEDxv+E= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by DM4PR10MB6184.namprd10.prod.outlook.com (2603:10b6:8:8c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Mon, 16 Jun 2025 13:56:54 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8835.026; Mon, 16 Jun 2025 13:56:54 +0000 Date: Mon, 16 Jun 2025 14:56:50 +0100 From: Lorenzo Stoakes To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH] secretmem: Remove uses of struct page Message-ID: References: <20250613194744.3175157-1-willy@infradead.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613194744.3175157-1-willy@infradead.org> X-ClientProxiedBy: LO4P265CA0184.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::10) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|DM4PR10MB6184:EE_ X-MS-Office365-Filtering-Correlation-Id: 88bb0ac1-c58e-405c-303e-08ddacdda69a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?W4OLfD+yWSgXGdr5SWU8W3sv5cYsd2TAFprclYoiArEgAfg/6RQKrRRiWsTq?= =?us-ascii?Q?wkh1sLqHwTpOykYUY5dq9rY8ktFuUIWuMWXRL+no6/awnCqEF39wjFWPkU8e?= =?us-ascii?Q?vjVPeO2T8aO9tx3npaGljHQV1MF7OfdCYYPdC25jzskl/dr+C9v5IQRzdx8F?= =?us-ascii?Q?vobA+Io5cgtK+JuBhnAVxn3gHqmpuMJUXnpP/4e7iBPesnAGkYinDC8WV8r/?= =?us-ascii?Q?n3iIIrry853UxkPBdloxcksjvG95gCQoUueyhS7jg0R7+wJl+6AW7Gw2NlyY?= =?us-ascii?Q?oJ1jBqyoJVMZ7MnzhEzUIlsfrD47s7lUj134hh1TZkd54li7HCriVzq5umFP?= =?us-ascii?Q?NhSP7OXH3iwIm9tm9mZYG+oH8TypHnsVyfBlzy+ewJNYruylWyYLvdhQfIug?= =?us-ascii?Q?wKy6Q0hRYvsUrJdt7da37pazNAs2JCTa+wJz/zzl7KcdVVdNDKtuP0EU4WRA?= =?us-ascii?Q?umraV9J8BW7NTzI5WzAlGDluCl7djEl5czHTNJJ/Qi+DvuNQQjTijqDQiHPi?= =?us-ascii?Q?GOX6DSpL2t5Eroz10Za5jVmgc9Ba+pgZBIQVmExAkBLGAwp8X5PWBRxFV/HC?= =?us-ascii?Q?wDvuV0rT1HZh/VGV3uC6We4OxUTt+WrKd4ivHEZ1R2wZtBEmdvzJM9Hv25qj?= =?us-ascii?Q?r/CYaBpYWFa7MLTVwHgZ0D0kjcye/f/ftp6/IYQ+3wMFxr3qTbP96G8Ug7dw?= =?us-ascii?Q?tCcBWFwskZBFAvy2jjeD91g/o0f/ieNacK43ioBwQ5T0dpHvxwAgOD0yM+d7?= =?us-ascii?Q?fTQl+NZgEC3uBEBWEJzvZD4xOtA/iYh9EknoVVqgUX7gpbPilr74ow5ASscB?= =?us-ascii?Q?XQcaLFX+lPBkecORTdN532uimu3qZm1KTtGUQCc5Qa/r+GSQhOZHCxsd00GL?= =?us-ascii?Q?GBDk3Elmem8cgCsYXuQG0EE/Qn3ry9KigrDq9it7htgtbCMCGqBJJ8/Ptpwr?= =?us-ascii?Q?1RFd3k0brosuMSZLq91swCB4Aa73CkVAqPp7LFkCpekqtO3t3vSrR9XY6Yb4?= =?us-ascii?Q?kwnbl7Y522tOFBr2d1YYBbL8F1cayYFxAPxlndjb3OBaGM/OqltAotYOOyQK?= =?us-ascii?Q?J+z8L+mntLyLTjUSTiHR/cr2QJrOHNaxPjmdTnjAF9ixX6j088U5xK9iC3/o?= =?us-ascii?Q?uCYPRTEWsTLDsS59JWI5lsc5hO5xr+/8a2Jx4VwCfX/5AH/9aD3Gw4M1cOYB?= =?us-ascii?Q?6gIGsBkXcIrayY7eYvc3YQ4myDkypDsEsZc1iowo35RmQlg8xtV283kxM4yD?= =?us-ascii?Q?VQsEFf7kYb1U75Por0yk2VGtfuDLuB1iV1cDOYaQG1teguv/uLwoLekoULTu?= =?us-ascii?Q?kM5q75sgbvT26WEHyV0EGmGgV86HbiLYdrrx1OMN2sdQezVhwkODkS/RoPtY?= =?us-ascii?Q?91EafRlcuwLNL0MAnDScKDtc7/7kmZm8Pa8s2+WV/6ET/Rl1WRbbCjSVQYEm?= =?us-ascii?Q?TtUeSUZ0iQQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g0uHPzGhC9r9qyuHWhm309RTLs5CRi+eFxxNCYX+A5KNLq/r5etYxBb207nR?= =?us-ascii?Q?dVl5aR6ZFh7coh16I23Jk8fvH2La6BRlM3AiQomm6X5UTr63NqmokXoWgLj+?= =?us-ascii?Q?YWf2MqOZnFQWuAQ6xv5ATVpqOSjrMds3Olc45zSfwwNhfQndGCFpGcdHjp1y?= =?us-ascii?Q?Z3HyVShI8tLVv9DjGfU+xcvI+al2TNXVLQzK7UfyMqM0azYxKnWHHOwOu1ZZ?= =?us-ascii?Q?eBWvnzenkaOL+Y6nXNNxdR98faB0I5b4kXjxpsZd5LwRt7HM0nozBWM/uv4X?= =?us-ascii?Q?U/LNcPBSv7OJde/I2Tg4exrXTXMvfDUy9NolTRUvxdf7wsPVKlTuMyWclT+w?= =?us-ascii?Q?SpZPrYgk1yDPeisUd9FgbRQgHkkTdQJCN4BBjUg9aeki2u2HEJBZJI7m45F0?= =?us-ascii?Q?VnJNfBc1dEKRLk0sJsbHkzleJaLwfKIWzOp/aIrK16MC5tqidsg3Cf/z/mdZ?= =?us-ascii?Q?HBCPZtWnefF+ya282RfTficnHS4tvPc7L66f5kDT/KxGwQjtMavBRCBy/rK9?= =?us-ascii?Q?Pllc/m00YrLDxXX7KpmY5njOQOvvSmBneRZQiYJE+wZ3IXIeu6kuIBJTDbgb?= =?us-ascii?Q?6dclQIYKqGIDlx9N2UErVw8Jy6l28nWJ5PywAORNTcBN11T9xGIsQpG0rlBo?= =?us-ascii?Q?bTFJtopvRn1TCkWuGyfD9vz1y6IntqPz4CnAcms9Fw9Cy7Ge6FdhT3zX3cUn?= =?us-ascii?Q?WBntiUW/b1c+Jip3VU4pP0crTSgX7AqsVSVHbyjfc2ljIuSyO8hyDrXsl9R1?= =?us-ascii?Q?oCTSBhwAwoTMHBOUL9SR4nv6uOP0zauiYFnm6a6iy60OFi0cse1y7XyNTd9O?= =?us-ascii?Q?UiKn4ub2x/LVgwu3BXYkbdTY66niQ3IXkV2XM1VmEWO9zta41/lgW5UbyzMq?= =?us-ascii?Q?kVXavRJL/swVmUnxGFYs4HTa32uYVcWn0zwAUhR5DEFlMUhUl7gow3Bz8vNq?= =?us-ascii?Q?9i8IVGAeUgF+zc0lVGfeu8seICEWeH7xqjr72ii8hnmWvtIY9zwwh9moQK5E?= =?us-ascii?Q?BdZ/yPtDW8pqa1eXL44wR0Ko2QadVPoCz5G0xC5dxrqSZwUrEGX6PPWB0ogt?= =?us-ascii?Q?27HBNi9+aii7vcU2bO40qjUVXMFwMvoYeU5HuIgng6IOU6ZVJkDYz8Zs+Ct5?= =?us-ascii?Q?aVVg7hN920a5W5AuVn8DFn3H9GPDkfe988RQvwhzUPmvCfzLt6mqoCLCvK7V?= =?us-ascii?Q?OU3tdL54YHwOcVoExsF/RhLpKr5DxpOQJG1ynFZ5rFADx2hi53n2mHpfsuzP?= =?us-ascii?Q?HJsZrSwWp+8tinJhEmDLlb4KAm3ztpViTr73sz0qezirWCpWT7QEGMs4ued0?= =?us-ascii?Q?zGogF2NgKewIMq9ONuv7bt88QbdB0XtmH8b2JATUXJcuvXCFyFnEg3PkbqOP?= =?us-ascii?Q?U6baW6SHuXIZcaZ10aksPuWXit86gtKPtfB7GVFXvddkfb789uoweRkxm2iF?= =?us-ascii?Q?P7XJVCfpgDtG6WrxwibH0aB2qNFp1r3d+sspz9pTu6Od9j6PDSnqchwtNr0M?= =?us-ascii?Q?E2eUdf+ornAICR6vjmfzxwPbxCWdoAVQKDdglNFntnpgLoD5dz6qmY9mIcvK?= =?us-ascii?Q?NTuP7wV9MO+Nj4ZGZWLq5Cckx/6/FWwDBzOoZ7vm0b6ogQqkph8OqBWxq0ym?= =?us-ascii?Q?Yw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +Cx8VG1o3G+C0wHyJqroO6qLLSA5LJ2A6w9+30gbToiok0vy5Ie38hsNu+k9E7J6Vb75zf9pPLKg0ZYNkgcSbgjLSNyaqJJpgP4CJrv7AFFbRYY2XbXWXtEv59lWQfDEfQDalChT143Ash9OR8Pr84FGYCXIgBvM+F42r0UVm3AZvSWDVd5cqlR//zSow5bLLK2wVAjGnsVpf+465pK2HVWb7xSH3yjTUbj7NvBAtOKJnf6YuSy15ZxMjbhzQjzMCeI/SaaF+L8C5FyTn8SWidt14uOJpbnzFbCyWEaHeJriPx3YPzoqBX/niQZO2OHGsaUez0vnihZ7Df8zJfTnxiXcGutbJDEloMDJ+fO2MGi5gt9rdH3vK/kiw6VGbalvzIx/Ks4ZlPYiA0E6/m8SsHeMjkF1DNCqBNPj5DlsMCFceO07GDspGGI9GTMI6h3uL/F0dRsujJLibrNOhoWM0aQ/shIe9sMutlZ3PJM2llxPXNS2pDJC91A0uTzAymjwZycD/sF+BbsxgRVKY4LXiakzlo7veCEKbNgxONxTl7Yv5Ceuvz+Ga5drqWYZZUFQA+2303IUcnbEmM7JUeARcEcmXTJuZbdC7wxTO+/2xEQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88bb0ac1-c58e-405c-303e-08ddacdda69a X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 13:56:54.3529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gsVuM4ZnnGLAJZTkYzJBNkYUOlOe0QdkgRnjpUFuVCJbdA7Ghxb3cAPVSH+vMvc6//78QKyzUFzjR+4hAwhVgRoUTRetVNvFcmPlksakNos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6184 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_06,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506160087 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDA4NyBTYWx0ZWRfX+01MUAzBClsE HzVszMpDvfene+BFOYWUK7g6a/XRQWRjGd09BD2uV6dHGSKbZ3yvETa8lKUipgsKrnY47nz4Ym1 8RbJQBR8T7w8tNRiRAajPV7yriY/YKgDPpSMkw96JH1FMAdXKcy66uVJHV0vLuM1vqy+52ZZhlo Cqrys37h5Y38pwMLFLOsyP1A8lgoMZ5tPnzGD/rN+t7lfcWuLdIhKsobYHYsrnYfHcfmFzgb49e 7ErAl3vk2y3Fq9dyIRDSoPUd5IS2N9728K8jAfQRyoCO6t7btmFpaTGHp0D6wHhed2DpL95kGgO uv5bl3dqEyg/Q1osqvOejnOTWnnWw4uhJ+egZH6BArRUg1wV9q+XjFb793062ElOJ6my/2xregr yOAh8IDn9Jva5xeQfPL1DT6RUmXIX5Ftk18PJSGQuBQY6FU2FYFztqi3hEuc+KyVDNLBzVW2 X-Authority-Analysis: v=2.4 cv=U4CSDfru c=1 sm=1 tr=0 ts=685022aa b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=JfrnYn6hAAAA:8 a=yPCof4ZbAAAA:8 a=eESrPS-ZF-vQfp5j0pUA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-GUID: eaNubcNjlNtp1my_x86GfI8iSSDtVP0z X-Proofpoint-ORIG-GUID: eaNubcNjlNtp1my_x86GfI8iSSDtVP0z X-Rspamd-Queue-Id: CB06440006 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: pnq8h8a9ayoims9dxcynosy918k5hrx7 X-HE-Tag: 1750082227-912875 X-HE-Meta: U2FsdGVkX1/Hu5MHO0VNzX3vDWP6OIAW2sc8XViMY6rhyh6OwXsmelUnKECIGAEE3rJJEBjqMxMZt+uYuQwa9vgL+HKjJ1oILfupvNcyhUKV4c2xJQ0xcHwtYTOXMnmINITcWMGYsouEEgpRJ4VMKUpSAmDIiqeYn37QXik6qbA84bR1psFTp8KvwN6HFjFzC2yO3E/Aka+eWvLqGnEgbSRjQyQu32fNdixwUDnqZMh6BtlK5LNo/jdyq7EM4allWCcRM5Btr/sATkAk2ML00tGdYc1dnSj9sT4Mk/MdFdZ61KzohN6oN/JEMrNHUHGOHArBdhzBwgygDrLxU2t+39jhRv7eTyybgYSLduATUB6z0Yk1C9PMitIZk5OWOEb9NMgeJ1L76IABRxM4zY0dyXM6aiYy4yN42XwtgFBG7VZH0+evJn56kyO9Tg2cfb1tmjLC89v05PC45ec1wIQ4BNKwnBpTu+8U6q/hZP4WMJ733PxqQYfIMCn9p4DxRH9HDiGS359wlNB494dHJ5L9kc++/RFNyL4U2XNnXodxJqXAJYrzGUuCDWZTZZ76BuD4YInkvt00Bi5K4Ibd2pa6Ca3TkvuROcWNGioSrldqyqbxuHVb0BLincGgHG7md4d2mhZITEjDTFXFkvsnnYEEW7NMjahv7TO2us8wciU+CEi+uBHy6w4KJzNdEFphreP0MITBW0Lhoy5s3ybco2qUT4/r7gvpIILg0AyKRaDpAFUrq2X1kPNlWWo5GM4pNwf6PpKC2kzXvuhg5/wOlYqq8P96O6yMJP4dhzREBS7a4kKBE+VPdnEq3a4u+wEnx3BqSZMsFB1bLXdNXAXc8GekC8sQZX+6TKaAfirs83917+60i6ap5bY/3IuKtf2EL73ggm9I0CEPuVRhNSwDY5wYwrXB0NALzCn//6rezMsy059xBFaFHZKhYtIpyDaUEEx3hQ8or32AJw0scgHrE4s nTTnFXV0 KijtUZ4UABdfG0pc7Dbew82kQqZ593dCrJQUZTAymAIpCv/U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew, This patch is causing a kernel splat when running the memfd_secret kernel mm self-test. This is because find_lock_page() handles errors from filemap_lock_folio(), filtering them as NULL, but using filemap_lock_folio() directly does not. I attach a fix-patch that fixes this for me locally... Cheers, Lorenzo On Fri, Jun 13, 2025 at 08:47:43PM +0100, Matthew Wilcox (Oracle) wrote: > Use filemap_lock_folio() instead of find_lock_page() to retrieve > a folio from the page cache. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 589b26c2d553..dfa8d8d10bcb 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -54,7 +54,6 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > pgoff_t offset = vmf->pgoff; > gfp_t gfp = vmf->gfp_mask; > unsigned long addr; > - struct page *page; > struct folio *folio; > vm_fault_t ret; > int err; > @@ -65,16 +64,15 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > filemap_invalidate_lock_shared(mapping); > > retry: > - page = find_lock_page(mapping, offset); > - if (!page) { > + folio = filemap_lock_folio(mapping, offset); > + if (!folio) { > folio = folio_alloc(gfp | __GFP_ZERO, 0); > if (!folio) { > ret = VM_FAULT_OOM; > goto out; > } > > - page = &folio->page; > - err = set_direct_map_invalid_noflush(page); > + err = set_direct_map_invalid_noflush(folio_page(folio, 0)); > if (err) { > folio_put(folio); > ret = vmf_error(err); > @@ -90,7 +88,7 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > * already happened when we marked the page invalid > * which guarantees that this call won't fail > */ > - set_direct_map_default_noflush(page); > + set_direct_map_default_noflush(folio_page(folio, 0)); > if (err == -EEXIST) > goto retry; > > @@ -98,11 +96,11 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > goto out; > } > > - addr = (unsigned long)page_address(page); > + addr = (unsigned long)folio_address(folio); > flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > } > > - vmf->page = page; > + vmf->page = folio_file_page(folio, vmf->pgoff); Small nit here: we've already put vmf->pgoff in offset so could just use offset here. Same goes for the opening check in this function actually... > ret = VM_FAULT_LOCKED; > > out: > @@ -154,7 +152,7 @@ static int secretmem_migrate_folio(struct address_space *mapping, > > static void secretmem_free_folio(struct folio *folio) > { > - set_direct_map_default_noflush(&folio->page); > + set_direct_map_default_noflush(folio_page(folio, 0)); > folio_zero_segment(folio, 0, folio_size(folio)); > } > > -- > 2.47.2 > > > ----8<---- >From 850c9ecb82859fe572452cad93b917964b648141 Mon Sep 17 00:00:00 2001 From: Lorenzo Stoakes Date: Mon, 16 Jun 2025 14:56:27 +0100 Subject: [PATCH] fix Signed-off-by: Lorenzo Stoakes --- mm/secretmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/secretmem.c b/mm/secretmem.c index dfa8d8d10bcb..873f23c6e92b 100644 --- a/mm/secretmem.c +++ b/mm/secretmem.c @@ -65,7 +65,7 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) retry: folio = filemap_lock_folio(mapping, offset); - if (!folio) { + if (IS_ERR(folio)) { folio = folio_alloc(gfp | __GFP_ZERO, 0); if (!folio) { ret = VM_FAULT_OOM; -- 2.49.0