From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE3AC369BD for ; Sat, 19 Apr 2025 03:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00116B0008; Fri, 18 Apr 2025 23:48:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAFED6B000A; Fri, 18 Apr 2025 23:48:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979B06B000C; Fri, 18 Apr 2025 23:48:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 772766B0008 for ; Fri, 18 Apr 2025 23:48:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A0E01CFA89 for ; Sat, 19 Apr 2025 03:48:02 +0000 (UTC) X-FDA: 83349410004.23.533642C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B905340004 for ; Sat, 19 Apr 2025 03:47:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BHOg8rJ4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745034479; a=rsa-sha256; cv=none; b=bfqCEnc53/BO5XvKv5luZpeS/Z4DzjQSo0+g8NBxYk/YX59TjTXW7lxjJdxp182RBDJ96S ixYiLpmaHzTZ9BGxlM4/sbQ6YWhtM4tqsN/1yBtbFYSVU0B0wtWfugk9S5XVPBfpLsgLrB mEbF13+NbfAeAlV8xdCt8phUfP3UYKo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BHOg8rJ4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745034479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=euRBpjQMecmcoooO18bxyQ49tEv+DDvKLc7+lXs5X2Q=; b=Vose0VurVu+mm9OEOFI87zON7sXvzA2u8jFbfJUAMB0e1WK4VEn+nonj7oKrYjWCTkyF43 jdDN+37pPXnUVghH429VxzCzON8skq9pAFCW7r6ZcAoGq0YOJdoyLhKvBPPrDY7p2VQbSS 5/3v8fj3Crh9yQkBaPHbNfbvVbB3YQ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745034479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=euRBpjQMecmcoooO18bxyQ49tEv+DDvKLc7+lXs5X2Q=; b=BHOg8rJ4LGGj+7obVHi1tfMEgQR26uqp9J5K9T1SStPSxvErXCzfD+vi/t9clVTFvQPP9E w9UpqkmOIgkFJLvBTNP3i/lqdDU2wB2j0euW8C8CmdJFKnquYMYPXOWzMOOTwPGMl+/EMJ HHPFPXZXO6Jeh0QFSAfMV7IuDuNkB8M= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-ovfQIUNyMVqlu5JYfLt1CA-1; Fri, 18 Apr 2025 23:47:57 -0400 X-MC-Unique: ovfQIUNyMVqlu5JYfLt1CA-1 X-Mimecast-MFC-AGG-ID: ovfQIUNyMVqlu5JYfLt1CA_1745034477 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6f2b4ab462cso18613476d6.3 for ; Fri, 18 Apr 2025 20:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745034477; x=1745639277; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=euRBpjQMecmcoooO18bxyQ49tEv+DDvKLc7+lXs5X2Q=; b=jMot/8Y8x8mbFOyckpVDd7bQKNnZcwZUzi2WS2qYcTWzjmFKPN7T2ZJzYXgWSwTwe/ Z4ZnNmroNznS/obYZEMZ0TDFo/a+yaJJqWiEUDiR1IY3XEy2yf+tzib4yToTU8ipN/nS tdk9Q/ciBz41iJFPVyBLyeP2YNdNY+8r3YqgElJ79kCEhec5KgxCj+P9Wns3grmBziuG CoOBGmMk2AJL56/cj7GbTdxDy3sfr7D2RLB5HhCVG+zN+6CExw86a0OSiy+9CM6QKhBc 8nXuV6in19qtcINyKd3e3ivoBhI1dAOtXzL/S8ovRIJp87wUgj/Nh4ueCJcLMmP2jffQ axAQ== X-Forwarded-Encrypted: i=1; AJvYcCUup2TymM37brR6A6CEQXm+0PC9VoFJg65A8PPG/5JTe5Su/a+g71z3suSITuKCdVzqgPFOTLpMRw==@kvack.org X-Gm-Message-State: AOJu0Yxlo+j6k6ziHwHE+s2q78GWKEM8Ofo6b119EZY0VODC8KR5PLTl ZOF+Em7455zinSDSCwHYLZCaS2Gm59g76LZOYWJ+PwwQEfnUYyaxIfuRagm77/gVpvsmnbfwUhA GbgE/haf/7uJvqNLloFUD5IU6yVmzufEt23At3/gufEVxB/VQ X-Gm-Gg: ASbGnctpfiJiajKSL49z0kYcJa5JPu73JSOmljO+/oDc51CxSzKsm9BcThXAclU3tmS /pVs0506yKUZVSOyHGXskgImsdcaV9UXVOk3s2Kzu7CAWGyXZooVDc2mEaVY6jA2nl3bzCA+r1M If8MSKZWqm+WLi/5w0W46qa8jAw+A7IvJYmAXgztLCxoVP/uqOBrcXaxDwcSnwZQ1w3BrfosNPV 7g56WtaBT3VEAf7oOQtdzS3hMiNQBEoQMO+RdxarQU7mGRSXeLJyNb051gKyjUv/TJagCzWZ5+l Ujane/yuFm8knasF6FbFi20OjZwJgAaPFzJc5m6HMhJFLUZJmg== X-Received: by 2002:a05:6214:21ee:b0:6e8:f9e6:c4e2 with SMTP id 6a1803df08f44-6f2c46458c0mr97829386d6.32.1745034477055; Fri, 18 Apr 2025 20:47:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkLsrK0DDA6WUJeYeccHnK40MNGALJUBAhTBwVewhL/xZHtjUTmB0r5Q5IR+oPqEiugxed9g== X-Received: by 2002:a05:6214:21ee:b0:6e8:f9e6:c4e2 with SMTP id 6a1803df08f44-6f2c46458c0mr97829276d6.32.1745034476762; Fri, 18 Apr 2025 20:47:56 -0700 (PDT) Received: from [192.168.130.170] (67-212-218-66.static.pfnllc.net. [67.212.218.66]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2af13f9sm17594616d6.14.2025.04.18.20.47.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 20:47:56 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Fri, 18 Apr 2025 23:47:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim To: Gregory Price , Tejun Heo Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mkoutny@suse.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lO7Q6uLjQ_ih6oPMUdXnyKg1twC6ucc2qLOucfijjNc_1745034477 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B905340004 X-Stat-Signature: fkopmg3okg7gah3xgbwscqi5kckgbgux X-HE-Tag: 1745034479-748490 X-HE-Meta: U2FsdGVkX1/kTZwpSLWW7+bJz8Q5GunmR2Dk+MH6ELJB11NetIyU4hgIDVnYfjwcJ8zVG10fxqPEgIYzuY6ic9pIYzAOcHLBxUnopkjkUeFxXlABtuVV6lDDu70lh1hWB5ieL2hcH3D+6RmFjmbynLXo3coLSUmWu3HUQSOxu27nl36+F8V554iQHrME21XCON9Gv412lBPcFtkdn3GUpj8XDagj39sp7Z55QMEWLLwI8Ajy1ArWn1njPId5j0FoGWDFlRx2aHJJsCkHy49ee8DZ+mQFwPiCliPjZhpcvwLH4lL3LY7lnvYZTMUmf5R3wPFfvbSBojHQJaUgw+2xzjLK5pja8yY/k6jvthhKjAVUlT11mnWs84y1+I4YbBu9FoM1lc0W7NKbV53e5cXDy1oLC4R5nRPnkprkN+42XMGQ3a2gT1m1hhVT5PJ5CfB/VHMSAWxexGKCOP4/4b8iSRwe+OVKU+OVKBiRXtsIBi4PEhLSBp8L+E5EPlgglrPiQ7WLu9qnTjJSBXDGyeefCs5vc+upZISbqVD07Y7LdDCWWhT0WS+xpKmreHeATFKpxBAkBi7RyRfIX6dHulbrokcbr8ZGDbxgcHDv69U1WZUeFlNYuJWba6X8Qr1ibpV9tsBs9L3TV7Svgv4oO0Z9iCFxMzu6Tauam/JaJUVt2mG07904231kbBaJj1P2umNpsHYv7HnLBE9howlsrEI7anpigQ845ljy0LJQl5dprVvro1kDp7Fqyv8l5hcjqY36E8nQGH4oOtYneW09vt3JZYkwJ2s4VCs0hsBo/UdX3LHTezKu9PzSa93sfkrJ0zwTR8qiWbFd8GKJtXn85kbtCgV90qHINycN0YTsxnV7cT7vc9EIgpfw1Svw7TridaQ6tQGg1UO1YfA+cMzZCNv0WdHxiFLZoRdlcDnkTmkpd4Ol9mAcBaCruuNdnTKNdpC1p0rLvefVMoIqU5sJ/Dj Bg1+n4vX 0IOxf23wBnMpT/2+9gLOs7amRg7TS9gL3yMH980Q0cFTIiFhKYJIw2WAeJwehJNOvxMchyyBgGIfJI7jialxsWS5zSd9EuOKGWRr5nIH+5tlhTKb7624rnRabMSAtTdIGEm5MM5w/xh661tVBhGFyB5VfoQ6U126S536VCTPN50U1ywaS6ThICDLyn784FCt0mFSlkz69akB741mfTUAuZPGxZLTgZsYGO9y4maOs/lqEbdpqz+kEDQOSh+URBNy3YvJi+iuO4o+0NpNkSmWSgF0D4k5+W0WNnYXwqq8UUA0uUEXMq8mTg4taEB3X6UlZt3B89WT1fzBTUI093VU/ACBNvYNr/GdIkZx7gWg0gO9OTGihzGZi9R57GapvV5fL/7dA6PaE3DAX3qpYQKdkzZ9cbGVEOKMtd+LbGivxsZNFo3XZBNfyGUW5VA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/18/25 11:27 PM, Gregory Price wrote: > On Fri, Apr 18, 2025 at 05:06:20PM -1000, Tejun Heo wrote: >> Hello, >> >> On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote: >> ... >>> +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid) >>> +{ >>> + return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true; >>> +} >>> + >> ... >>> +bool cgroup_node_allowed(struct cgroup *cgroup, int nid) >>> +{ >>> + return cpuset_node_allowed(cgroup, nid); >>> +} >> ... >>> +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) >>> +{ >> What does the indirection through cgroup_node_allowed() add? Why not just >> call cpuset directly? >> > This is an artifact of me trying to figure out how to get this to build > with allconfig (matrix of CPUSET and MEM_CGROUP). > > I think you're right, I can probably drop it. I was trying to write : > > bool cpuset_node_allowed(struct cpuset *cs, int nid); The cpuset structure isn't exposed externally. So you can't use cpuset from outside cpuset.c. Passing the cgroup structure is the right approach. Cheers, Longman > > and just couldn't do it, so eventually landed on passing the cgroup into > the cpuset function, which means I think I can drop the indirection now. > > Will push it and see if allconfig builds. > > Thanks > > ~Gregory >